From b60ad98b34ba4968a6f613193a5f5fc905aaa9f8 Mon Sep 17 00:00:00 2001 From: Will Abson Date: Fri, 16 Dec 2016 14:32:04 +0000 Subject: [PATCH 1/3] Prevent FAYT results from re-appearing after login Refs #1294 --- .../src/components/alfresco-search-control.component.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts index 3f0c1cc859..2f32433a3f 100644 --- a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts +++ b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts @@ -111,7 +111,6 @@ export class AlfrescoSearchControlComponent implements OnInit, OnDestroy { } private onSearchTermChange(value: string): void { - this.setAutoCompleteDisplayed(true); this.liveSearchTerm = value; this.searchControl.setValue(value, true); this.searchValid = this.searchControl.valid; From 5c2145dcf8f427c1a2808314ed80a72443880a24 Mon Sep 17 00:00:00 2001 From: Will Abson Date: Fri, 16 Dec 2016 14:33:05 +0000 Subject: [PATCH 2/3] Ensure MDL search control input gets activated Refs #1294 --- .../src/components/alfresco-search-control.component.html | 2 +- .../src/components/alfresco-search-control.component.spec.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.html b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.html index ed950027f0..0343158ec7 100644 --- a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.html +++ b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.html @@ -4,7 +4,7 @@ search
- { let fixture: ComponentFixture; let component: AlfrescoSearchControlComponent, element: HTMLElement; + let componentHandler; beforeEach(async(() => { + componentHandler = jasmine.createSpyObj('componentHandler', ['upgradeAllRegistered', 'upgradeElement']); + window['componentHandler'] = componentHandler; TestBed.configureTestingModule({ imports: [ CoreModule From 8058b583dca866df4ff37a6e643b274de3a2e013 Mon Sep 17 00:00:00 2001 From: Will Abson Date: Fri, 16 Dec 2016 14:34:02 +0000 Subject: [PATCH 3/3] Do not disable FAYT results after previewing file Refs #1294 --- .../components/alfresco-search-control.component.spec.ts | 6 +++--- .../src/components/alfresco-search-control.component.ts | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.spec.ts b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.spec.ts index c197b1faee..800dcae8a0 100644 --- a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.spec.ts +++ b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.spec.ts @@ -351,7 +351,7 @@ describe('AlfrescoSearchControlComponent', () => { }); }); - it('should set un-active the search after file/folder is clicked', () => { + it('should set deactivate the search after file/folder is clicked', () => { component.searchActive = true; component.onFileClicked({ value: 'node12345' @@ -360,13 +360,13 @@ describe('AlfrescoSearchControlComponent', () => { expect(component.searchActive).toBe(false); }); - it('should reset the search term after file/folder is clicked', () => { + it('should NOT reset the search term after file/folder is clicked', () => { component.liveSearchTerm = 'test'; component.onFileClicked({ value: 'node12345' }); - expect(component.liveSearchTerm).toBe(''); + expect(component.liveSearchTerm).toBe('test'); }); }); }); diff --git a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts index 2f32433a3f..f49c056910 100644 --- a/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts +++ b/ng2-components/ng2-alfresco-search/src/components/alfresco-search-control.component.ts @@ -170,8 +170,7 @@ export class AlfrescoSearchControlComponent implements OnInit, OnDestroy { } onFileClicked(event): void { - this.liveSearchTerm = ''; - this.searchActive = false; + this.setAutoCompleteDisplayed(false); this.fileSelect.emit(event); }