From c6ddfe46cf8aa98c05311a03e6704b0c357be79b Mon Sep 17 00:00:00 2001
From: davidcanonieto <david.cano.nieto@gmail.com>
Date: Thu, 29 Aug 2019 14:59:07 +0100
Subject: [PATCH] [ADF-4816] Move localization keys for About component from
 demo-shell to core (#5007)

---
 demo-shell/resources/i18n/en.json   | 12 ------------
 lib/core/about/about.component.html | 16 ++++++++--------
 lib/core/i18n/en.json               | 12 ++++++++++++
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/demo-shell/resources/i18n/en.json b/demo-shell/resources/i18n/en.json
index 6f13ce31f6..f7b32c060c 100644
--- a/demo-shell/resources/i18n/en.json
+++ b/demo-shell/resources/i18n/en.json
@@ -304,18 +304,6 @@
     "ROLE_FILTER_MODE": "Filter by role",
     "PRESELECT_VALIDATION": "Preselect validation"
   },
-  "ABOUT": {
-    "TITLE": "Plugins",
-    "TABLE_HEADERS": {
-      "ID": "ID",
-      "NAME": "Name",
-      "VERSION": "Version",
-      "VENDOR": "Vendor",
-      "LICENSE": "License",
-      "RUNTIME": "Runtime",
-      "DESCRIPTION": "Description"
-    }
-  },
   "SETTINGS_CLOUD": {
     "MULTISELECTION": "Multiselection",
     "TESTING_MODE": "Testing Mode",
diff --git a/lib/core/about/about.component.html b/lib/core/about/about.component.html
index 8d9eae91d5..407a203f4e 100644
--- a/lib/core/about/about.component.html
+++ b/lib/core/about/about.component.html
@@ -70,47 +70,47 @@
     <adf-datatable [data]="dependencyEntries"></adf-datatable>
 
     <div class="adf-extension-details-container" *ngIf="showExtensions">
-        <h3>{{ 'ABOUT.TITLE' | translate }}</h3>
+        <h3>{{ 'ABOUT.EXTENSIONS.TITLE' | translate }}</h3>
         <mat-table [dataSource]="extensions$ | async">
             <!-- $id Column -->
             <ng-container matColumnDef="$id">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.ID' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.ID' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$id}}</mat-cell>
             </ng-container>
 
             <!-- $name Column -->
             <ng-container matColumnDef="$name">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.NAME' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.NAME' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$name}}</mat-cell>
             </ng-container>
 
             <!-- $version Column -->
             <ng-container matColumnDef="$version">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.VERSION' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.VERSION' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$version}}</mat-cell>
             </ng-container>
 
             <!-- $vendor Column -->
             <ng-container matColumnDef="$vendor">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.VENDOR' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.VENDOR' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$vendor}}</mat-cell>
             </ng-container>
 
             <!-- $license Column -->
             <ng-container matColumnDef="$license">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.LICENSE' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.LICENSE' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$license}}</mat-cell>
             </ng-container>
 
             <!-- $runtime Column -->
             <ng-container matColumnDef="$runtime">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.RUNTIME' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.RUNTIME' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$runtime}}</mat-cell>
             </ng-container>
 
             <!-- $description Column -->
             <ng-container matColumnDef="$description">
-                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.TABLE_HEADERS.DESCRIPTION' | translate }}</mat-header-cell>
+                <mat-header-cell *matHeaderCellDef>{{ 'ABOUT.EXTENSIONS.TABLE_HEADERS.DESCRIPTION' | translate }}</mat-header-cell>
                 <mat-cell *matCellDef="let element">{{element.$description}}</mat-cell>
             </ng-container>
 
diff --git a/lib/core/i18n/en.json b/lib/core/i18n/en.json
index 9937d1ead5..f87a2fe1f1 100644
--- a/lib/core/i18n/en.json
+++ b/lib/core/i18n/en.json
@@ -438,6 +438,18 @@
         "CLUSTER_ENABLED": "Is Cluster Enabled",
         "CRYPTODOC_ENABLED": "Is Cryptodoc Enabled"
       }
+    },
+    "EXTENSIONS": {
+      "TITLE": "Plugins",
+      "TABLE_HEADERS": {
+        "ID": "ID",
+        "NAME": "Name",
+        "VERSION": "Version",
+        "VENDOR": "Vendor",
+        "LICENSE": "License",
+        "RUNTIME": "Runtime",
+        "DESCRIPTION": "Description"
+      }
     }
   },
   "CLIPBOARD": {