Improve build stages (#3744)

* travis precache

* rb change

* remove ut

* add cache warm up

* Prepare cache fix

* add test

* use env variabble to tag

* use env to label stages

* move lint step at start

* use dist for e2e

* upload dist in alfresco

* modify permissions

* travis script node

* remove polyfills

* revert some changes

* fix demo shell run test

* solve download

* revert debatable gallery change

demo-shell/src/app/app.module.ts

@@ -96,7 +96,7 @@ import { ProcessModule } from '@alfresco/adf-process-services';
         ProcessModule.forRoot(),
         ThemePickerModule,
         ChartsModule,
-        MonacoEditorModule.forRoot(),
+        MonacoEditorModule.forRoot()
     ],
     declarations: [
         AppComponent,

demo-shell/src/app/components/app-layout/app-layout.component.ts

@@ -19,7 +19,6 @@ import { Component, ViewEncapsulation, OnInit } from '@angular/core';
 import { UserPreferencesService, AppConfigService, AlfrescoApiService } from '@alfresco/adf-core';
 import { HeaderDataService } from '../header-data/header-data.service';
 
-
 @Component({
     templateUrl: 'app-layout.component.html',
     styleUrls: ['app-layout.component.scss'],

demo-shell/src/app/components/files/files.component.ts

@@ -227,7 +227,7 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy {
 
     ngOnInit() {
         if (!this.pagination) {
-            this.pagination = <Pagination>{
+            this.pagination = <Pagination> {
                 maxItems: this.preference.paginationSize,
                 skipCount: 0
             };
@@ -265,7 +265,7 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy {
 
     ngOnChanges(changes: SimpleChanges) {
         if (changes.nodeResult && changes.nodeResult.currentValue) {
-            this.nodeResult = <NodePaging>changes.nodeResult.currentValue;
+            this.nodeResult = <NodePaging> changes.nodeResult.currentValue;
             this.pagination = this.nodeResult.list.pagination;
         }
         if (!this.pagination) {
@@ -558,7 +558,7 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy {
     }
 
     runCustomAction(event) {
-        console.log(event);
+        this.logService.log(event);
     }
 
     getFileFiltering() {

demo-shell/src/app/components/form/fake-form.service.ts

@@ -28,9 +28,9 @@ export class FakeFormService extends FormService {
     executeOutcome = new Subject<FormOutcomeEvent>();
 
     constructor(appConfig: AppConfigService,
-        ecmModelService: EcmModelService,
-        apiService: AlfrescoApiService,
-        protected logService: LogService) {
+                ecmModelService: EcmModelService,
+                apiService: AlfrescoApiService,
+                protected logService: LogService) {
         super(ecmModelService, apiService, logService);
     }
 

demo-shell/src/app/components/form/form-loading.component.ts

@@ -26,7 +26,7 @@ import { FakeFormService } from './fake-form.service';
     templateUrl: 'form-loading.component.html',
     styleUrls: ['form-loading.component.scss'],
     providers: [
-        { provide: FormService, useClass: FakeFormService },
+        { provide: FormService, useClass: FakeFormService }
     ]
 })
 export class FormLoadingComponent implements OnInit {

demo-shell/src/app/components/header-data/header-data.service.ts

@@ -17,7 +17,6 @@
 
 import { Injectable, Output, EventEmitter } from '@angular/core';
 
-
 @Injectable()
 export class HeaderDataService {
 

demo-shell/src/app/components/permissions/demo-permissions.component.ts

@@ -16,7 +16,7 @@
  */
 
 import { Component, Optional, OnInit, ViewChild } from '@angular/core';
-import { ActivatedRoute, Params} from '@angular/router';
+import { ActivatedRoute, Params } from '@angular/router';
 import { PermissionListComponent, NodePermissionDialogService } from '@alfresco/adf-content-services';
 import { MinimalNodeEntryEntity } from 'alfresco-js-api';
 import { NodesApiService, NotificationService } from '@alfresco/adf-core';

demo-shell/src/app/components/process-list-demo/process-list-demo.component.ts

@@ -22,7 +22,7 @@ import { debounceTime } from 'rxjs/operators';
 
 @Component({
     templateUrl: './process-list-demo.component.html',
-    styleUrls: [`./process-list-demo.component.scss`],
+    styleUrls: [`./process-list-demo.component.scss`]
 })
 
 export class ProcessListDemoComponent implements OnInit {

demo-shell/src/app/components/report-issue/report-issue.component.ts

@@ -19,7 +19,7 @@ import { Component } from '@angular/core';
 
 @Component({
     templateUrl: './report-issue.component.html',
-    styleUrls: [`./report-issue.component.scss`],
+    styleUrls: [`./report-issue.component.scss`]
 })
 export class ReportIssueComponent {
 

demo-shell/src/app/components/settings/settings.component.ts

@@ -16,7 +16,7 @@
  */
 
 import { Component } from '@angular/core';
-import { LogService, } from '@alfresco/adf-core';
+import { LogService } from '@alfresco/adf-core';
 import { Router } from '@angular/router';
 
 @Component({

demo-shell/src/app/components/task-list-demo/task-list-demo.component.ts

@@ -22,7 +22,7 @@ import { debounceTime } from 'rxjs/operators';
 
 @Component({
     templateUrl: './task-list-demo.component.html',
-    styleUrls: [`./task-list-demo.component.scss`],
+    styleUrls: [`./task-list-demo.component.scss`]
 })
 
 export class TaskListDemoComponent implements OnInit {

demo-shell/src/polyfills.ts

@@ -67,23 +67,9 @@ import 'core-js/es7/array';
  */
 import 'zone.js/dist/zone';  // Included with Angular CLI.
 
-/***************************************************************************************************
- * APPLICATION IMPORTS
- */
-
-/**
- * Date, currency, decimal and percent pipes.
- * Needed for: All but Chrome, Firefox, Edge, IE11 and Safari 10
- */
-import 'intl';  // Run `npm install --save intl`.
-/**
- * Need to import at least one locale-data with intl.
- */
-import 'intl/locale-data/jsonp/en';
-
 /**
  * Support custom event in IE11
  *
- * */
+ */
 
 import 'custom-event-polyfill/custom-event-polyfill'; // Run `npm install --save custom-event-polyfill`.

demo-shell/src/tsconfig.dev.json

@@ -36,6 +36,8 @@
     "**/*.spec.ts"
   ],
   "angularCompilerOptions": {
-    "skipTemplateCodegen": false
+    "skipTemplateCodegen": false,
+    "entryModule": "./app/app.module#AppModule",
+    "genDir": "../ngfactory"
   }
 }

demo-shell/tslint.json

@@ -6,10 +6,18 @@
   "rules": {
     "adf-license-banner": [
       true,
-      "**/*.ts"
+      "e2e/**/*.ts"
+    ],
+    "align": [
+      true,
+      "parameters",
+      "statements"
+    ],
+    "ban": [
+      true,
+      "eval",
+      "fdescribe"
     ],
-    "arrow-return-shorthand": true,
-    "callable-types": true,
     "class-name": true,
     "comment-format": [
       true,
@@ -18,18 +26,17 @@
     "curly": true,
     "eofline": true,
     "forin": true,
-    "import-spacing": true,
     "indent": [
       true,
       "spaces"
     ],
-    "interface-over-type-literal": true,
+    "interface-name": false,
+    "jsdoc-format": true,
     "label-position": true,
     "max-line-length": [
       true,
       180
     ],
-    "member-access": false,
     "member-ordering": [
       true,
       {
@@ -41,10 +48,14 @@
         ]
       }
     ],
+    "no-any": false,
     "no-arg": true,
-    "no-bitwise": true,
+    "no-bitwise": false,
+    "no-conditional-assignment": true,
+    "no-consecutive-blank-lines": true,
     "no-console": [
       true,
+      "log",
       "debug",
       "info",
       "time",
@@ -52,20 +63,21 @@
       "trace"
     ],
     "no-construct": true,
+    "no-constructor-vars": false,
     "no-debugger": true,
     "no-duplicate-super": true,
+    "no-duplicate-variable": true,
     "no-empty": false,
-    "no-empty-interface": true,
     "no-eval": true,
-    "no-inferrable-types": [true, "ignore-params"],
+    "no-inferrable-types": false,
+    "no-internal-module": true,
+    "no-require-imports": false,
     "no-shadowed-variable": true,
-    "no-string-literal": false,
-    "no-string-throw": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
-    "no-use-before-declare": true,
     "no-var-keyword": true,
+    "no-var-requires": true,
     "object-literal-sort-keys": false,
     "one-line": [
       true,
@@ -74,20 +86,29 @@
       "check-else",
       "check-whitespace"
     ],
-    "prefer-const": true,
     "quotemark": [
       true,
-      "single"
+      "single",
+      "avoid-escape"
     ],
     "radix": true,
     "semicolon": [
       true,
       "always"
     ],
+    "switch-default": true,
+    "trailing-comma": [
+      true,
+      {
+        "multiline": "never",
+        "singleline": "never"
+      }
+    ],
     "triple-equals": [
       true,
       "allow-null-check"
     ],
+    "typedef": false,
     "typedef-whitespace": [
       true,
       {
@@ -98,26 +119,53 @@
         "variable-declaration": "nospace"
       }
     ],
+    "use-strict": false,
+    "variable-name": [
+      true,
+      "check-format",
+      "allow-leading-underscore",
+      "ban-keywords"
+    ],
+    "callable-types": true,
+    "import-spacing": true,
+    "interface-over-type-literal": true,
+    "member-access": false,
+    "no-empty-interface": true,
+    "no-string-literal": false,
+    "no-string-throw": true,
+    "prefer-const": false,
     "unified-signatures": true,
-    "variable-name": false,
     "whitespace": [
       true,
       "check-branch",
       "check-decl",
       "check-operator",
       "check-separator",
-      "check-type"
+      "check-typecast",
+      "check-type",
+      "check-typecast",
+      "check-module"
     ],
-
     "directive-selector": [true, "attribute", "app", "camelCase"],
     "component-selector": [true, "element", "app", "kebab-case"],
+    "naming-convention": [
+      {
+        "type": "enumMember",
+        "format": "PascalCase"
+      }
+    ],
+    "ordered-imports": false,
     "use-input-property-decorator": true,
     "use-output-property-decorator": true,
-    "no-input-rename": true,
-    "no-output-rename": true,
+    "use-host-property-decorator": false,
     "use-life-cycle-interface": true,
     "use-pipe-transform-interface": true,
     "component-class-suffix": true,
-    "directive-class-suffix": true
+    "directive-class-suffix": true,
+    "adf-file-name": true,
+    "adf-class-name": true,
+    "adf-prefix-name": true,
+    "no-input-rename": true,
+    "no-output-rename": true
   }
 }