inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

TestElement prototype to greatly reduce e2e coding time (#6525)

Browse Source 
* TestElement prototype

* introduce byText wrapper

* extend TestElement api

* cleanup tests a bit more

* cleanup e2e

* more e2e cleanup

* add missing CSS classes

* fix test
This commit is contained in:
Denys Vuika
2021-01-15 11:31:45 +00:00
committed by GitHub
parent 6f3ce8b6f3
commit c9705b06d5
30 changed files with 484 additions and 758 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/process-services/empty-process-list-component.e2e.ts
View File

@@ -71,7 +71,7 @@ describe('Empty Process List Test', () => {
await expect(await processFiltersPage.numberOfProcessRows()).toEqual(1);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
await navigationBarPage.navigateToProcessServicesPage();
await processServicesPage.checkApsContainer();
await (await processServicesPage.goToApp(simpleAppWithUserForm.title)).clickProcessButton();
@@ -86,6 +86,6 @@ describe('Empty Process List Test', () => {
await expect(await processFiltersPage.numberOfProcessRows()).toEqual(1);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
});
});

6
e2e/process-services/form-people-widget.e2e.ts
View File

@@ -80,7 +80,7 @@ describe('Form widgets - People ', () => {
it('[C286577] Should be able to start a process with people widget', async () => {
await startProcess.clickFormStartProcessButton();
await processDetailsPage.clickOnActiveTask();
await processDetailsPage.activeTask.click();
const taskId = await taskDetails.getId();
const taskForm: any = await apiService.getInstance().activiti.taskApi.getTaskForm(taskId);
@@ -92,7 +92,7 @@ describe('Form widgets - People ', () => {
await startProcess.enterProcessName(app.processName);
await startProcess.clickFormStartProcessButton();
await processDetailsPage.clickOnActiveTask();
await processDetailsPage.activeTask.click();
await taskDetails.checkCompleteFormButtonIsDisplayed();
await taskDetails.clickCompleteFormTask();
@@ -100,7 +100,7 @@ describe('Form widgets - People ', () => {
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.selectFromProcessList(app.processName);
await processDetailsPage.clickOnCompletedTask();
await processDetailsPage.completedTask.click();
const taskId = await taskDetails.getId();
const taskForm: any = await apiService.getInstance().activiti.taskApi.getTaskForm(taskId);

86
e2e/process-services/pages/process-details.page.ts
View File

@@ -15,32 +15,32 @@
* limitations under the License.
*/
import { by, element, protractor } from 'protractor';
import { BrowserVisibility, BrowserActions, ProcessInstanceHeaderPage } from '@alfresco/adf-testing';
import { protractor } from 'protractor';
import { ProcessInstanceHeaderPage, TestElement } from '@alfresco/adf-testing';
export class ProcessDetailsPage {
processInstanceHeaderPage = new ProcessInstanceHeaderPage();
processTitle = element(by.css('.mat-card-title'));
processDetailsMessage = element(by.css('adf-process-instance-details div'));
showDiagramButtonDisabled = element(by.css('button[id="show-diagram-button"][disabled]'));
propertiesList = element(by.css('.adf-property-list'));
showDiagramButton = element(by.id('show-diagram-button'));
diagramCanvas = element(by.css('svg[xmlns="http://www.w3.org/2000/svg"]'));
backButton = element(by.css('app-show-diagram button.mat-mini-fab.mat-accent'));
commentInput = element(by.id('comment-input'));
auditLogButton = element(by.css('button[adf-process-audit]'));
auditLogEmptyListMessage = element(by.css('.app-empty-list-header'));
cancelProcessButton = element(by.css('div[data-automation-id="header-status"] > button'));
activeTask = element(by.css('div[data-automation-id="active-tasks"]'));
completedTask = element(by.css('div[data-automation-id="completed-tasks"]'));
taskTitle = element(by.css('.adf-activiti-task-details__header'));
processTitle = TestElement.byCss('.mat-card-title');
processDetailsMessage = TestElement.byCss('adf-process-instance-details div');
showDiagramButtonDisabled = TestElement.byCss('button[id="show-diagram-button"][disabled]');
propertiesList = TestElement.byCss('.adf-property-list');
showDiagramButton = TestElement.byId('show-diagram-button');
diagramCanvas = TestElement.byCss('svg[xmlns="http://www.w3.org/2000/svg"]');
backButton = TestElement.byCss('app-show-diagram button.mat-mini-fab.mat-accent');
commentInput = TestElement.byId('comment-input');
auditLogButton = TestElement.byCss('button[adf-process-audit]');
auditLogEmptyListMessage = TestElement.byCss('.app-empty-list-header');
cancelProcessButton = TestElement.byCss('div[data-automation-id="header-status"] > button');
activeTask = TestElement.byCss('div[data-automation-id="active-tasks"]');
completedTask = TestElement.byCss('div[data-automation-id="completed-tasks"]');
taskTitle = TestElement.byCss('.adf-activiti-task-details__header');
checkProcessTitleIsDisplayed(): Promise<string> {
return BrowserActions.getText(this.processTitle);
return this.processTitle.getText();
}
checkProcessDetailsMessage(): Promise<string> {
return BrowserActions.getText(this.processDetailsMessage);
return this.processDetailsMessage.getText();
}
async checkProcessHeaderDetailsAreVisible(): Promise<void> {
@@ -80,52 +80,18 @@ export class ProcessDetailsPage {
}
async clickShowDiagram(): Promise<void> {
await BrowserActions.click(this.showDiagramButton);
await BrowserVisibility.waitUntilElementIsVisible(this.diagramCanvas);
await BrowserActions.click(this.backButton);
}
async checkShowDiagramIsDisabled(): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.showDiagramButtonDisabled);
await this.showDiagramButton.click();
await this.diagramCanvas.waitVisible();
await this.backButton.click();
}
async addComment(comment: string): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.commentInput);
await this.commentInput.sendKeys(comment);
await this.commentInput.sendKeys(protractor.Key.ENTER);
await this.commentInput.waitVisible();
await this.commentInput.elementFinder.sendKeys(comment);
await this.commentInput.elementFinder.sendKeys(protractor.Key.ENTER);
}
async checkCommentIsDisplayed(comment: string): Promise<void> {
const commentInserted = element(by.cssContainingText('div[id="comment-message"]', comment));
await BrowserVisibility.waitUntilElementIsVisible(commentInserted);
}
async clickAuditLogButton(): Promise<void> {
await BrowserActions.click(this.auditLogButton);
}
getEmptyMessage(): Promise<string> {
return BrowserActions.getText(this.auditLogEmptyListMessage);
}
async clickCancelProcessButton(): Promise<void> {
await BrowserActions.click(this.cancelProcessButton);
}
async clickOnActiveTask(): Promise<void> {
await BrowserActions.click(this.activeTask);
}
async clickOnCompletedTask(): Promise<void> {
await BrowserActions.click(this.completedTask);
}
async checkActiveTaskTitleIsDisplayed(): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.taskTitle);
}
async checkProcessDetailsCard(): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.propertiesList);
checkCommentIsDisplayed(comment: string): Promise<void> {
return TestElement.byText('div[id="comment-message"]', comment).waitVisible();
}
}

2
e2e/process-services/process-attachment-list-action-menu.e2e.ts
View File

@@ -137,7 +137,7 @@ describe('Attachment list action menu for processes', () => {
await attachmentListPage.clickAttachFileButton(pngFile.location);
await attachmentListPage.checkFileIsAttached(pngFile.name);
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processFiltersPage.clickCompletedFilterButton();
await processDetailsPage.checkProcessTitleIsDisplayed();

16
e2e/process-services/process-filters-component.e2e.ts
View File

@@ -93,7 +93,7 @@ describe('Process Filters Test', () => {
await startProcessPage.enterProcessName(processTitle.completed);
await startProcessPage.clickFormStartProcessButton();
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await navigationBarPage.navigateToProcessServicesPage();
await processServicesPage.goToApp(app.title);
@@ -109,7 +109,7 @@ describe('Process Filters Test', () => {
await processFiltersPage.checkFilterIsHighlighted(processFilter.running);
await processFiltersPage.selectFromProcessList(processTitle.running);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
});
it('[C280063] Should both the new created process and a completed one to be displayed when clicking on All filter', async () => {
@@ -121,7 +121,7 @@ describe('Process Filters Test', () => {
await processFiltersPage.checkFilterIsHighlighted(processFilter.all);
await processFiltersPage.selectFromProcessList(processTitle.running);
await processFiltersPage.selectFromProcessList(processTitle.completed);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
});
it('[C280064] Should the completed process be displayed when clicking on Completed filter', async () => {
@@ -132,7 +132,7 @@ describe('Process Filters Test', () => {
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.checkFilterIsHighlighted(processFilter.completed);
await processFiltersPage.selectFromProcessList(processTitle.completed);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
});
it('[C280407] Should be able to access the filters with URL', async () => {
@@ -170,14 +170,14 @@ describe('Process Filters Test', () => {
await startProcessPage.clickFormStartProcessButton();
await processListDemoPage.checkProcessIsDisplayed(processTitle.canceled);
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processListDemoPage.checkProcessIsNotDisplayed(processTitle.canceled);
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.checkFilterIsHighlighted(processFilter.completed);
await processListDemoPage.checkProcessIsDisplayed(processTitle.canceled);
await processFiltersPage.selectFromProcessList(processTitle.canceled);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
});
it('[C213262] Default process filters', async () => {
@@ -193,7 +193,7 @@ describe('Process Filters Test', () => {
await processListDemoPage.checkProcessIsDisplayed(processTitle.one);
await processFiltersPage.checkFilterIsHighlighted(processFilter.running);
await processDetailsPage.checkProcessDetailsCard();
await processDetailsPage.propertiesList.waitVisible();
await checkProcessInfoDrawer({ name: processTitle.one });
await processFiltersPage.clickCreateProcessButton();
@@ -205,7 +205,7 @@ describe('Process Filters Test', () => {
await processListDemoPage.checkProcessIsDisplayed(processTitle.one);
await processListDemoPage.checkProcessIsDisplayed(processTitle.two);
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processListDemoPage.checkProcessIsNotDisplayed(processTitle.canceled);
await processFiltersPage.clickCompletedFilterButton();

16
e2e/process-services/start-process-component.e2e.ts
View File

@@ -323,7 +323,7 @@ describe('Start Process Component', () => {
await startProcessPage.clickFormStartProcessButton();
await processFiltersPage.clickRunningFilterButton();
await processFiltersPage.selectFromProcessList('Audit Log');
await processDetailsPage.clickAuditLogButton();
await processDetailsPage.auditLogButton.click();
await FileBrowserUtil.isFileDownloaded(auditLogFile);
});
@@ -375,8 +375,8 @@ describe('Start Process Component', () => {
await startProcessPage.clickFormStartProcessButton();
await processFiltersPage.clickRunningFilterButton();
await processFiltersPage.selectFromProcessList('Active Task');
await processDetailsPage.clickOnActiveTask();
await processDetailsPage.checkActiveTaskTitleIsDisplayed();
await processDetailsPage.activeTask.click();
await processDetailsPage.taskTitle.waitVisible();
});
it('[C260457] Should display process in Completed when cancelled', async () => {
@@ -391,10 +391,10 @@ describe('Start Process Component', () => {
await startProcessPage.clickFormStartProcessButton();
await processFiltersPage.clickRunningFilterButton();
await processFiltersPage.selectFromProcessList('Cancel Process');
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.selectFromProcessList('Cancel Process');
await processDetailsPage.checkShowDiagramIsDisabled();
await processDetailsPage.showDiagramButtonDisabled.waitVisible();
});
it('[C260461] Should be possible to add a comment on a completed/canceled process', async () => {
@@ -407,7 +407,7 @@ describe('Start Process Component', () => {
await startProcessPage.clickFormStartProcessButton();
await processFiltersPage.clickRunningFilterButton();
await processFiltersPage.selectFromProcessList('Comment Process 2');
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.selectFromProcessList('Comment Process 2');
await processDetailsPage.addComment('goodbye');
@@ -424,7 +424,7 @@ describe('Start Process Component', () => {
await startProcessPage.clickFormStartProcessButton();
await processFiltersPage.clickRunningFilterButton();
await processFiltersPage.selectFromProcessList('File');
await processDetailsPage.clickCancelProcessButton();
await processDetailsPage.cancelProcessButton.click();
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.selectFromProcessList('File');
await attachmentListPage.checkAttachFileButtonIsNotDisplayed();
@@ -531,7 +531,7 @@ describe('Start Process Component', () => {
await processServiceTabBarPage.clickProcessButton();
await processFiltersPage.clickCompletedFilterButton();
await processFiltersPage.selectFromProcessList('Test Process');
await expect(await processDetailsPage.getEmptyMessage()).toBe('This list is empty');
await expect(await processDetailsPage.auditLogEmptyListMessage.getText()).toBe('This list is empty');
});
});

2
e2e/process-services/stencil.e2e.ts
View File

@@ -83,7 +83,7 @@ describe('Stencil', () => {
await processListDemoPage.checkProcessIsDisplayed(name);
await processFiltersPage.selectFromProcessList(name);
await processDetailsPage.clickOnActiveTask();
await processDetailsPage.activeTask.click();
await taskPage.tasksListPage().checkTaskListIsLoaded();
await taskPage.taskDetails().clickCompleteTask();

2
e2e/process-services/task-assignee.e2e.ts
View File

@@ -99,7 +99,7 @@ describe('Task Assignee', () => {
await processFiltersPage.clickNewProcessDropdown();
await startProcessPage.startProcess(name, app.processNames[0]);
await processFiltersPage.selectFromProcessList(name);
await processDetailsPage.clickOnActiveTask();
await processDetailsPage.activeTask.click();
await taskPage.tasksListPage().checkContentIsDisplayed(app.userTasks.simple.one);
await taskPage.tasksListPage().selectRow(app.userTasks.simple.one);