From cb6462bd59bc5980f267ad64502a0d62e29e60ac Mon Sep 17 00:00:00 2001 From: Yasa-Nataliya Date: Fri, 1 Sep 2023 00:13:08 +0530 Subject: [PATCH] [ACS-5645]Implemented changes as per the review comments --- .../content-metadata.component.spec.ts | 3 ++- .../content-metadata/content-metadata.component.ts | 12 ++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts index 0d7054b9de..d4ca5e83a8 100644 --- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts +++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts @@ -110,7 +110,7 @@ describe('ContentMetadataComponent', () => { const clickOnTagsSave = () => { findSaveTagsButton().click(); fixture.detectChanges(); - } + }; const clickOnTagsSave = () => { findSaveTagsButton().click(); @@ -823,6 +823,7 @@ describe('ContentMetadataComponent', () => { describe('Display properties with aspect oriented config', () => { let appConfig: AppConfigService; + let classesApi: ClassesApi; let expectedNode: Node; const verResponse: PropertyGroup = { diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts index 7ce0ce1427..c8b31a21cd 100644 --- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts +++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts @@ -221,6 +221,10 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy { @Input() group: CardViewGroup; + /** Emitted when content's editable state is changed. **/ + @Output() + editableChange = new EventEmitter(); + private _assignedTags: string[] = []; private assignedTagsEntries: TagEntry[] = []; private _editable = false; @@ -514,10 +518,6 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy { return !this.expanded || this.displayAspect === 'Properties'; } - hasAllowableOperations() { - return this.contentService.hasAllowableOperations(this.node, AllowableOperationsEnum.UPDATE); - } - keyDown(event: KeyboardEvent) { if (event.keyCode === 37 || event.keyCode === 39) { // ArrowLeft && ArrowRight @@ -601,6 +601,10 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy { ); } + private isEmpty(value: any): boolean { + return value === undefined || value === null || value === ''; + } + private loadCategoriesForNode(nodeId: string) { this.assignedCategories = []; this.categoryService.getCategoryLinksForNode(nodeId).subscribe((categoryPaging) => {