From cbb501155fc0ddcd7fecdc3270409076a55741a9 Mon Sep 17 00:00:00 2001
From: Amedeo Lepore <amedeo.lepore@hyland.com>
Date: Wed, 5 Jul 2023 15:23:07 +0200
Subject: [PATCH] Fix unit tests core

---
 .../src/lib/auth/basic-auth/basic-alfresco-auth.service.ts  | 2 ++
 .../src/lib/auth/services/authentication.service.spec.ts    | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/core/src/lib/auth/basic-auth/basic-alfresco-auth.service.ts b/lib/core/src/lib/auth/basic-auth/basic-alfresco-auth.service.ts
index 8f7f36e41a..bb5d6d156a 100644
--- a/lib/core/src/lib/auth/basic-auth/basic-alfresco-auth.service.ts
+++ b/lib/core/src/lib/auth/basic-auth/basic-alfresco-auth.service.ts
@@ -121,12 +121,14 @@ export class BasicAlfrescoAuthService extends BaseAuthenticationService {
             try {
                 return await this.processAuth.login(username, password);
             } catch (e) {
+                return Promise.reject(e);
             }
 
         } else if (this.isECMProvider()) {
             try {
                 return await this.contentAuth.login(username, password);
             } catch (e) {
+                return Promise.reject(e);
             }
 
         } else if (this.isALLProvider()) {
diff --git a/lib/core/src/lib/auth/services/authentication.service.spec.ts b/lib/core/src/lib/auth/services/authentication.service.spec.ts
index 975ef9f0fd..4e09f0fe65 100644
--- a/lib/core/src/lib/auth/services/authentication.service.spec.ts
+++ b/lib/core/src/lib/auth/services/authentication.service.spec.ts
@@ -261,7 +261,7 @@ describe('AuthenticationService', () => {
                 },
                 (err: any) => {
                     expect(err).toBeDefined();
-                    expect(authService.getToken()).toBe(undefined);
+                    expect(authService.getToken()).toBe(null);
                     done();
                 });
 
@@ -374,9 +374,9 @@ describe('AuthenticationService', () => {
         it('[ALL] should return both ECM and BPM tickets after the login done', (done) => {
             const disposableLogin = basicAlfrescoAuthService.login('fake-username', 'fake-password').subscribe(() => {
                 expect(authService.isLoggedIn()).toBe(true);
-                expect(authService.getToken()).toEqual('fake-post-ticket');
+                expect(basicAlfrescoAuthService.getTicketEcm()).toEqual('fake-post-ticket');
                 // cspell: disable-next
-                expect(authService.getToken()).toEqual('Basic ZmFrZS11c2VybmFtZTpmYWtlLXBhc3N3b3Jk');
+                expect(basicAlfrescoAuthService.getTicketBpm()).toEqual('Basic ZmFrZS11c2VybmFtZTpmYWtlLXBhc3N3b3Jk');
                 expect(authService.isBpmLoggedIn()).toBe(true);
                 expect(authService.isEcmLoggedIn()).toBe(true);
                 disposableLogin.unsubscribe();