inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-10592] Remove 'secret' field from OAUTH config across ADF/ACA/ADW (#11332)

Browse Source
This commit is contained in:
dominikiwanekhyland
2025-11-14 08:31:31 +01:00
committed by GitHub
parent b7d687f3d2
commit d298d92214
13 changed files with 7 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/core/src/lib/app-config/app.config.schema.json
-3
View File
@@ -1535,9 +1535,6 @@
"type": "string",
"description": "The client's id as registered with the auth server"
},
"secret": {
"type": "string"
},
"redirectUri": {
"type": "string",
"description": "The client's redirectUri as registered with the auth server"
lib/core/src/lib/auth/models/oauth-config.model.ts
-1
View File
@@ -23,7 +23,6 @@ export interface OauthConfigModel {
codeFlow?: boolean;
redirectUri: string;
silentLogin?: boolean;
secret?: string;
redirectUriLogout?: string;
logoutUrl?: string;
audience?: string;
lib/core/src/lib/auth/oidc/auth-config.service.spec.ts
+2 -8
View File
@@ -31,7 +31,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: true,
silentLogin: true,
redirectSilentIframeUri: 'http://localhost:3000/assets/silent-refresh.html',
@@ -44,7 +43,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: true,
silentLogin: true,
redirectSilentIframeUri: 'http://localhost:3000/subfolder/assets/silent-refresh.html',
@@ -57,7 +55,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: true,
silentLogin: true,
redirectSilentIframeUri: 'http://localhost:3000/subfolder2/assets/silent-refresh.html',
@@ -70,7 +67,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: true,
silentLogin: true,
redirectSilentIframeUri: 'http://localhost:3000/assets/silent-refresh.html',
@@ -83,7 +79,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: false,
codeFlow: true,
silentLogin: true,
@@ -116,7 +111,7 @@ describe('AuthConfigService', () => {
postLogoutRedirectUri: 'http://localhost:3000/#/logout',
clientId: 'fakeClientId',
scope: 'openid profile email',
dummyClientSecret: ''
dummyClientSecret: 'dummyClientSecret'
};
expect(await service.loadConfig()).toEqual(jasmine.objectContaining(expectedConfig));
@@ -133,7 +128,7 @@ describe('AuthConfigService', () => {
clientId: 'fakeClientId',
scope: 'openid profile email',
responseType: 'code',
dummyClientSecret: ''
dummyClientSecret: 'dummyClientSecret'
};
expect(await service.loadConfig()).toEqual(jasmine.objectContaining(expectedConfig));
@@ -180,7 +175,6 @@ describe('AuthConfigService', () => {
host: 'http://localhost:3000/auth/realms/alfresco',
clientId: 'fakeClientId',
scope: 'openid profile email',
secret: '',
implicitFlow: true,
silentLogin: true,
redirectSilentIframeUri: 'http://localhost:3000/assets/silent-refresh.html',
lib/core/src/lib/auth/oidc/auth-config.service.ts
+1 -1
View File
@@ -69,7 +69,7 @@ export class AuthConfigService {
postLogoutRedirectUri: this.generatePostLogoutUri(origin, oauth2.redirectUriLogout),
clientId: oauth2.clientId,
scope: oauth2.scope,
dummyClientSecret: oauth2.secret || '',
dummyClientSecret: 'dummyClientSecret',
logoutUrl: oauth2.logoutUrl,
customQueryParams,
...(oauth2.codeFlow && { responseType: 'code' }),