inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-49653 Code improvement

Browse Source
This commit is contained in:
Ehsan Rezaei
2026-08-25 13:32:58 +02:00
parent 3e2ccd8d3c
commit d3d5e5d80c
2 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/process-services-cloud/src/lib/process/process-filters/components/process-filters/process-filters-cloud.component.ts
+2 -2
View File
@@ -16,7 +16,7 @@
*/ */
import { Component, DestroyRef, EventEmitter, inject, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core'; import { Component, DestroyRef, EventEmitter, inject, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';
import { combineLatest, defer, EMPTY, Observable, Subscription } from 'rxjs'; import { combineLatest, defer, EMPTY, Observable, of, Subscription } from 'rxjs';
import { ProcessFilterCloudService } from '../../services/process-filter-cloud.service'; import { ProcessFilterCloudService } from '../../services/process-filter-cloud.service';
import { ProcessFilterCloudModel } from '../../models/process-filter-cloud.model'; import { ProcessFilterCloudModel } from '../../models/process-filter-cloud.model';
import { AppConfigService, IconModule, TranslationService } from '@alfresco/adf-core'; import { AppConfigService, IconModule, TranslationService } from '@alfresco/adf-core';
@@ -131,7 +131,7 @@ export class ProcessFiltersCloudComponent implements OnInit, OnChanges {
getFilters(appName: string): void { getFilters(appName: string): void {
this.filtersLoadedFor = appName; this.filtersLoadedFor = appName;
const filters$ = this.filterCountersCloudService.getProcessFilters(appName); const filters$ = this.filterCountersCloudService.getProcessFilters(appName);
this.filters$ = filters$.pipe(catchError(() => EMPTY)); this.filters$ = filters$.pipe(catchError(() => of([])));
filters$.pipe(takeUntilDestroyed(this.destroyRef)).subscribe({ filters$.pipe(takeUntilDestroyed(this.destroyRef)).subscribe({
next: (res) => { next: (res) => {
lib/process-services-cloud/src/lib/task/task-filters/components/task-filters/task-filters-cloud.component.ts
+5 -9
View File
@@ -176,15 +176,8 @@ export class TaskFiltersCloudComponent extends BaseTaskFiltersCloudComponent imp
}); });
} }
initFilterCounterNotifications() { initFilterCounterNotifications(): void {
if (!this.appName) { if (this.appName && this.enableNotifications) {
return;
}
if (!this.enableNotifications) {
this.counters = {};
return;
}
this.filterCountersCloudService this.filterCountersCloudService
.getEngineEvents(this.appName, FilterCounterEntityType.TASK) .getEngineEvents(this.appName, FilterCounterEntityType.TASK)
.pipe(takeUntilDestroyed(this.destroyRef)) .pipe(takeUntilDestroyed(this.destroyRef))
@@ -192,6 +185,9 @@ export class TaskFiltersCloudComponent extends BaseTaskFiltersCloudComponent imp
events.forEach((taskEvent) => this.checkFilterCounter(taskEvent.entity)); events.forEach((taskEvent) => this.checkFilterCounter(taskEvent.entity));
this.filterCounterUpdated.emit(events); this.filterCounterUpdated.emit(events);
}); });
} else {
this.counters = {};
}
} }
checkFilterCounter(filterNotification: TaskDetailsCloudModel) { checkFilterCounter(filterNotification: TaskDetailsCloudModel) {