inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-3930] fix infinite pagination (#4275)

Browse Source 
* refactoring infinite pagination

* fix lint

* fix import reuqest pagination from core

* fix failing unit test
This commit is contained in:
Eugenio Romano
2019-02-06 14:40:38 +00:00
committed by GitHub
parent 3a9958988a
commit d6b8e85c35
20 changed files with 198 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
lib/core/pagination/infinite-pagination.component.spec.ts
View File

@@ -111,6 +111,36 @@ describe('InfinitePaginationComponent', () => {
expect(loadMoreButton).not.toBeNull();
});
it('should NOT show the load more button if there are no more elements to load', (done) => {
pagination = { maxItems: 444, skipCount: 25, totalItems: 30, hasMoreItems: false };
component.target.pagination.next(pagination);
fixture.detectChanges();
component.onLoadMore();
fixture.whenStable().then(() => {
let loadMoreButton = fixture.debugElement.query(By.css('[data-automation-id="adf-infinite-pagination-button"]'));
expect(loadMoreButton).toBeNull();
done();
});
});
it('should show the load more button if there are more elements to load', (done) => {
pagination = { maxItems: 444, skipCount: 25, totalItems: 55, hasMoreItems: true };
component.target.pagination.next(pagination);
fixture.detectChanges();
fixture.whenStable().then(() => {
let loadMoreButton = fixture.debugElement.query(By.css('[data-automation-id="adf-infinite-pagination-button"]'));
expect(loadMoreButton).not.toBeNull();
done();
});
});
it('should NOT show anything if pagination has NO more items', () => {
pagination.hasMoreItems = false;
component.target.updatePagination(pagination);
@@ -123,15 +153,16 @@ describe('InfinitePaginationComponent', () => {
});
it('should trigger the loadMore event with the proper pagination object', (done) => {
pagination.hasMoreItems = true;
pagination.skipCount = 5;
component.target.updatePagination(pagination);
pagination = { maxItems: 444, skipCount: 25, totalItems: 55, hasMoreItems: true };
component.target.pagination.next(pagination);
component.isLoading = false;
component.pageSize = 5;
fixture.detectChanges();
component.loadMore.subscribe((newPagination: Pagination) => {
expect(newPagination.skipCount).toBe(10);
expect(newPagination.skipCount).toBe(5);
done();
});
@@ -166,10 +197,9 @@ describe('InfinitePaginationComponent', () => {
component.onLoadMore();
expect(spyTarget).toHaveBeenCalledWith({
maxItems: 444,
skipCount: 25,
totalItems: 888,
hasMoreItems: true,
maxItems: 25,
hasMoreItems: false,
merge: true
});
});
@@ -182,10 +212,9 @@ describe('InfinitePaginationComponent', () => {
component.onLoadMore();
expect(spyTarget).toHaveBeenCalledWith({
maxItems: 444,
maxItems: 7,
skipCount: 7,
totalItems: 888,
hasMoreItems: true,
hasMoreItems: false,
merge: true
});
});