inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-26 17:24:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-2175] Document List requests are executed twice when opening the copy and move dialog (#2960)

Browse Source 
* [ADF-2175] Document List requests are executed twice when opening the dialog

fixed bug

* [ADF-2175] added unit tests for the change & refactored initial code
This commit is contained in:
suzanadirla 2018-02-20 15:59:12 +02:00 committed by Eugenio Romano
parent adb0b8df38
commit d731cc651c
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/content-services/document-list/components/document-list.component.spec.ts
View File

@ -1204,4 +1204,22 @@ describe('DocumentList', () => {
expect(documentList.reload).not.toHaveBeenCalled(); expect(documentList.reload).not.toHaveBeenCalled();
}); });
it('should NOT reload data on first call of onNgChanges', () => {
spyOn(documentList, 'reload').and.stub();
const firstChange = true;
documentList.ngOnChanges({ skipCount: new SimpleChange(undefined, 10, firstChange) });
expect(documentList.reload).not.toHaveBeenCalled();
});
it('should reload data on NON-first calls of onNgChanges', () => {
spyOn(documentList, 'reload').and.stub();
const firstChange = true;
documentList.ngOnChanges({ skipCount: new SimpleChange(undefined, 10, !firstChange) });
expect(documentList.reload).toHaveBeenCalled();
});
}); });

2
lib/content-services/document-list/components/document-list.component.ts
View File

@ -567,6 +567,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
private isSkipCountChanged(changePage: SimpleChanges) { private isSkipCountChanged(changePage: SimpleChanges) {
return changePage.skipCount && return changePage.skipCount &&
!changePage.skipCount.isFirstChange() &&
changePage.skipCount.currentValue !== null && changePage.skipCount.currentValue !== null &&
changePage.skipCount.currentValue !== undefined && changePage.skipCount.currentValue !== undefined &&
changePage.skipCount.currentValue !== changePage.skipCount.previousValue; changePage.skipCount.currentValue !== changePage.skipCount.previousValue;
@ -574,6 +575,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
private isMaxItemsChanged(changePage: SimpleChanges) { private isMaxItemsChanged(changePage: SimpleChanges) {
return changePage.maxItems && return changePage.maxItems &&
!changePage.maxItems.isFirstChange() &&
changePage.maxItems.currentValue && changePage.maxItems.currentValue &&
changePage.maxItems.currentValue !== changePage.maxItems.previousValue; changePage.maxItems.currentValue !== changePage.maxItems.previousValue;
} }