[AAE-622] No implicit returns (#5157)

* enable noImplicitReturns rule

* type fixes

* fix return types

* fix return value

* fix tests

* fix visibility service

* update tests

* add missing types

* fix test

lib/core/mock/form/demo-form.mock.ts

@@ -17,7 +17,7 @@
 
 export class DemoForm {
 
-    easyForm = {
+    easyForm: any = {
         'id': 1001,
         'name': 'ISSUE_FORM',
         'tabs': [],
@@ -365,7 +365,7 @@ export class DemoForm {
         'globalDateFormat': 'D-M-YYYY'
     };
 
-    formDefinition = {
+    formDefinition: any = {
         'id': 3003,
         'name': 'demo-01',
         'taskId': '7501',
@@ -1482,7 +1482,7 @@ export class DemoForm {
         'globalDateFormat': 'D-M-YYYY'
     };
 
-    simpleFormDefinition = {
+    simpleFormDefinition: any = {
         'id': 1001,
         'name': 'SIMPLE_FORM_EXAMPLE',
         'description': '',
@@ -1765,7 +1765,7 @@ export class DemoForm {
         }
     };
 
-    cloudFormDefinition = {
+    cloudFormDefinition: any = {
         'formRepresentation': {
             'id': 'text-form',
             'name': 'test-start-form',

lib/core/mock/form/form.component.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let fakeForm = {
+export const fakeForm: any = {
     id: 1001,
     name: 'ISSUE_FORM',
     processDefinitionId: 'ISSUE_APP:1:2504',

lib/core/mock/form/form.service.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let formModelTabs = {
+export const formModelTabs: any = {
     id: 16,
     name: 'start event',
     description: '',

lib/core/mock/form/formDefinition.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let formDefinitionTwoTextFields = {
+export const formDefinitionTwoTextFields: any = {
     id: 20,
     name: 'formTextDefinition',
     processDefinitionId: 'textDefinition:1:153',
@@ -160,7 +160,7 @@ export let formDefinitionTwoTextFields = {
     globalDateFormat: 'D-M-YYYY'
 };
 
-export let formDefinitionDropdownField = {
+export const formDefinitionDropdownField: any = {
     id: 21,
     name: 'dropdownDefinition',
     processDefinitionId: 'textDefinition:2:163',
@@ -282,7 +282,7 @@ export let formDefinitionDropdownField = {
     globalDateFormat: 'D-M-YYYY'
 };
 
-export let formDefinitionRequiredField = {
+export const formDefinitionRequiredField: any = {
     id: 21,
     name: 'dropdownDefinition',
     processDefinitionId: 'textDefinition:2:163',

lib/core/mock/form/formDefinitionReadonly.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let formReadonlyTwoTextFields = {
+export const formReadonlyTwoTextFields: any = {
     id: 22,
     name: 'formTextDefinition',
     processDefinitionId: 'textDefinition:3:182',

lib/core/mock/form/formDefinitionVisibility.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let formDefVisibilitiFieldDependsOnNextOne = {
+export const formDefVisibilitiFieldDependsOnNextOne: any = {
     id: 19,
     processDefinitionId: 'visibility:1:148',
     processDefinitionName: 'visibility',
@@ -181,7 +181,7 @@ export let formDefVisibilitiFieldDependsOnNextOne = {
     globalDateFormat: 'D-M-YYYY'
 };
 
-export let formDefVisibilitiFieldDependsOnPreviousOne = {
+export const formDefVisibilitiFieldDependsOnPreviousOne: any = {
     id: 19,
     processDefinitionId: 'visibility:1:148',
     processDefinitionName: 'visibility',

lib/core/mock/form/start-form.component.mock.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-export let startFormDateWidgetMock = {
+export const startFormDateWidgetMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -38,7 +38,7 @@ export let startFormDateWidgetMock = {
         }]
 };
 
-export let startFormNumberWidgetMock = {
+export const startFormNumberWidgetMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -61,7 +61,7 @@ export let startFormNumberWidgetMock = {
         }]
 };
 
-export let startFormAmountWidgetMock = {
+export const startFormAmountWidgetMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -84,7 +84,7 @@ export let startFormAmountWidgetMock = {
         }]
 };
 
-export let startFormRadioButtonWidgetMock = {
+export const startFormRadioButtonWidgetMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -107,7 +107,7 @@ export let startFormRadioButtonWidgetMock = {
         }]
 };
 
-export let startFormTextDefinitionMock = {
+export const startFormTextDefinitionMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -130,7 +130,7 @@ export let startFormTextDefinitionMock = {
         }]
 };
 
-export let startFormDropdownDefinitionMock = {
+export const startFormDropdownDefinitionMock: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -179,7 +179,7 @@ export let startFormDropdownDefinitionMock = {
         }]
 };
 
-export let startMockForm = {
+export const startMockForm: any = {
     id: 4,
     name: 'Claim Review Process',
     processDefinitionId: 'ClaimReviewProcess:2: 93',
@@ -593,7 +593,7 @@ export let startMockForm = {
     globalDateFormat: 'D - M - YYYY'
 };
 
-export let startMockFormWithTab = {
+export const startMockFormWithTab: any = {
     id: 4,
     taskName: 'Mock Title',
     processDefinitionId: 'ClaimReviewProcess:2: 93',

lib/core/mock/form/widget-visibility-cloud.service.mock.ts

@@ -19,13 +19,13 @@ import { FormModel, FormValues } from '../../form/components/widgets/core/index'
 
 export let formTest = new FormModel({});
 
-export let fakeTaskProcessVariableModels = [
+export const fakeTaskProcessVariableModels = [
     { id: 'TEST_VAR_1', type: 'string', value: 'test_value_1' },
     { id: 'TEST_VAR_2', type: 'string', value: 'test_value_2' },
     { id: 'TEST_VAR_3', type: 'string', value: 'test_value_3' }
 ];
 
-export let formValues: FormValues = {
+export const formValues: FormValues = {
     'test_1': 'value_1',
     'test_2': 'value_2',
     'test_3': 'value_1',
@@ -34,7 +34,7 @@ export let formValues: FormValues = {
     'dropdown': { 'id': 'dropdown_id', 'name': 'dropdown_label' }
 };
 
-export let fakeFormJson = {
+export const fakeFormJson: any = {
     id: '9999',
     name: 'FORM_VISIBILITY',
     processDefinitionId: 'PROCESS_TEST:9:9999',
@@ -116,7 +116,7 @@ export let fakeFormJson = {
     ]
 };
 
-export let complexVisibilityJsonVisible = {
+export const complexVisibilityJsonVisible: any = {
     'id': 47591,
     'name': 'Test-visibility',
     'description': '',
@@ -481,7 +481,7 @@ export let complexVisibilityJsonVisible = {
         'gridsterForm': false
     }
 };
-export let complexVisibilityJsonNotVisible = {
+export const complexVisibilityJsonNotVisible: any = {
     'id': 47591,
     'name': 'Test-visibility',
     'description': '',
@@ -847,7 +847,7 @@ export let complexVisibilityJsonNotVisible = {
     }
 };
 
-export let nextConditionForm = {
+export const nextConditionForm: any = {
     id: '9999',
     name: 'FORM_PROCESS_VARIABLE_VISIBILITY',
     processDefinitionId: 'PROCESS_TEST:9:9999',
@@ -955,7 +955,7 @@ export let nextConditionForm = {
     ]
 };
 
-export let headerVisibilityCond = {
+export const headerVisibilityCond: any = {
     'id': 'form-f0823c05-51eb-4703-8634-75a6d5e15df5',
     'name': 'text_form',
     'description': '',

lib/core/mock/form/widget-visibility.service.mock.ts

@@ -19,13 +19,13 @@ import { FormModel, FormValues } from '../../form/components/widgets/core/index'
 
 export let formTest = new FormModel({});
 
-export let fakeTaskProcessVariableModels = [
+export const fakeTaskProcessVariableModels = [
     { id:   'TEST_VAR_1', type:   'string', value:   'test_value_1' },
     { id:   'TEST_VAR_2', type:   'string', value:   'test_value_2' },
     { id:   'TEST_VAR_3', type:   'string', value:   'test_value_3' }
 ];
 
-export let formValues:   FormValues = {
+export const formValues: FormValues = {
     'test_1':   'value_1',
     'test_2':   'value_2',
     'test_3':   'value_1',
@@ -34,7 +34,7 @@ export let formValues:   FormValues = {
     'dropdown':   { 'id':   'dropdown_id', 'name':   'dropdown_label' }
 };
 
-export let fakeFormJson = {
+export const fakeFormJson: any = {
     id:   '9999',
     name:   'FORM_VISIBILITY',
     processDefinitionId:   'PROCESS_TEST:  9:  9999',
@@ -116,7 +116,7 @@ export let fakeFormJson = {
     ]
 };
 
-export let complexVisibilityJsonVisible = {
+export const complexVisibilityJsonVisible: any = {
     'id':   47591,
     'name':   'Test-visibility',
     'description':   '',
@@ -489,7 +489,8 @@ export let complexVisibilityJsonVisible = {
         'gridsterForm':   false
     }
 };
-export let complexVisibilityJsonNotVisible = {
+
+export const complexVisibilityJsonNotVisible: any = {
     'id':   47591,
     'name':   'Test-visibility',
     'description':   '',
@@ -859,7 +860,7 @@ export let complexVisibilityJsonNotVisible = {
     }
 };
 
-export let tabVisibilityJsonMock = {
+export const tabVisibilityJsonMock: any = {
     'id': 45231,
     'name': 'visibility-form',
     'description': '',
@@ -1000,7 +1001,7 @@ export let tabVisibilityJsonMock = {
     }
  };
 
-export const tabInvalidFormVisibility = {
+export const tabInvalidFormVisibility: any = {
     'id': 'form-0668939d-34b2-440c-ab4d-01ab8b05a881',
     'name': 'tab-visibility',
     'description': '',