[AAE-622] No implicit returns (#5157)

* enable noImplicitReturns rule

* type fixes

* fix return types

* fix return value

* fix tests

* fix visibility service

* update tests

* add missing types

* fix test
This commit is contained in:
Denys Vuika
2019-10-17 09:35:39 +01:00
committed by GitHub
parent 48aca2d30f
commit d7ab0417b8
65 changed files with 366 additions and 319 deletions

View File

@@ -225,10 +225,11 @@ export class TaskHeaderComponent implements OnChanges, OnInit {
/**
* Return the process parent information
*/
getParentInfo() {
getParentInfo(): Map<string, string> {
if (this.taskDetails.processInstanceId && this.taskDetails.processDefinitionName) {
return new Map([[this.taskDetails.processInstanceId, this.taskDetails.processDefinitionName]]);
}
return new Map();
}
/**
@@ -241,7 +242,7 @@ export class TaskHeaderComponent implements OnChanges, OnInit {
/**
* Returns true if the task is assigned to logged in user
*/
public isAssignedTo(userId): boolean {
public isAssignedTo(userId: number): boolean {
return this.hasAssignee() ? this.taskDetails.assignee.id === userId : false;
}
@@ -255,7 +256,7 @@ export class TaskHeaderComponent implements OnChanges, OnInit {
/**
* Return true if the user is a candidate member
*/
isCandidateMember() {
isCandidateMember(): boolean {
return this.taskDetails.managerOfCandidateGroup || this.taskDetails.memberOfCandidateGroup || this.taskDetails.memberOfCandidateUsers;
}