inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACTIVITI-3746] - fix form completion with tab fields (#5059)

Browse Source 
* [ACTIVITI-3746] - fix form completion with tab fields

* fix lint

* fix unit test

* refractoring and PR changes

* fix unit tests
This commit is contained in:
Silviu Popa
2019-09-16 12:57:46 +03:00
committed by Popovics András
parent ae56d61ea3
commit d89b61cff0
4 changed files with 185 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/core/form/services/widget-visibility.service.spec.ts
View File

@@ -34,7 +34,8 @@ import { AlfrescoApiServiceMock } from '../../mock/alfresco-api.service.mock';
import { fakeTaskProcessVariableModels,
fakeFormJson, formTest,
formValues, complexVisibilityJsonVisible,
complexVisibilityJsonNotVisible, tabVisibilityJsonMock } from 'core/mock/form/widget-visibility.service.mock';
complexVisibilityJsonNotVisible, tabVisibilityJsonMock,
tabInvalidFormVisibility } from 'core/mock/form/widget-visibility.service.mock';
declare let jasmine: any;
@@ -932,10 +933,12 @@ describe('WidgetVisibilityService', () => {
const fakeTabVisibilityModel = new FormModel(tabVisibilityJsonMock);
const complexVisibilityModel = new FormModel(complexVisibilityJsonVisible);
const complexVisibilityJsonNotVisibleModel = new FormModel(complexVisibilityJsonNotVisible);
let invalidTabVisibilityJsonModel: FormModel;
let visibilityObjTest: WidgetVisibilityModel;
beforeEach(() => {
visibilityObjTest = new WidgetVisibilityModel();
invalidTabVisibilityJsonModel = new FormModel(tabInvalidFormVisibility);
fakeFormWithVariables = new FormModel(fakeFormJson);
});
@@ -1028,5 +1031,18 @@ describe('WidgetVisibilityService', () => {
expect(fakeTabVisibilityModel.tabs[1].isVisible).toBeTruthy();
});
it('form should be valid when a tab with invalid values is not visibile', () => {
invalidTabVisibilityJsonModel.getFieldById('Number1').value = 'invalidField';
invalidTabVisibilityJsonModel.getFieldById('Text1').value = 'showtab';
service.refreshVisibility(invalidTabVisibilityJsonModel);
invalidTabVisibilityJsonModel.validateForm();
expect(invalidTabVisibilityJsonModel.isValid).toBeFalsy();
invalidTabVisibilityJsonModel.getFieldById('Text1').value = 'hidetab';
service.refreshVisibility(invalidTabVisibilityJsonModel);
invalidTabVisibilityJsonModel.validateForm();
expect(invalidTabVisibilityJsonModel.isValid).toBeTruthy();
});
});
});