inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean unit test in login component and site (#4908)

Browse Source 
* sanatize login style

* remove unusefull test in site api
This commit is contained in:
Eugenio Romano
2019-07-08 16:54:34 +01:00
committed by GitHub
parent abc376ff33
commit d9a251a0c8
3 changed files with 8 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/login/components/login.component.html
View File

@@ -1,4 +1,4 @@
<div class="adf-login-content" [style.background-image]="'url(' + backgroundImageUrl + ')'"> <div class="adf-login-content" [style.background-image]="getBackgroundUrlImageUrl()">
<div class="adf-ie11FixerParent"> <div class="adf-ie11FixerParent">
<div class="adf-ie11FixerChild"> <div class="adf-ie11FixerChild">

8
lib/core/login/components/login.component.ts
View File

@@ -35,6 +35,7 @@ import {
AppConfigValues AppConfigValues
} from '../../app-config/app-config.service'; } from '../../app-config/app-config.service';
import { OauthConfigModel } from '../../models/oauth-config.model'; import { OauthConfigModel } from '../../models/oauth-config.model';
import { DomSanitizer } from '@angular/platform-browser';
enum LoginSteps { enum LoginSteps {
Landing = 0, Landing = 0,
@@ -142,7 +143,8 @@ export class LoginComponent implements OnInit {
private appConfig: AppConfigService, private appConfig: AppConfigService,
private userPreferences: UserPreferencesService, private userPreferences: UserPreferencesService,
private location: Location, private location: Location,
private route: ActivatedRoute private route: ActivatedRoute,
private sanitizer: DomSanitizer
) { ) {
this.initFormError(); this.initFormError();
this.initFormFieldsMessages(); this.initFormFieldsMessages();
@@ -349,6 +351,10 @@ export class LoginComponent implements OnInit {
event.target.value = event.target.value.trim(); event.target.value = event.target.value.trim();
} }
getBackgroundUrlImageUrl() {
return this.sanitizer.bypassSecurityTrustStyle(`url(${this.backgroundImageUrl})`);
}
/** /**
* Default formError values * Default formError values
*/ */

34
lib/core/services/sites.service.spec.ts
View File

@@ -106,38 +106,4 @@ describe('Sites service', () => {
}); });
}); });
it('deleteSite should perform a call against the server', (done) => {
service.deleteSite('fake-site-id').subscribe(() => {
expect(jasmine.Ajax.requests.mostRecent().method).toBe('DELETE');
expect(jasmine.Ajax.requests.mostRecent().url)
.toContain('alfresco/api/-default-/public/alfresco/versions/1/sites/fake-site-id');
done();
});
jasmine.Ajax.requests.mostRecent().respondWith({
status: 204
});
});
it('getSites catch errors call', (done) => {
service.getSites().subscribe(() => {
}, () => {
done();
});
jasmine.Ajax.requests.mostRecent().respondWith({
status: 403
});
});
it('getSite catch errors call', (done) => {
service.getSite('error-id').subscribe(() => {
}, () => {
done();
});
jasmine.Ajax.requests.mostRecent().respondWith({
status: 403
});
});
}); });