[ACS-5416] remove internal notification icon pipe (#8659)

lib/core/src/lib/notifications/components/notification-history.component.html

@@ -43,8 +43,7 @@
                         </div>
                         <ng-template #no_avatar>
                             <mat-icon mat-list-icon
-                                      class="adf-notification-history-menu-initiator">{{ notification | notificationIcon
+                                      class="adf-notification-history-menu-initiator">{{notification.icon}}</mat-icon>
-                                }}</mat-icon>
                         </ng-template>
                         <p class="adf-notification-history-menu-message"
                            *ngFor="let message of notification.messages"

lib/core/src/lib/notifications/components/notification-history.component.ts

@@ -52,7 +52,7 @@ export class NotificationHistoryComponent implements OnDestroy, OnInit, AfterVie
 
     onDestroy$ = new Subject<boolean>();
     notifications: NotificationModel[] = [];
-    paginatedNotifications = [];
+    paginatedNotifications: NotificationModel[] = [];
     pagination: PaginationModel;
 
     constructor(

lib/core/src/lib/notifications/helpers/notification.factory.ts

@@ -28,6 +28,7 @@ export const rootInitiator: NotificationInitiator  = {
 
 export const info = (messages: string | string[], initiator: NotificationInitiator = rootInitiator): NotificationModel => ({
     type: NOTIFICATION_TYPE.INFO,
+    icon: 'info',
     datetime: new Date(),
     initiator,
     messages: [].concat(messages)
@@ -35,6 +36,7 @@ export const info = (messages: string | string[], initiator: NotificationInitiat
 
 export const warning = (messages: string | string[], initiator: NotificationInitiator = rootInitiator): NotificationModel => ({
     type: NOTIFICATION_TYPE.WARN,
+    icon: 'warning',
     datetime: new Date(),
     initiator,
     messages: [].concat(messages)
@@ -42,6 +44,7 @@ export const warning = (messages: string | string[], initiator: NotificationInit
 
 export const error = (messages: string | string[], initiator: NotificationInitiator = rootInitiator): NotificationModel => ({
     type: NOTIFICATION_TYPE.ERROR,
+    icon: 'error',
     datetime: new Date(),
     initiator,
     messages: [].concat(messages)

lib/core/src/lib/notifications/notification-history.module.ts

@@ -21,7 +21,6 @@ import { MaterialModule } from '../material.module';
 import { PipeModule } from '../pipes/pipe.module';
 import { NotificationHistoryComponent } from './components/notification-history.component';
 import { TranslateModule } from '@ngx-translate/core';
-import { NotificationIconPipe } from './pipes/notification-icon.pipe';
 import { PaginationModule } from '../pagination/pagination.module';
 import { AddNotificationStorybookComponent } from './components/add-notification.stories.component';
 
@@ -35,8 +34,7 @@ import { AddNotificationStorybookComponent } from './components/add-notification
     ],
     declarations: [
         NotificationHistoryComponent,
-        AddNotificationStorybookComponent,
+        AddNotificationStorybookComponent
-        NotificationIconPipe
     ],
     exports: [
         NotificationHistoryComponent,

lib/core/src/lib/notifications/pipes/notification-icon.pipe.ts

@@ -1,40 +0,0 @@
-/*!
- * @license
- * Copyright © 2005-2023 Hyland Software, Inc. and its affiliates. All rights reserved.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { Pipe, PipeTransform } from '@angular/core';
-import { NotificationModel, NOTIFICATION_TYPE } from '../models/notification.model';
-
-@Pipe({
-    name: 'notificationIcon'
-})
-export class NotificationIconPipe implements PipeTransform {
-
-    transform(notification: NotificationModel): string {
-        if (notification.icon) {
-            return notification.icon;
-        } else {
-            switch (notification.type) {
-                case NOTIFICATION_TYPE.ERROR:
-                    return 'error';
-                case NOTIFICATION_TYPE.WARN:
-                    return 'warning';
-                default:
-                    return 'info';
-            }
-        }
-    }
-}