inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-12245: Migrated from event cancelBubble to stopPropagation (#8311)

Browse Source
This commit is contained in:
Ehsan Rezaei
2023-03-06 21:57:51 +01:00
committed by GitHub
parent cb69f34aa7
commit dd91f2eeb6
8 changed files with 70 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/process-services-cloud/src/lib/form/components/form-cloud.component.spec.ts
View File

@@ -1306,10 +1306,12 @@ describe('retrieve metadata on submit', () => {
expect(formContentClicked).toHaveBeenCalledWith(contentLinkModel);
});
it('should cancel bubbling a keydown event', () => {
const escapeKeyboardEvent = new KeyboardEvent('keydown', { keyCode: ESCAPE } as any);
it('should stop propagation on keydown event', () => {
const escapeKeyboardEvent = new KeyboardEvent('keydown', { key: ESCAPE.toString() });
const stopPropagationSpy = spyOn(escapeKeyboardEvent, 'stopPropagation');
fixture.debugElement.triggerEventHandler('keydown', escapeKeyboardEvent);
expect(escapeKeyboardEvent.cancelBubble).toBe(true);
expect(stopPropagationSpy).toHaveBeenCalled();
});
});

4
lib/process-services-cloud/src/lib/form/components/form-cloud.component.ts
View File

@@ -133,8 +133,8 @@ export class FormCloudComponent extends FormBaseComponent implements OnChanges,
}
@HostListener('keydown', ['$event'])
onKeyDown(event: KeyboardEvent) {
event.cancelBubble = true;
onKeyDown(event: KeyboardEvent): void {
event.stopPropagation();
}
ngOnChanges(changes: SimpleChanges) {

8
lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts
View File

@@ -929,11 +929,13 @@ describe('StartProcessCloudComponent', () => {
component.ngOnChanges({ appName: change });
});
it('should cancel bubbling a keydown event ()', () => {
const escapeKeyboardEvent = new KeyboardEvent('keydown', { keyCode: ESCAPE } as any);
it('should stop propagation on keydown event', () => {
const escapeKeyboardEvent = new KeyboardEvent('keydown', { key: ESCAPE.toString() });
const stopPropagationSpy = spyOn(escapeKeyboardEvent, 'stopPropagation');
fixture.debugElement.triggerEventHandler('keydown', escapeKeyboardEvent);
expect(escapeKeyboardEvent.cancelBubble).toBe(true);
expect(stopPropagationSpy).toHaveBeenCalled();
});
it('should hide title', () => {

4
lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts
View File

@@ -147,8 +147,8 @@ export class StartProcessCloudComponent implements OnChanges, OnInit, OnDestroy
}
@HostListener('keydown', ['$event'])
onKeyDown(event: KeyboardEvent) {
event.cancelBubble = true;
onKeyDown(event: KeyboardEvent): void {
event.stopPropagation();
}
hasForm(): boolean {