inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-3684] not autoselect first process in start process when multi process are present in an app

Browse Source 
fix failing unit test
This commit is contained in:
Eugenio Romano
2018-10-22 17:39:58 +01:00
parent 7f448d78d1
commit ddbb5b3d65
3 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/process-services/process-list/components/start-process.component.spec.ts
View File

@@ -284,6 +284,16 @@ describe('StartFormComponent', () => {
});
}));
it('should not select automatically any processDefinition if the app contain multiple process and does not have any processDefinition as input', async(() => {
getDefinitionsSpy = getDefinitionsSpy.and.returnValue(of(testMultipleProcessDefs));
component.appId = 123;
component.ngOnChanges({});
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(component.selectedProcessDef.name).toBeNull();
});
}));
describe('dropdown', () => {
it('should hide the process dropdown button if showSelectProcessDropdown is false', async(() => {

17
lib/process-services/process-list/components/start-process.component.ts
View File

@@ -135,13 +135,15 @@ export class StartProcessInstanceComponent implements OnChanges, OnInit {
}
private _filter(value: string): ProcessDefinitionRepresentation[] {
const filterValue = value.toLowerCase();
let filteredProcess = this.processDefinitions.filter(option => option.name.toLowerCase().includes(filterValue));
if (value !== null && value !== undefined) {
const filterValue = value.toLowerCase();
let filteredProcess = this.processDefinitions.filter(option => option.name.toLowerCase().includes(filterValue));
if (this.processFilterSelector) {
this.selectedProcessDef = this.getSelectedProcess(filterValue);
if (this.processFilterSelector) {
this.selectedProcessDef = this.getSelectedProcess(filterValue);
}
return filteredProcess;
}
return filteredProcess;
}
getSelectedProcess(selectedProcess) {
@@ -162,7 +164,10 @@ export class StartProcessInstanceComponent implements OnChanges, OnInit {
this.processDefinitions = processDefinitionRepresentations;
if (!this.isProcessDefinitionsEmpty()) {
this.selectedProcessDef = this.processDefinitions[0];
if (this.processDefinitions.length == 1) {
this.selectedProcessDef = this.processDefinitions[0];
}
if (this.processDefinitionName) {
let selectedProcess = this.processDefinitions.find((currentProcessDefinition) => {