[ACS-4050]critical issues from csv 880282, 880449, 880280 (#8005)

* title for adfSelectProcessDropdown button, issue 880282

* 880449, 880280 fix

* review comments fix

* review comments
This commit is contained in:
arohilaGL 2022-11-29 15:04:54 +05:30 committed by GitHub
parent ec6ede4fc5
commit dea5f21894
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 6 deletions

View File

@ -1,4 +1,4 @@
<mat-chip-list aria-orientation="horizontal" role="listbox" [attr.aria-label]="'SEARCH.FILTER.ARIA-LABEL.SEARCH_FILTER' | translate"> <mat-chip-list role="listbox" [attr.aria-label]="'SEARCH.FILTER.ARIA-LABEL.SEARCH_FILTER' | translate">
<ng-container *ngFor="let category of queryBuilder.categories"> <ng-container *ngFor="let category of queryBuilder.categories">
<adf-search-widget-chip [category]="category"></adf-search-widget-chip> <adf-search-widget-chip [category]="category"></adf-search-widget-chip>
</ng-container> </ng-container>

View File

@ -39,7 +39,8 @@
"ACTION": { "ACTION": {
"START": "Start Process", "START": "Start Process",
"CANCEL": "Cancel" "CANCEL": "Cancel"
} },
"SELECT_PROCESS_DROPDOWN": "Select Process Dropdown BUTTON"
}, },
"ERROR": { "ERROR": {
"LOAD_PROCESS_DEFS": "Couldn't load process definitions, check you have access.", "LOAD_PROCESS_DEFS": "Couldn't load process definitions, check you have access.",

View File

@ -41,6 +41,7 @@
</mat-autocomplete> </mat-autocomplete>
<button <button
id="adf-select-process-dropdown" id="adf-select-process-dropdown"
title="{{'ADF_CLOUD_PROCESS_LIST.ADF_CLOUD_START_PROCESS.FORM.SELECT_PROCESS_DROPDOWN' | translate}}"
mat-icon-button mat-icon-button
(click)="displayDropdown($event)"> (click)="displayDropdown($event)">
<mat-icon>arrow_drop_down</mat-icon> <mat-icon>arrow_drop_down</mat-icon>

View File

@ -15,9 +15,10 @@
(selectionChange)="onAppSelectionChange($event)" (selectionChange)="onAppSelectionChange($event)"
[(ngModel)]="selectedApplication" [(ngModel)]="selectedApplication"
data-automation-id="adf-start-process-apps-drop-down"> data-automation-id="adf-start-process-apps-drop-down">
<mat-option <mat-option
*ngFor="let application of applications" *ngFor="let application of applications"
[value]="application" [value]="application"
role="option"
[attr.data-automation-id]="'adf-start-process-apps-option-' + application.name"> [attr.data-automation-id]="'adf-start-process-apps-option-' + application.name">
{{ application.name }} {{ application.name }}
</mat-option> </mat-option>
@ -75,7 +76,7 @@
{{ 'ADF_PROCESS_LIST.START_PROCESS.ERROR.SPACE_VALIDATOR' | translate }} {{ 'ADF_PROCESS_LIST.START_PROCESS.ERROR.SPACE_VALIDATOR' | translate }}
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
<ng-container *ngIf="!isProcessDefinitionsLoading ; else showStartFormLoadingTemplate"> <ng-container *ngIf="!isProcessDefinitionsLoading ; else showStartFormLoadingTemplate">
<ng-container *ngIf="isProcessDefinitionSelected() ; else emptyProcessDefTemplate"> <ng-container *ngIf="isProcessDefinitionSelected() ; else emptyProcessDefTemplate">
<ng-container *ngIf="hasStartForm(); else noStartFormTemplate"> <ng-container *ngIf="hasStartForm(); else noStartFormTemplate">
@ -96,7 +97,7 @@
</adf-start-form> </adf-start-form>
</ng-container> </ng-container>
<ng-template #noStartFormTemplate> <ng-template #noStartFormTemplate>
<adf-empty-content <adf-empty-content
class="adf-start-process-empty-template" class="adf-start-process-empty-template"
[icon]="'assessment'" [icon]="'assessment'"
[title]="'ADF_PROCESS_LIST.START_PROCESS.NO_START_FORM' | translate"> [title]="'ADF_PROCESS_LIST.START_PROCESS.NO_START_FORM' | translate">
@ -141,5 +142,5 @@
[icon]="'assessment'" [icon]="'assessment'"
[title]="'ADF_PROCESS_LIST.START_PROCESS.NO_PROCESS_DEFINITIONS' | translate"> [title]="'ADF_PROCESS_LIST.START_PROCESS.NO_PROCESS_DEFINITIONS' | translate">
</adf-empty-content> </adf-empty-content>
</ng-template> </ng-template>
</ng-template> </ng-template>