inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5645]Implemented changes as per the review comments

Browse Source
This commit is contained in:
Yasa-Nataliya
2023-10-13 16:29:15 +05:30
committed by Anukriti Singh
parent b4b995889f
commit def3943940
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
+3 -2
View File
@@ -105,7 +105,7 @@ describe('ContentMetadataComponent', () => {
const clickOnTagsSave = () => { const clickOnTagsSave = () => {
findSaveTagsButton().click(); findSaveTagsButton().click();
fixture.detectChanges(); fixture.detectChanges();
} };
const findTagsCreator = (): TagsCreatorComponent => fixture.debugElement.query(By.directive(TagsCreatorComponent))?.componentInstance; const findTagsCreator = (): TagsCreatorComponent => fixture.debugElement.query(By.directive(TagsCreatorComponent))?.componentInstance;
@@ -324,7 +324,7 @@ describe('ContentMetadataComponent', () => {
tag2.tag = tagName2; tag2.tag = tagName2;
expect(tagService.removeTag).toHaveBeenCalledWith(node.id, tagPaging.list.entries[1].entry.id); expect(tagService.removeTag).toHaveBeenCalledWith(node.id, tagPaging.list.entries[1].entry.id);
expect(tagService.assignTagsToNode).toHaveBeenCalledWith(node.id, [tag1, tag2]); expect(tagService.assignTagsToNode).toHaveBeenCalledWith(node.id, [tag1, tag2]);
})); }));
it('should call getTagsByNodeId on TagService on save click', () => { it('should call getTagsByNodeId on TagService on save click', () => {
component.editableTags = true; component.editableTags = true;
@@ -813,6 +813,7 @@ describe('ContentMetadataComponent', () => {
describe('Display properties with aspect oriented config', () => { describe('Display properties with aspect oriented config', () => {
let appConfig: AppConfigService; let appConfig: AppConfigService;
let classesApi: ClassesApi;
let expectedNode: Node; let expectedNode: Node;
const verResponse: PropertyGroup = { const verResponse: PropertyGroup = {
lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
+8
View File
@@ -196,6 +196,10 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy {
@Input() @Input()
group: CardViewGroup; group: CardViewGroup;
/** Emitted when content's editable state is changed. **/
@Output()
editableChange = new EventEmitter<boolean>();
private _assignedTags: string[] = []; private _assignedTags: string[] = [];
private assignedTagsEntries: TagEntry[] = []; private assignedTagsEntries: TagEntry[] = [];
private _editable = false; private _editable = false;
@@ -571,6 +575,10 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy {
); );
} }
private isEmpty(value: any): boolean {
return value === undefined || value === null || value === '';
}
private loadCategoriesForNode(nodeId: string) { private loadCategoriesForNode(nodeId: string) {
this.assignedCategories = []; this.assignedCategories = [];
this.categoryService.getCategoryLinksForNode(nodeId).subscribe((categoryPaging) => { this.categoryService.getCategoryLinksForNode(nodeId).subscribe((categoryPaging) => {