inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-10325] a11y SR: Metadata edit button announced twice (#11275)

Browse Source 
* [ACS-10325] a11y SR: Metadata edit button announced twice

* [ACS-10325] cr fix
This commit is contained in:
Mykyta Maliarchuk
2025-10-21 09:01:44 +02:00
committed by GitHub
parent 9b17f50401
commit e1d56be29c
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html
+9 -4
View File
@@ -9,6 +9,7 @@
hideToggle> hideToggle>
<mat-expansion-panel-header <mat-expansion-panel-header
class="adf-metadata-properties-header" class="adf-metadata-properties-header"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: ('CORE.METADATA.BASIC.HEADER' | translate) }"
[class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.PROPERTIES && currentPanel.expanded"> [class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.PROPERTIES && currentPanel.expanded">
<adf-content-metadata-header <adf-content-metadata-header
[title]="'CORE.METADATA.BASIC.HEADER'" [title]="'CORE.METADATA.BASIC.HEADER'"
@@ -18,7 +19,7 @@
mat-icon-button mat-icon-button
(click)="toggleGroupEditing(DefaultPanels.PROPERTIES, $event)" (click)="toggleGroupEditing(DefaultPanels.PROPERTIES, $event)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate" [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate: { sectionName: ('CORE.METADATA.BASIC.HEADER' | translate) }"
data-automation-id="meta-data-general-info-edit" data-automation-id="meta-data-general-info-edit"
class="adf-edit-icon-buttons"> class="adf-edit-icon-buttons">
<mat-icon>mode_edit</mat-icon> <mat-icon>mode_edit</mat-icon>
@@ -65,6 +66,7 @@
data-automation-id="adf-content-metadata-tags-panel"> data-automation-id="adf-content-metadata-tags-panel">
<mat-expansion-panel-header <mat-expansion-panel-header
class="adf-metadata-properties-header" class="adf-metadata-properties-header"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: ('METADATA.BASIC.TAGS' | translate) }"
[class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.TAGS && currentPanel.expanded"> [class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.TAGS && currentPanel.expanded">
<adf-content-metadata-header [title]="'METADATA.BASIC.TAGS'" [expanded]="currentPanel.panelTitle === DefaultPanels.TAGS && currentPanel.expanded"> <adf-content-metadata-header [title]="'METADATA.BASIC.TAGS'" [expanded]="currentPanel.panelTitle === DefaultPanels.TAGS && currentPanel.expanded">
<button <button
@@ -72,7 +74,7 @@
mat-icon-button mat-icon-button
(click)="toggleGroupEditing(DefaultPanels.TAGS, $event)" (click)="toggleGroupEditing(DefaultPanels.TAGS, $event)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate" [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate: { sectionName: ('METADATA.BASIC.TAGS' | translate) }"
data-automation-id="showing-tag-input-button" data-automation-id="showing-tag-input-button"
class="adf-edit-icon-buttons"> class="adf-edit-icon-buttons">
<mat-icon>mode_edit</mat-icon> <mat-icon>mode_edit</mat-icon>
@@ -126,6 +128,7 @@
data-automation-id="adf-content-metadata-categories-panel"> data-automation-id="adf-content-metadata-categories-panel">
<mat-expansion-panel-header <mat-expansion-panel-header
class="adf-metadata-properties-header" class="adf-metadata-properties-header"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: ('CATEGORIES_MANAGEMENT.CATEGORIES_TITLE' | translate) }"
[class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.CATEGORIES && currentPanel.expanded"> [class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === DefaultPanels.CATEGORIES && currentPanel.expanded">
<adf-content-metadata-header <adf-content-metadata-header
[title]="'CATEGORIES_MANAGEMENT.CATEGORIES_TITLE'" [title]="'CATEGORIES_MANAGEMENT.CATEGORIES_TITLE'"
@@ -135,7 +138,7 @@
mat-icon-button mat-icon-button
(click)="toggleGroupEditing(DefaultPanels.CATEGORIES, $event)" (click)="toggleGroupEditing(DefaultPanels.CATEGORIES, $event)"
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate" [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate: { sectionName: ('CATEGORIES_MANAGEMENT.CATEGORIES_TITLE' | translate) }"
data-automation-id="meta-data-categories-edit" data-automation-id="meta-data-categories-edit"
class="adf-categories-button adf-edit-icon-buttons"> class="adf-categories-button adf-edit-icon-buttons">
<mat-icon>mode_edit</mat-icon> <mat-icon>mode_edit</mat-icon>
@@ -188,6 +191,7 @@
hideToggle> hideToggle>
<mat-expansion-panel-header <mat-expansion-panel-header
class="adf-metadata-properties-header" class="adf-metadata-properties-header"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: (customPanel.panelTitle | translate) }"
[class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === customPanel.panelTitle && currentPanel.expanded"> [class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === customPanel.panelTitle && currentPanel.expanded">
<adf-content-metadata-header <adf-content-metadata-header
class="adf-metadata-custom-panel-title" class="adf-metadata-custom-panel-title"
@@ -208,13 +212,14 @@
hideToggle> hideToggle>
<mat-expansion-panel-header <mat-expansion-panel-header
class="adf-metadata-properties-header" class="adf-metadata-properties-header"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.SECTION' | translate: { sectionName: (group.title | translate) }"
[class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === group.title && currentPanel.expanded"> [class.adf-metadata-properties-header-expanded]="currentPanel.panelTitle === group.title && currentPanel.expanded">
<adf-content-metadata-header [title]="group.title" [expanded]="currentPanel.panelTitle === group.title && currentPanel.expanded"> <adf-content-metadata-header [title]="group.title" [expanded]="currentPanel.panelTitle === group.title && currentPanel.expanded">
<button <button
*ngIf="group.editable && !this.readOnly && !isPanelEditing(group.title)" *ngIf="group.editable && !this.readOnly && !isPanelEditing(group.title)"
mat-icon-button mat-icon-button
[attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate" [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
[attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate" [attr.aria-label]="'CORE.METADATA.ACCESSIBILITY.EDIT' | translate: { sectionName: (group.title | translate) }"
data-automation-id="meta-data-card-toggle-edit" data-automation-id="meta-data-card-toggle-edit"
class="adf-edit-icon-buttons" class="adf-edit-icon-buttons"
(click)="toggleGroupEditing(group.title, $event)"> (click)="toggleGroupEditing(group.title, $event)">
lib/core/src/lib/i18n/en.json
+3 -2
View File
@@ -285,10 +285,11 @@
"EDIT_ASPECTS": "Edit Aspect" "EDIT_ASPECTS": "Edit Aspect"
}, },
"ACCESSIBILITY": { "ACCESSIBILITY": {
"EDIT": "Edit button", "EDIT": "Edit {{ sectionName }}",
"DATEPICKER": "Use the arrow keys to navigate between dates. Up and down move to the next or previous week but on the same day. Left and right move to the next or previous day. Press Enter or Return to select a date.", "DATEPICKER": "Use the arrow keys to navigate between dates. Up and down move to the next or previous week but on the same day. Left and right move to the next or previous day. Press Enter or Return to select a date.",
"COPY_TO_CLIPBOARD_MESSAGE": "Value copied to clipboard", "COPY_TO_CLIPBOARD_MESSAGE": "Value copied to clipboard",
"EDIT_ASPECTS": "Edit Aspect" "EDIT_ASPECTS": "Edit Aspect",
"SECTION": "{{ sectionName }} section"
} }
}, },
"SEARCH": { "SEARCH": {