inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-38748 Change clipboard directive to be a tooltip (#11293)

Browse Source 
* feat: change clipboard directive to be a tooltip

* feat: remove redundant tooltips from datatable cells

* test: fix broken tests

* fix: sonarqube issues

* fix: unable to use link-adf commit message from hxp-frontend-apps
This commit is contained in:
Joshua Cain
2025-11-06 06:28:42 -05:00
committed by GitHub
parent 3180ca8e9d
commit e28e924b87
8 changed files with 114 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/process-services-cloud/src/lib/task/task-list/components/service-task-list/service-task-list-cloud.component.spec.ts
+34 -25
View File
@@ -16,7 +16,7 @@
*/
import { Component, SimpleChange, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ComponentFixture, TestBed, fakeAsync } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import {
AppConfigService,
@@ -36,6 +36,7 @@ import { ServiceTaskListCloudService } from '../../services/service-task-list-cl
import { HarnessLoader } from '@angular/cdk/testing';
import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
import { MatProgressSpinnerHarness } from '@angular/material/progress-spinner/testing';
import { MatTooltipHarness } from '@angular/material/tooltip/testing';
import { provideCloudPreferences } from '../../../../providers';
@Component({
@@ -396,25 +397,31 @@ describe('ServiceTaskListCloudComponent: Injecting custom columns for task list
expect(componentCustom.taskList.columns.length).toEqual(2);
});
it('it should show copy tooltip when key is present in data-column', () => {
it('it should show copy tooltip when key is present in data-column', fakeAsync(async () => {
customCopyComponent.taskList.reload();
copyFixture.detectChanges();
copyFixture.debugElement.query(By.css('span[title="04fdf69f-4ddd-48ab-9563-da776c9b163c"]')).triggerEventHandler('mouseenter');
const host = copyFixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
copyFixture.detectChanges();
expect(copyFixture.debugElement.query(By.css('.adf-copy-tooltip'))).not.toBeNull();
});
it('it should not show copy tooltip when key is not present in data-column', () => {
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(copyFixture);
const tooltip = await loader.getHarness(MatTooltipHarness.with({ selector: 'span[adf-clipboard]' }));
expect(await tooltip.isOpen()).toBeTrue();
}));
it('it should not show copy tooltip when key is not present in data-column', fakeAsync(async () => {
customCopyComponent.taskList.reload();
copyFixture.detectChanges();
copyFixture.debugElement.query(By.css('span[title="serviceTaskName"]')).triggerEventHandler('mouseenter');
const host = copyFixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
copyFixture.detectChanges();
expect(copyFixture.debugElement.query(By.css('.adf-copy-tooltip'))).toBeNull();
});
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(copyFixture);
const tooltips = await loader.getAllHarnesses(MatTooltipHarness.with({ selector: 'span[title="serviceTaskName"]' }));
expect(tooltips.length).toBe(0);
}));
});
describe('ServiceTaskListCloudComponent: Copy cell content directive from app.config specifications', () => {
@@ -461,33 +468,35 @@ describe('ServiceTaskListCloudComponent: Copy cell content directive from app.co
fixture.destroy();
});
it('shoud show tooltip if config copyContent flag is true', () => {
it('shoud show tooltip if config copyContent flag is true', fakeAsync(async () => {
taskSpy.and.returnValue(of(fakeServiceTask));
component.presetColumn = 'fakeCustomSchema';
component.reload();
fixture.detectChanges();
const columnWithCopyContentFlagTrue = fixture.debugElement.query(By.css('span[title="04fdf69f-4ddd-48ab-9563-da776c9b163c"]'));
columnWithCopyContentFlagTrue.triggerEventHandler('mouseenter');
const host = fixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
fixture.detectChanges();
expect(fixture.debugElement.nativeElement.querySelector('.adf-copy-tooltip')).not.toBeNull();
});
it('shoud not show tooltip if config copyContent flag is NOT true', () => {
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(fixture);
const tooltip = await loader.getHarness(MatTooltipHarness.with({ selector: 'span[adf-clipboard]' }));
expect(await tooltip.isOpen()).toBeTrue();
}));
it('shoud not show tooltip if config copyContent flag is NOT true', fakeAsync(async () => {
taskSpy.and.returnValue(of(fakeServiceTask));
component.presetColumn = 'fakeCustomSchema';
component.reload();
fixture.detectChanges();
const columnWithCopyContentFlagNotTrue = fixture.debugElement.query(By.css('span[title="serviceTaskName"]'));
columnWithCopyContentFlagNotTrue.triggerEventHandler('mouseenter');
const host = fixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
fixture.detectChanges();
expect(fixture.debugElement.nativeElement.querySelector('.adf-copy-tooltip')).toBeNull();
});
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(fixture);
const tooltips = await loader.getAllHarnesses(MatTooltipHarness.with({ selector: 'span[title="serviceTaskName"]' }));
expect(tooltips.length).toBe(0);
}));
});
lib/process-services-cloud/src/lib/task/task-list/components/task-list/task-list-cloud.component.spec.ts
+22 -18
View File
@@ -16,7 +16,7 @@
*/
import { Component, SimpleChange, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ComponentFixture, TestBed, fakeAsync } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import {
AppConfigService,
@@ -40,6 +40,7 @@ import { TASK_LIST_CLOUD_TOKEN, TASK_LIST_PREFERENCES_SERVICE_TOKEN } from '../.
import { HarnessLoader } from '@angular/cdk/testing';
import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
import { MatProgressSpinnerHarness } from '@angular/material/progress-spinner/testing';
import { MatTooltipHarness } from '@angular/material/tooltip/testing';
import { provideCloudPreferences } from '../../../../providers';
@Component({
@@ -699,24 +700,26 @@ describe('TaskListCloudComponent: Injecting custom colums for tasklist - CustomT
expect(componentCustom.taskList.columns.length).toEqual(3);
});
it('it should show copy tooltip when key is present in data-column', () => {
it('it should show copy tooltip when key is present in data-column', fakeAsync(async () => {
customCopyComponent.taskList.reload();
copyFixture.detectChanges();
copyFixture.debugElement.query(By.css('span[title="11fe013d-c263-11e8-b75b-0a5864600540"]')).triggerEventHandler('mouseenter');
const host = copyFixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
copyFixture.detectChanges();
expect(copyFixture.debugElement.query(By.css('.adf-copy-tooltip'))).not.toBeNull();
});
it('it should not show copy tooltip when key is not present in data-column', () => {
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(copyFixture);
const tooltip = await loader.getHarness(MatTooltipHarness.with({ selector: 'span[adf-clipboard]' }));
expect(await tooltip.isOpen()).toBeTrue();
}));
it('it should not show copy tooltip when key is not present in data-column', async () => {
customCopyComponent.taskList.reload();
copyFixture.detectChanges();
copyFixture.debugElement.query(By.css('span[title="standalone-subtask"]')).triggerEventHandler('mouseenter');
copyFixture.detectChanges();
expect(copyFixture.debugElement.query(By.css('.adf-copy-tooltip'))).toBeNull();
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(copyFixture);
const tooltips = await loader.getAllHarnesses(MatTooltipHarness.with({ selector: 'span[title="standalone-subtask"]' }));
expect(tooltips.length).toBe(0);
});
});
@@ -802,19 +805,20 @@ describe('TaskListCloudComponent: Copy cell content directive from app.config sp
fixture.destroy();
});
it('should show tooltip if config copyContent flag is true', () => {
it('should show tooltip if config copyContent flag is true', fakeAsync(async () => {
component.presetColumn = 'fakeCustomSchema';
component.reload();
fixture.detectChanges();
const columnWithCopyContentFlagTrue = fixture.debugElement.query(By.css('span[title="11fe013d-c263-11e8-b75b-0a5864600540"]'));
columnWithCopyContentFlagTrue.triggerEventHandler('mouseenter');
const host = fixture.debugElement.query(By.css('span[adf-clipboard]'));
host.triggerEventHandler('mouseenter', {});
fixture.detectChanges();
expect(fixture.debugElement.nativeElement.querySelector('.adf-copy-tooltip')).not.toBeNull();
});
const loader: HarnessLoader = TestbedHarnessEnvironment.loader(fixture);
const tooltip = await loader.getHarness(MatTooltipHarness.with({ selector: 'span[adf-clipboard]' }));
expect(await tooltip.isOpen()).toBeTrue();
}));
it('should replace priority values', () => {
component.presetColumn = 'fakeCustomSchema';