inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-09-17 14:21:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AAE-30882] - migrating from superagent to axios

Browse Source
This commit is contained in:
VitoAlbano
2025-08-13 18:21:15 +01:00
committed by Vito Albano
parent 6fa531e11f
commit e400bc1068
7 changed files with 204 additions and 243 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/js-api/src/alfrescoApiClient.ts
View File

@@ -18,10 +18,11 @@
import { EventEmitter } from 'eventemitter3';
import { AlfrescoApiConfig } from './alfrescoApiConfig';
import { Authentication } from './authentication/authentication';
import { SuperagentHttpClient } from './superagentHttpClient';
import { Emitters, HttpClient, LegacyHttpClient, RequestOptions, SecurityOptions } from './api-clients/http-client.interface';
import { paramToString } from './utils';
import { Storage } from './storage';
import { AxiosHttpClient } from './axiosHttpClient';
declare const Buffer: any;
@@ -106,7 +107,7 @@ export class AlfrescoApiClient implements LegacyHttpClient {
this.host = host;
this.storage = Storage.getInstance();
// fallback for backward compatibility
this.httpClient = httpClient || new SuperagentHttpClient();
this.httpClient = httpClient || new AxiosHttpClient();
}
// EventEmitter delegation methods

242
lib/js-api/src/superagentHttpClient.ts → lib/js-api/src/axiosHttpClient.ts
View File

@@ -16,7 +16,7 @@
*/
import { EventEmitter } from 'eventemitter3';
import superagent, { Response, SuperAgentRequest } from 'superagent';
import axios, { AxiosResponse, AxiosRequestConfig, AxiosError } from 'axios';
import { Authentication } from './authentication/authentication';
import { RequestOptions, HttpClient, SecurityOptions, Emitters } from './api-clients/http-client.interface';
import { Oauth2 } from './authentication/oauth2';
@@ -30,7 +30,7 @@ type EventEmitterInstance = InstanceType<typeof EventEmitter>;
const isProgressEvent = (event: ProgressEvent | unknown): event is ProgressEvent => (event as ProgressEvent)?.lengthComputable;
export class SuperagentHttpClient implements HttpClient {
export class AxiosHttpClient implements HttpClient {
/**
* The default HTTP timeout for all API calls.
*/
@@ -52,11 +52,11 @@ export class SuperagentHttpClient implements HttpClient {
return this.request<T>(url, { ...options, httpMethod: 'DELETE' }, securityOptions, emitters);
}
request<T = any>(url: string, options: RequestOptions, securityOptions: SecurityOptions, emitters: Emitters): Promise<T> {
async request<T = any>(url: string, options: RequestOptions, securityOptions: SecurityOptions, emitters: Emitters): Promise<T> {
const { httpMethod, queryParams, headerParams, formParams, bodyParam, contentType, accept, responseType, returnType } = options;
const { eventEmitter, apiClientEmitter } = emitters;
let request = this.buildRequest(
const config = this.buildRequest(
httpMethod,
url,
queryParams,
@@ -71,54 +71,55 @@ export class SuperagentHttpClient implements HttpClient {
securityOptions
);
const source = axios.CancelToken.source();
config.cancelToken = source.token;
if (returnType === 'Binary') {
request = request.buffer(true).parse(superagent.parse['application/octet-stream']);
config.responseType = 'arraybuffer';
}
const promise: any = new Promise((resolve, reject) => {
request.on('abort', () => {
eventEmitter.emit('abort');
});
request.end((error: any, response: Response) => {
if (error) {
apiClientEmitter.emit('error', error);
eventEmitter.emit('error', error);
if (error.status === 401) {
apiClientEmitter.emit('unauthorized');
eventEmitter.emit('unauthorized');
}
if (response?.text) {
error = error || {};
reject(Object.assign(error, { message: response.text }));
} else {
// eslint-disable-next-line prefer-promise-reject-errors
reject({ error });
const promise: any = axios(config)
.then((response: AxiosResponse<T>) => {
if (securityOptions.isBpmRequest) {
const hasSetCookie = response.headers['set-cookie'];
if (response.headers && hasSetCookie) {
// mutate the passed value from AlfrescoApiClient class for backward compatibility
securityOptions.authentications.cookie = hasSetCookie[0];
}
}
let data = {};
if (response.headers['content-type']?.includes('text/html')) {
data = AxiosHttpClient.deserialize(response);
} else {
if (securityOptions.isBpmRequest) {
const hasSetCookie = Object.prototype.hasOwnProperty.call(response.header, 'set-cookie');
if (response.header && hasSetCookie) {
// mutate the passed value from AlfrescoApiClient class for backward compatibility
securityOptions.authentications.cookie = response.header['set-cookie'][0];
}
}
let data = {};
if (response.type === 'text/html') {
data = SuperagentHttpClient.deserialize(response);
} else {
data = SuperagentHttpClient.deserialize(response, returnType);
}
data = AxiosHttpClient.deserialize(response, returnType);
}
eventEmitter.emit('success', data);
resolve(data);
eventEmitter.emit('success', data);
return data;
})
.catch((error: AxiosError) => {
apiClientEmitter.emit('error', error);
eventEmitter.emit('error', error);
if (error.response?.status === 401) {
apiClientEmitter.emit('unauthorized');
eventEmitter.emit('unauthorized');
}
if (error.response?.data) {
const responseError = error.response.data;
const enrichedError = Object.assign(error, {
message: typeof responseError === 'string' ? responseError : JSON.stringify(responseError)
});
throw enrichedError;
} else {
throw { error };
}
});
});
promise.abort = function () {
request.abort();
eventEmitter.emit('abort');
source.cancel('Request aborted');
return this;
};
@@ -139,128 +140,163 @@ export class SuperagentHttpClient implements HttpClient {
eventEmitter: EventEmitterInstance,
returnType: string,
securityOptions: SecurityOptions
) {
const request = superagent(httpMethod, url);
): AxiosRequestConfig {
const { isBpmRequest, authentications, defaultHeaders = {}, enableCsrf, withCredentials = false } = securityOptions;
const config: AxiosRequestConfig = {
method: httpMethod as any,
url,
params: AxiosHttpClient.normalizeParams(queryParams),
headers: {
...defaultHeaders,
...AxiosHttpClient.normalizeParams(headerParams)
},
timeout: typeof this.timeout === 'number' ? this.timeout : this.timeout?.response,
withCredentials
};
// apply authentications
this.applyAuthToRequest(request, authentications);
// set query parameters
request.query(SuperagentHttpClient.normalizeParams(queryParams));
// set header parameters
request.set(defaultHeaders).set(SuperagentHttpClient.normalizeParams(headerParams));
this.applyAuthToRequest(config, authentications);
if (isBpmRequest && enableCsrf) {
this.setCsrfToken(request);
}
if (withCredentials) {
request.withCredentials();
this.setCsrfToken(config);
}
// add cookie for activiti
if (isBpmRequest) {
request.withCredentials();
config.withCredentials = true;
if (securityOptions.authentications.cookie) {
if (!isBrowser()) {
request.set('Cookie', securityOptions.authentications.cookie);
config.headers = {
...config.headers,
Cookie: securityOptions.authentications.cookie
};
}
}
}
// set request timeout
request.timeout(this.timeout);
if (contentType && contentType !== 'multipart/form-data') {
request.type(contentType);
} else if (!(request as any).header['Content-Type'] && contentType !== 'multipart/form-data') {
request.type('application/json');
config.headers = {
...config.headers,
'Content-Type': contentType
};
} else if (!config.headers?.['Content-Type'] && contentType !== 'multipart/form-data') {
config.headers = {
...config.headers,
'Content-Type': 'application/json'
};
}
if (contentType === 'application/x-www-form-urlencoded') {
request.send(SuperagentHttpClient.normalizeParams(formParams)).on('progress', (event: any) => {
this.progress(event, eventEmitter);
const params = new URLSearchParams();
const normalizedParams = AxiosHttpClient.normalizeParams(formParams);
Object.keys(normalizedParams).forEach((key) => {
params.append(key, normalizedParams[key]);
});
config.data = params;
config.onUploadProgress = (progressEvent) => {
this.progress(progressEvent, eventEmitter);
};
} else if (contentType === 'multipart/form-data') {
const _formParams = SuperagentHttpClient.normalizeParams(formParams);
const formData = new FormData();
const _formParams = AxiosHttpClient.normalizeParams(formParams);
for (const key in _formParams) {
if (Object.prototype.hasOwnProperty.call(_formParams, key)) {
if (SuperagentHttpClient.isFileParam(_formParams[key])) {
if (AxiosHttpClient.isFileParam(_formParams[key])) {
// file field
request.attach(key, _formParams[key]).on('progress', (event: ProgressEvent) => {
// jshint ignore:line
this.progress(event, eventEmitter);
});
formData.append(key, _formParams[key]);
} else {
request.field(key, _formParams[key]).on('progress', (event: ProgressEvent) => {
// jshint ignore:line
this.progress(event, eventEmitter);
});
formData.append(key, _formParams[key]);
}
}
}
config.data = formData;
// Remove Content-Type header for multipart/form-data to let axios set the boundary
delete config.headers['Content-Type'];
config.onUploadProgress = (progressEvent) => {
this.progress(progressEvent, eventEmitter);
};
} else if (bodyParam) {
request.send(bodyParam).on('progress', (event: any) => {
this.progress(event, eventEmitter);
});
config.data = bodyParam;
config.onUploadProgress = (progressEvent) => {
this.progress(progressEvent, eventEmitter);
};
}
if (accept) {
request.accept(accept);
config.headers = {
...config.headers,
Accept: accept
};
}
if (returnType === 'blob' || returnType === 'Blob' || responseType === 'blob' || responseType === 'Blob') {
request.responseType('blob');
config.responseType = 'blob';
} else if (returnType === 'String') {
request.responseType('string');
config.responseType = 'text';
}
return request;
return config;
}
setCsrfToken(request: SuperAgentRequest): void {
const token = SuperagentHttpClient.createCSRFToken();
request.set('X-CSRF-TOKEN', token);
setCsrfToken(config: AxiosRequestConfig): void {
const token = AxiosHttpClient.createCSRFToken();
config.headers = {
...config.headers,
'X-CSRF-TOKEN': token
};
if (!isBrowser()) {
request.set('Cookie', 'CSRF-TOKEN=' + token + ';path=/');
config.headers = {
...config.headers,
Cookie: `CSRF-TOKEN=${token};path=/`
};
}
try {
document.cookie = 'CSRF-TOKEN=' + token + ';path=/';
} catch {
document.cookie = `CSRF-TOKEN=${token};path=/`;
} catch (err) {
/* continue regardless of error */
}
}
/**
* Applies authentication headers to the request.
* @param request The request object created by a <code>superagent()</code> call.
* @param config The axios request config object.
* @param authentications authentications
*/
private applyAuthToRequest(request: SuperAgentRequest, authentications: Authentication) {
private applyAuthToRequest(config: AxiosRequestConfig, authentications: Authentication) {
if (authentications) {
switch (authentications.type) {
case 'basic': {
const basicAuth: BasicAuth = authentications.basicAuth;
if (basicAuth.username || basicAuth.password) {
request.auth(basicAuth.username || '', basicAuth.password || '');
config.auth = {
username: basicAuth.username || '',
password: basicAuth.password || ''
};
}
break;
}
case 'activiti': {
if (authentications.basicAuth.ticket) {
request.set({ Authorization: authentications.basicAuth.ticket });
config.headers = {
...config.headers,
Authorization: authentications.basicAuth.ticket
};
}
break;
}
case 'oauth2': {
const oauth2: Oauth2 = authentications.oauth2;
if (oauth2.accessToken) {
request.set({ Authorization: 'Bearer ' + oauth2.accessToken });
config.headers = {
...config.headers,
Authorization: `Bearer ${oauth2.accessToken}`
};
}
break;
}
@@ -287,34 +323,34 @@ export class SuperagentHttpClient implements HttpClient {
private static createCSRFToken(a?: any): string {
return a
? (a ^ ((Math.random() * 16) >> (a / 4))).toString(16)
: ([1e16] + (1e16).toString()).replace(/[01]/g, SuperagentHttpClient.createCSRFToken);
: ([1e16] + (1e16).toString()).replace(/[01]/g, AxiosHttpClient.createCSRFToken);
}
/**
* Deserializes an HTTP response body into a value of the specified type.
* @param response A SuperAgent response object.
* @param response An Axios response object.
* @param returnType The type to return. Pass a string for simple types
* or the constructor function for a complex type. Pass an array containing the type name to return an array of that type. To
* return an object, pass an object with one property whose name is the key type and whose value is the corresponding value type:
* all properties on <code>data<code> will be converted to this type.
* @returns A value of the specified type.
*/
private static deserialize(response: Response, returnType?: any): any {
private static deserialize(response: AxiosResponse, returnType?: any): any {
if (response === null) {
return null;
}
let data = response.body;
let data = response.data;
if (data === null) {
data = response.text;
data = response.statusText;
}
if (returnType) {
if (returnType === 'blob' && isBrowser()) {
data = new Blob([data], { type: response.header['content-type'] });
data = new Blob([data], { type: response.headers['content-type'] });
} else if (returnType === 'blob' && !isBrowser()) {
data = new Buffer.from(data, 'binary');
data = Buffer.from(data, 'binary');
} else if (Array.isArray(data)) {
data = data.map((element) => new returnType(element));
} else {
@@ -341,7 +377,7 @@ export class SuperagentHttpClient implements HttpClient {
for (const key in params) {
if (Object.prototype.hasOwnProperty.call(params, key) && params[key] !== undefined && params[key] !== null) {
const value = params[key];
if (SuperagentHttpClient.isFileParam(value) || Array.isArray(value)) {
if (AxiosHttpClient.isFileParam(value) || Array.isArray(value)) {
newParams[key] = value;
} else {
newParams[key] = paramToString(value);

9
lib/js-api/test/bpmAuth.spec.ts
View File

@@ -17,8 +17,9 @@
import assert from 'assert';
import { ProcessAuth } from '../src';
import { SuperagentHttpClient } from '../src/superagentHttpClient';
import { BpmAuthMock } from './mockObjects';
import { AxiosHttpClient } from '../src/axiosHttpClient';
describe('Bpm Auth test', () => {
const hostBpm = 'https://127.0.0.1:9999';
@@ -256,16 +257,16 @@ describe('Bpm Auth test', () => {
let setCsrfTokenCalled = false;
beforeEach(() => {
originalMethod = SuperagentHttpClient.prototype.setCsrfToken;
originalMethod = AxiosHttpClient.prototype.setCsrfToken;
setCsrfTokenCalled = false;
SuperagentHttpClient.prototype.setCsrfToken = () => {
AxiosHttpClient.prototype.setCsrfToken = () => {
setCsrfTokenCalled = true;
};
});
afterEach(() => {
SuperagentHttpClient.prototype.setCsrfToken = originalMethod;
AxiosHttpClient.prototype.setCsrfToken = originalMethod;
setCsrfTokenCalled = false;
});

41
lib/js-api/test/mockObjects/oauth2/oauth.mock.ts
View File

@@ -29,18 +29,37 @@ export class OAuthMock extends BaseMock {
}
get200Response(mockToken?: string): void {
nock(this.host).options('/auth/realms/springboot/protocol/openid-connect/token').reply(200, '', {
'Access-Control-Allow-Origin': '*',
'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE, OPTIONS',
'Access-Control-Allow-Headers': 'Content-Type, Authorization',
'Access-Control-Max-Age': '86400'
});
nock(this.host, { encodedQueryParams: true })
.post('/auth/realms/springboot/protocol/openid-connect/token')
.reply(200, {
access_token: mockToken || 'test-token',
expires_in: 300,
refresh_expires_in: 1800,
refresh_token:
// eslint-disable-next-line max-len
'eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICI0cHczOUltNE54dXZEN0ZqZ3JOQ3Q2ZkpaVDctQ3JWTzRkX3BLaXJlSTF3In0.eyJqdGkiOiI2MzQxMDc1ZC1lOTY4LTRmZTctOTkwZS05MTQ3NTUwOGEzZWIiLCJleHAiOjE1Mjk2MDkxMDYsIm5iZiI6MCwiaWF0IjoxNTI5NjA3MzA2LCJpc3MiOiJodHRwOi8vYTVlMmY5M2RlMTBhZjExZThhMDU2MGExYmVhNWI3YzgtMjM2NzA5NDMzLnVzLWVhc3QtMS5lbGIuYW1hem9uYXdzLmNvbTozMDA4MS9hdXRoL3JlYWxtcy9zcHJpbmdib290IiwiYXVkIjoiYWN0aXZpdGkiLCJzdWIiOiJlMjRjZjM0Mi1mYzUwLTRjYjEtYTBjMC01N2RhZWRiODI3NDkiLCJ0eXAiOiJSZWZyZXNoIiwiYXpwIjoiYWN0aXZpdGkiLCJhdXRoX3RpbWUiOjAsInNlc3Npb25fc3RhdGUiOiI5NDMzZTIwNi1kZjFhLTQ2YTMtYmU3ZS02NWIwNDVhMWMzNmIiLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsiYWRtaW4iLCJ1bWFfYXV0aG9yaXphdGlvbiJdfSwicmVzb3VyY2VfYWNjZXNzIjp7InJlYWxtLW1hbmFnZW1lbnQiOnsicm9sZXMiOlsidmlldy1pZGVudGl0eS1wcm92aWRlcnMiLCJ2aWV3LXJlYWxtIiwibWFuYWdlLWlkZW50aXR5LXByb3ZpZGVycyIsImltcGVyc29uYXRpb24iLCJyZWFsbS1hZG1pbiIsImNyZWF0ZS1jbGllbnQiLCJtYW5hZ2UtdXNlcnMiLCJxdWVyeS1yZWFsbXMiLCJ2aWV3LWF1dGhvcml6YXRpb24iLCJxdWVyeS1jbGllbnRzIiwicXVlcnktdXNlcnMiLCJtYW5hZ2UtZXZlbnRzIiwibWFuYWdlLXJlYWxtIiwidmlldy1ldmVudHMiLCJ2aWV3LXVzZXJzIiwidmlldy1jbGllbnRzIiwibWFuYWdlLWF1dGhvcml6YXRpb24iLCJtYW5hZ2UtY2xpZW50cyIsInF1ZXJ5LWdyb3VwcyJdfSwiYnJva2VyIjp7InJvbGVzIjpbInJlYWQtdG9rZW4iXX0sImFjY291bnQiOnsicm9sZXMiOlsibWFuYWdlLWFjY291bnQiLCJtYW5hZ2UtYWNjb3VudC1saW5rcyIsInZpZXctcHJvZmlsZSJdfX19.mQ4Vi1yLG9KvcmmhHlgOowy8D30iaUsiO7--JTPY7Ol-R1eY4wvRn1cH5FllieXk8yltYGP23xXNtTC4M54guXGVtgRgo8AlRklFHL1BMlxpa0OPwcNmwthx1-P2n7c9XL1e8pt2uRhQJLxunr2TpLaQi0UpEmEyouXHfR7sxM1AzKAf3b9Nk7f7lrk__2BYlFsL3YcGlFDqDMgPfhNlDbR-rQGoxlOjt0YqS8ktYq4bneL5etpXnPh0oEt4B7FFK-WKKuOWR6rQ9791ACnn6puz6C_Ki261IkZ0a_Uu7tOA4Xi9xzoQKLgSTAlBeg4u86Wb5kjL5r2-3zTg-Dikew',
token_type: 'bearer',
'not-before-policy': 0,
session_state: '9433e206-df1a-46a3-be7e-65b045a1c36b'
});
.reply(
200,
{
access_token: mockToken || 'test-token',
expires_in: 300,
refresh_expires_in: 1800,
refresh_token:
// eslint-disable-next-line max-len
'eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICI0cHczOUltNE54dXZEN0ZqZ3JOQ3Q2ZkpaVDctQ3JWTzRkX3BLaXJlSTF3In0.eyJqdGkiOiI2MzQxMDc1ZC1lOTY4LTRmZTctOTkwZS05MTQ3NTUwOGEzZWIiLCJleHAiOjE1Mjk2MDkxMDYsIm5iZiI6MCwiaWF0IjoxNTI5NjA3MzA2LCJpc3MiOiJodHRwOi8vYTVlMmY5M2RlMTBhZjExZThhMDU2MGExYmVhNWI3YzgtMjM2NzA5NDMzLnVzLWVhc3QtMS5lbGIuYW1hem9uYXdzLmNvbTozMDA4MS9hdXRoL3JlYWxtcy9zcHJpbmdib290IiwiYXVkIjoiYWN0aXZpdGkiLCJzdWIiOiJlMjRjZjM0Mi1mYzUwLTRjYjEtYTBjMC01N2RhZWRiODI3NDkiLCJ0eXAiOiJSZWZyZXNoIiwiYXpwIjoiYWN0aXZpdGkiLCJhdXRoX3RpbWUiOjAsInNlc3Npb25fc3RhdGUiOiI5NDMzZTIwNi1kZjFhLTQ2YTMtYmU3ZS02NWIwNDVhMWMzNmIiLCJyZWFsbV9hY2Nlc3MiOnsicm9sZXMiOlsiYWRtaW4iLCJ1bWFfYXV0aG9yaXphdGlvbiJdfSwicmVzb3VyY2VfYWNjZXNzIjp7InJlYWxtLW1hbmFnZW1lbnQiOnsicm9sZXMiOlsidmlldy1pZGVudGl0eS1wcm92aWRlcnMiLCJ2aWV3LXJlYWxtIiwibWFuYWdlLWlkZW50aXR5LXByb3ZpZGVycyIsImltcGVyc29uYXRpb24iLCJyZWFsbS1hZG1pbiIsImNyZWF0ZS1jbGllbnQiLCJtYW5hZ2UtdXNlcnMiLCJxdWVyeS1yZWFsbXMiLCJ2aWV3LWF1dGhvcml6YXRpb24iLCJxdWVyeS1jbGllbnRzIiwicXVlcnktdXNlcnMiLCJtYW5hZ2UtZXZlbnRzIiwibWFuYWdlLXJlYWxtIiwidmlldy1ldmVudHMiLCJ2aWV3LXVzZXJzIiwidmlldy1jbGllbnRzIiwibWFuYWdlLWF1dGhvcml6YXRpb24iLCJtYW5hZ2UtY2xpZW50cyIsInF1ZXJ5LWdyb3VwcyJdfSwiYnJva2VyIjp7InJvbGVzIjpbInJlYWQtdG9rZW4iXX0sImFjY291bnQiOnsicm9sZXMiOlsibWFuYWdlLWFjY291bnQiLCJtYW5hZ2UtYWNjb3VudC1saW5rcyIsInZpZXctcHJvZmlsZSJdfX19.mQ4Vi1yLG9KvcmmhHlgOowy8D30iaUsiO7--JTPY7Ol-R1eY4wvRn1cH5FllieXk8yltYGP23xXNtTC4M54guXGVtgRgo8AlRklFHL1BMlxpa0OPwcNmwthx1-P2n7c9XL1e8pt2uRhQJLxunr2TpLaQi0UpEmEyouXHfR7sxM1AzKAf3b9Nk7f7lrk__2BYlFsL3YcGlFDqDMgPfhNlDbR-rQGoxlOjt0YqS8ktYq4bneL5etpXnPh0oEt4B7FFK-WKKuOWR6rQ9791ACnn6puz6C_Ki261IkZ0a_Uu7tOA4Xi9xzoQKLgSTAlBeg4u86Wb5kjL5r2-3zTg-Dikew',
token_type: 'bearer',
'not-before-policy': 0,
session_state: '9433e206-df1a-46a3-be7e-65b045a1c36b'
},
{
'Access-Control-Allow-Origin': '*',
'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE, OPTIONS',
'Access-Control-Allow-Headers': 'Content-Type, Authorization, X-Requested-With',
'Content-Type': 'application/json'
}
);
}
cleanAll() {
nock.cleanAll();
}
}

24
lib/js-api/test/superagentHttpClient.spec.ts
View File

@@ -16,12 +16,12 @@
*/
import assert from 'assert';
import { SuperagentHttpClient } from '../src/superagentHttpClient';
import { Response } from 'superagent';
import { AxiosHttpClient } from '../src/axiosHttpClient';
import { AxiosResponse } from 'axios';
describe('SuperagentHttpClient', () => {
describe('AxiosHttpClient', () => {
describe('#buildRequest', () => {
const client = new SuperagentHttpClient();
const client = new AxiosHttpClient();
it('should create a request with response type blob', () => {
const queryParams = {};
@@ -70,8 +70,8 @@ describe('SuperagentHttpClient', () => {
describe('#deserialize', () => {
it('should the deserializer return an array of object when the response is an array', () => {
const data = {
body: [
const data: AxiosResponse = {
data: [
{
id: '1',
name: 'test1'
@@ -80,9 +80,15 @@ describe('SuperagentHttpClient', () => {
id: '2',
name: 'test2'
}
]
} as Response;
const result = SuperagentHttpClient['deserialize'](data);
],
status: 200,
statusText: 'OK',
headers: {},
config: {
headers: undefined
}
};
const result = AxiosHttpClient['deserialize'](data);
const isArray = Array.isArray(result);
assert.equal(isArray, true);
});