From e92abf99d9585b390ab1768913670f7f052bd97e Mon Sep 17 00:00:00 2001 From: Vito Albano Date: Fri, 16 Dec 2016 15:03:15 +0000 Subject: [PATCH] #1301 - fixed test on activiti form --- .../activiti-form.component.spec.ts | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/ng2-components/ng2-activiti-form/src/components/activiti-form.component.spec.ts b/ng2-components/ng2-activiti-form/src/components/activiti-form.component.spec.ts index e0a268a431..c992b378a8 100644 --- a/ng2-components/ng2-activiti-form/src/components/activiti-form.component.spec.ts +++ b/ng2-components/ng2-activiti-form/src/components/activiti-form.component.spec.ts @@ -28,18 +28,17 @@ describe('ActivitiForm', () => { let componentHandler: any; let formService: FormService; let formComponent: ActivitiForm; - let visibilityService: WidgetVisibilityService; + let visibilityService: WidgetVisibilityService; let nodeService: NodeService; beforeEach(() => { componentHandler = jasmine.createSpyObj('componentHandler', [ 'upgradeAllRegistered' ]); - visibilityService = jasmine.createSpyObj('WidgetVisibilityService', [ - 'refreshVisibility', 'getTaskProcessVariable' - ]); window['componentHandler'] = componentHandler; + visibilityService = new WidgetVisibilityService(null); + spyOn(visibilityService, 'refreshVisibility').and.stub(); formService = new FormService(null, null); nodeService = new NodeService(null, null); formComponent = new ActivitiForm(formService, visibilityService, null, nodeService); @@ -139,6 +138,7 @@ describe('ActivitiForm', () => { it('should get form by task id on load', () => { spyOn(formComponent, 'getFormByTaskId').and.stub(); + spyOn(visibilityService, 'getTaskProcessVariable').and.returnValue(Observable.of({})); const taskId = '123'; formComponent.taskId = taskId; @@ -218,7 +218,7 @@ describe('ActivitiForm', () => { spyOn(formComponent, 'getFormDefinitionByFormId').and.stub(); spyOn(formComponent, 'getFormDefinitionByFormName').and.stub(); - formComponent.ngOnChanges({ 'tag': new SimpleChange(null, 'hello world')}); + formComponent.ngOnChanges({ 'tag': new SimpleChange(null, 'hello world') }); expect(formComponent.getFormByTaskId).not.toHaveBeenCalled(); expect(formComponent.getFormDefinitionByFormId).not.toHaveBeenCalled(); @@ -521,10 +521,10 @@ describe('ActivitiForm', () => { it('should complete form form and raise corresponding event', () => { spyOn(formService, 'completeTaskForm').and.callFake(() => { - return Observable.create(observer => { - observer.next(); - observer.complete(); - }); + return Observable.create(observer => { + observer.next(); + observer.complete(); + }); }); const outcome = 'complete'; @@ -572,17 +572,17 @@ describe('ActivitiForm', () => { }); /* - it('should update the visibility when the container raise the change event', (valueChanged) => { - spyOn(formComponent, 'checkVisibility').and.callThrough(); - let widget = new ContainerWidget(); - let fakeForm = new FormModel(); - let fakeField = new FormFieldModel(fakeForm, {id: 'fakeField', value: 'fakeValue'}); - widget.formValueChanged.subscribe(field => { valueChanged(); }); - widget.fieldChanged(fakeField); + it('should update the visibility when the container raise the change event', (valueChanged) => { + spyOn(formComponent, 'checkVisibility').and.callThrough(); + let widget = new ContainerWidget(); + let fakeForm = new FormModel(); + let fakeField = new FormFieldModel(fakeForm, {id: 'fakeField', value: 'fakeValue'}); + widget.formValueChanged.subscribe(field => { valueChanged(); }); + widget.fieldChanged(fakeField); - expect(formComponent.checkVisibility).toHaveBeenCalledWith(fakeField); - }); - */ + expect(formComponent.checkVisibility).toHaveBeenCalledWith(fakeField); + }); + */ it('should prevent default outcome execution', () => {