various code quality fixes (#5792)

* various code quality fixes

* reduce duplicated code

* add safety check

lib/insights/src/lib/analytics-process/components/analytics-generator.component.ts

@@ -120,8 +120,8 @@ export class AnalyticsGeneratorComponent implements OnChanges {
         return this.showDetails;
     }
 
-    isCurrent(position: number) {
-        return position === this.currentChartPosition ? true : false;
+    isCurrent(position: number): boolean {
+        return position === this.currentChartPosition;
     }
 
     selectCurrent(position: number) {

lib/insights/src/lib/analytics-process/components/analytics-report-heat-map.component.ts

@@ -85,10 +85,10 @@ export class AnalyticsReportHeatMapComponent implements  OnInit {
         });
     }
 
-    hasMetric() {
-        return (this.report.totalCountsPercentages ||
-        this.report.totalTimePercentages ||
-        this.report.avgTimePercentages) ? true : false;
+    hasMetric(): boolean {
+        return !!(this.report.totalCountsPercentages ||
+            this.report.totalTimePercentages ||
+            this.report.avgTimePercentages);
     }
 
 }

lib/insights/src/lib/analytics-process/components/analytics-report-list.component.ts

@@ -171,15 +171,15 @@ export class AnalyticsReportListComponent implements OnInit {
         this.selectFirst = false;
     }
 
-    isSelected(report: any) {
-        return this.currentReport === report ? true : false;
+    isSelected(report: any): boolean {
+        return this.currentReport === report;
     }
 
-    isList() {
+    isList(): boolean {
         return this.layoutType === AnalyticsReportListComponent.LAYOUT_LIST;
     }
 
-    isGrid() {
+    isGrid(): boolean {
         return this.layoutType === AnalyticsReportListComponent.LAYOUT_GRID;
     }
 }

lib/insights/src/lib/analytics-process/components/widgets/widget.component.ts

@@ -35,8 +35,8 @@ export class WidgetComponent implements OnChanges {
         }
     }
 
-    hasField() {
-        return this.field ? true : false;
+    hasField(): boolean {
+        return !!this.field;
     }
 
     hasValue(): boolean {

lib/insights/src/lib/diagram/models/chart/bar-chart.model.ts

@@ -101,7 +101,7 @@ export class BarChart extends Chart {
         };
     };
 
-    hasDatasets() {
-        return this.datasets && this.datasets.length > 0 ? true : false;
+    hasDatasets(): boolean {
+        return this.datasets && this.datasets.length > 0;
     }
 }

lib/insights/src/lib/diagram/models/chart/details-table-chart.model.ts

@@ -28,7 +28,7 @@ export class DetailsTableChart extends TableChart {
         }
     }
 
-    hasDetailsTable() {
-        return this.detailsTable ? true : false;
+    hasDetailsTable(): boolean {
+        return !!this.detailsTable;
     }
 }