From e949b75da8f9a7f72cfcee7b797bd5efb5904f10 Mon Sep 17 00:00:00 2001
From: Vito Albano <vito.albano@alfresco.com>
Date: Tue, 13 Aug 2024 16:08:24 +0100
Subject: [PATCH] Ordered builds for js-api to avoid racing condition on dist
 folder (#10088)

* Ordered builds for js-api to avoid racing condition on dist folder

* Reverted changes to tmp
---
 lib/cli/project.json    | 21 +++++----------------
 lib/js-api/project.json | 24 +++++++++++++-----------
 2 files changed, 18 insertions(+), 27 deletions(-)

diff --git a/lib/cli/project.json b/lib/cli/project.json
index d5b4dcc8a3..576c8ca04f 100644
--- a/lib/cli/project.json
+++ b/lib/cli/project.json
@@ -26,9 +26,7 @@
           }
         ]
       },
-      "dependsOn": [
-        "copyToNodeModules"
-      ]
+      "dependsOn": ["copyToNodeModules"]
     },
     "copyToNodeModules": {
       "executor": "nx:run-commands",
@@ -39,9 +37,7 @@
           }
         ]
       },
-      "dependsOn": [
-        "installDeps", "build"
-      ]
+      "dependsOn": ["installDeps", "build"]
     },
     "installDeps": {
       "executor": "nx:run-commands",
@@ -52,24 +48,17 @@
           }
         ]
       },
-      "dependsOn": [
-        "build"
-      ]
+      "dependsOn": ["build"]
     },
     "lint": {
       "executor": "@nrwl/linter:eslint",
       "options": {
-        "lintFilePatterns": [
-          "lib/cli/**/*.ts",
-          "lib/cli/**/*.html"
-        ]
+        "lintFilePatterns": ["lib/cli/**/*.ts", "lib/cli/**/*.html"]
       }
     },
     "npm-publish": {
       "executor": "nx:run-commands",
-      "dependsOn": [
-        "build"
-      ],
+      "dependsOn": ["build"],
       "options": {
         "cwd": "dist/libs/cli",
         "commands": [
diff --git a/lib/js-api/project.json b/lib/js-api/project.json
index caa2d5cd62..252afe68c0 100644
--- a/lib/js-api/project.json
+++ b/lib/js-api/project.json
@@ -8,7 +8,7 @@
     "build": {
       "executor": "@nrwl/js:tsc",
       "outputs": ["{options.outputPath}"],
-      "dependsOn": ["build-esm5", "build-esm2015", "build-cjs"],
+      "dependsOn": ["build-esm5"],
       "options": {
         "outputPath": "dist/libs/js-api/typings",
         "main": "lib/js-api/src/index.ts",
@@ -23,19 +23,10 @@
         }
       }
     },
-    "build-cjs": {
-      "executor": "@nrwl/js:tsc",
-      "outputs": ["{options.outputPath}"],
-      "options": {
-        "outputPath": "dist/libs/js-api",
-        "main": "lib/js-api/src/index.ts",
-        "tsConfig": "lib/js-api/tsconfig/tsconfig.cjs.json",
-        "assets": ["lib/js-api/*.md", "lib/js-api/LICENSE.txt"]
-      }
-    },
     "build-esm5": {
       "executor": "@nrwl/js:tsc",
       "outputs": ["{options.outputPath}"],
+      "dependsOn": ["build-esm2015"],
       "options": {
         "outputPath": "dist/libs/js-api/esm5",
         "main": "lib/js-api/src/index.ts",
@@ -45,12 +36,23 @@
     "build-esm2015": {
       "executor": "@nrwl/js:tsc",
       "outputs": ["{options.outputPath}"],
+      "dependsOn": ["build-cjs"],
       "options": {
         "outputPath": "dist/libs/js-api/esm2015",
         "main": "lib/js-api/src/index.ts",
         "tsConfig": "lib/js-api/tsconfig/tsconfig.esm2015.json"
       }
     },
+    "build-cjs": {
+      "executor": "@nrwl/js:tsc",
+      "outputs": ["{options.outputPath}"],
+      "options": {
+        "outputPath": "dist/libs/js-api",
+        "main": "lib/js-api/src/index.ts",
+        "tsConfig": "lib/js-api/tsconfig/tsconfig.cjs.json",
+        "assets": ["lib/js-api/*.md", "lib/js-api/LICENSE.txt"]
+      }
+    },
     "build-types": {
       "executor": "@nrwl/js:tsc",
       "outputs": ["{options.outputPath}"],