From e9dc55bca21aa2f9a6727b3b49133570417cb82f Mon Sep 17 00:00:00 2001
From: jacekpluta <73617938+jacekpluta@users.noreply.github.com>
Date: Mon, 11 Mar 2024 15:33:09 +0100
Subject: [PATCH] [ACS-5575] Should use declaration-no-important rule in the
stylelint-config.json file to avoid use of !important in ADF (#9302)
---
.../user-info/user-info.component.html | 8 +-
.../cloud/cloud-filters-demo.component.scss | 2 +-
.../app/components/files/files.component.scss | 4 +-
docs/user-guide/theming.md | 3 -
...content-node-selector-panel.component.scss | 8 +-
.../content-user-info.component.scss | 7 +
.../components/document-list.component.scss | 6 +-
.../user-icon-column.component.scss | 32 +--
.../search-filter-container.component.html | 1 +
.../search-filter-container.component.scss | 16 +-
.../search-filter-tabbed.component.scss | 1 +
.../src/lib/social/rating.component.scss | 6 +-
.../lib/tree/components/tree.component.scss | 6 +-
.../file-uploading-dialog.component.html | 3 +
.../file-uploading-dialog.component.scss | 9 +-
.../file-uploading-list-row.component.scss | 8 +-
.../upload-drag-area.component.scss | 2 +-
.../version-manager.component.scss | 38 ++--
.../version-upload.component.scss | 6 +-
.../select-filter-input.component.scss | 4 +-
.../src/lib/clipboard/clipboard.theme.scss | 6 +-
.../comment-list/comment-list.component.scss | 120 ++++++------
.../columns-selector.component.scss | 4 +-
.../datatable/datatable.component.html | 3 +-
.../datatable/datatable.component.scss | 90 ++++-----
.../tooltip-card/tooltip-card.component.scss | 2 +-
.../components/form-renderer.component.html | 6 +
.../components/form-renderer.component.scss | 19 +-
.../inplace-form-input.component.scss | 12 +-
.../form/components/widgets/form.theme.scss | 8 +-
.../multiline-text/multiline-text.widget.html | 2 +-
.../multiline-text/multiline-text.widget.scss | 4 +-
.../components/header/header.component.scss | 2 +-
.../layout-container.component.html | 3 +-
.../layout-container.component.scss | 9 +-
.../sidebar-action-menu.component.scss | 4 +-
.../sidenav-layout.component.scss | 1 +
.../lib/login/components/login.component.html | 1 +
.../lib/login/components/login.component.scss | 18 +-
.../notification-history.component.html | 6 +-
.../notification-history.component.scss | 20 +-
.../search-text-input.component.scss | 4 +-
lib/core/src/lib/styles/_default-class.scss | 13 --
lib/core/src/lib/styles/_index.scss | 1 -
lib/core/src/lib/styles/material.theme.scss | 2 +-
.../empty-content.component.scss | 10 +-
.../components/media-player.component.html | 2 +-
.../components/media-player.component.scss | 4 +-
.../components/pdf-viewer-host.component.scss | 6 +-
...analytics-report-parameters.component.scss | 22 +--
.../app-details-cloud.component.html | 2 +-
.../app-details-cloud.component.scss | 20 +-
.../form/components/form-cloud.component.html | 2 +-
...file-properties-table-cloud.component.html | 4 +-
...file-properties-table-cloud.component.scss | 10 +-
.../dropdown/dropdown-cloud.widget.scss | 10 +-
.../components/group-cloud.component.scss | 13 +-
.../components/people-cloud.component.scss | 5 +-
.../start-process-cloud.component.scss | 8 +-
.../rich-text-editor.component.scss | 1 +
.../start-task-cloud.component.html | 4 +-
.../start-task-cloud.component.scss | 6 -
.../components/task-form-cloud.component.html | 2 +-
.../components/task-form-cloud.component.scss | 44 +++--
.../src/lib/app-list/apps-list.component.scss | 39 ++--
.../process-attachment-list.component.scss | 8 +-
.../task-attachment-list.component.scss | 4 -
.../src/lib/form/start-form.component.html | 7 +-
.../src/lib/form/start-form.component.scss | 182 +++++++++---------
.../widgets/dropdown/dropdown.widget.scss | 2 +-
.../components/process-filters.component.scss | 6 +-
.../components/start-process.component.html | 7 +-
.../components/start-process.component.scss | 14 +-
.../process-user-info.component.scss | 11 +-
.../components/start-task.component.scss | 8 +-
.../components/task-filters.component.scss | 6 +-
.../components/task-standalone.component.html | 2 +-
.../components/task-standalone.component.scss | 94 ++++-----
.../widget/attach-file-widget-cloud.page.ts | 2 +-
stylelint-config.json | 1 +
80 files changed, 533 insertions(+), 565 deletions(-)
delete mode 100644 lib/core/src/lib/styles/_default-class.scss
diff --git a/demo-shell/src/app/components/app-layout/user-info/user-info.component.html b/demo-shell/src/app/components/app-layout/user-info/user-info.component.html
index 8b2e071e5e..e4820fb808 100644
--- a/demo-shell/src/app/components/app-layout/user-info/user-info.component.html
+++ b/demo-shell/src/app/components/app-layout/user-info/user-info.component.html
@@ -1,21 +1,21 @@
-
-
-
-
\ No newline at end of file
+
diff --git a/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss b/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss
index 8806abc49e..4c7032fc38 100644
--- a/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss
+++ b/demo-shell/src/app/components/cloud/cloud-filters-demo.component.scss
@@ -1,4 +1,4 @@
app-cloud-task-filters .app-filters__entry,
app-cloud-process-filters .app-filters__entry {
- padding-left: 0 !important;
+ padding-left: 0;
}
diff --git a/demo-shell/src/app/components/files/files.component.scss b/demo-shell/src/app/components/files/files.component.scss
index 90080aa61b..cbce74ceff 100644
--- a/demo-shell/src/app/components/files/files.component.scss
+++ b/demo-shell/src/app/components/files/files.component.scss
@@ -1,5 +1,5 @@
-.app-container {
- margin: 10px !important;
+.app-container:has(.app-document-list-container) {
+ margin: 10px;
}
.app-error-message {
diff --git a/docs/user-guide/theming.md b/docs/user-guide/theming.md
index 2c49d475e5..eefe993c4f 100644
--- a/docs/user-guide/theming.md
+++ b/docs/user-guide/theming.md
@@ -141,9 +141,6 @@ Any component with the `add-dark-theme` class will use the dark theme, while ot
## Default reusable class
```css
-.adf-hide-small // Display none vieweport <960px
-.adf-hide-xsmall // Display none vieweport <600px
-
.accent-color // Accent color
.warn-color // Warn color
.primary-contrast-text-color // Default contrast color for primary color
diff --git a/lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.scss b/lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.scss
index 0e2822af4a..080e9260ee 100644
--- a/lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.scss
+++ b/lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.scss
@@ -114,9 +114,9 @@ h2.adf-search-results-label {
fill: var(--theme-primary-color);
}
- .adf-no-content-container {
+ .adf-no-content-container.adf-datatable-cell {
text-align: center;
- border: none !important;
+ border: none;
}
.adf-datatable-cell {
@@ -167,8 +167,8 @@ h2.adf-search-results-label {
}
&-searchLayout {
- .adf-datatable-list .adf-datatable-row {
- min-height: 65px !important;
+ .adf-datatable-list .adf-datatable-body .adf-datatable-row {
+ min-height: 65px;
.adf-datatable-cell {
.adf-name-location-cell-location {
diff --git a/lib/content-services/src/lib/content-user-info/content-user-info.component.scss b/lib/content-services/src/lib/content-user-info/content-user-info.component.scss
index 7b2b78640d..39400f0dfe 100644
--- a/lib/content-services/src/lib/content-user-info/content-user-info.component.scss
+++ b/lib/content-services/src/lib/content-user-info/content-user-info.component.scss
@@ -131,6 +131,13 @@
&-userinfo-detail {
text-align: left;
}
+
+ &-hide-small.adf-userinfo-profile-initials,
+ &-hide-small.adf-userinfo-profile-container {
+ @include layout-bp(lt-md) {
+ display: none;
+ }
+ }
}
@media only screen and (min-device-width: 480px) {
diff --git a/lib/content-services/src/lib/document-list/components/document-list.component.scss b/lib/content-services/src/lib/document-list/components/document-list.component.scss
index ac36c467e2..7581ce55a2 100644
--- a/lib/content-services/src/lib/document-list/components/document-list.component.scss
+++ b/lib/content-services/src/lib/document-list/components/document-list.component.scss
@@ -109,7 +109,7 @@
.adf-empty-list-header {
height: 32px;
- opacity: 0.26 !important;
+ opacity: 0.26;
font-size: var(--theme-headline-font-size);
line-height: 1.33;
letter-spacing: -1px;
@@ -179,8 +179,8 @@
}
.adf-datatable-gallery-thumbnails {
- .adf-datatable-card .adf-datatable-row {
- height: 300px !important;
+ .adf-datatable-card .adf-datatable-row:is(adf-datatable-row) {
+ height: 300px;
img {
height: 130px;
diff --git a/lib/content-services/src/lib/permission-manager/components/user-icon-column/user-icon-column.component.scss b/lib/content-services/src/lib/permission-manager/components/user-icon-column/user-icon-column.component.scss
index 646a62b053..6aab1a2c34 100644
--- a/lib/content-services/src/lib/permission-manager/components/user-icon-column/user-icon-column.component.scss
+++ b/lib/content-services/src/lib/permission-manager/components/user-icon-column/user-icon-column.component.scss
@@ -1,5 +1,5 @@
-.adf {
- &-people-initial {
+.adf-cell-value {
+ .adf-people-initial {
background: var(--theme-primary-color);
border-radius: 50%;
display: flex;
@@ -7,25 +7,32 @@
align-items: center;
width: 40px;
height: 40px;
- color: var(--theme-primary-color-default-contrast) !important;
+ color: var(--theme-primary-color-default-contrast);
font-weight: bolder;
font-size: var(--theme-adf-picture-1-font-size);
text-transform: uppercase;
}
- &-group-icon {
- height: 20px !important;
- width: 20px !important;
+ .adf-group-icon {
+ height: 20px;
+ width: 20px;
background: var(--theme-primary-color);
border-radius: 50%;
padding: 10px;
- color: var(--theme-primary-color-default-contrast) !important;
+ color: var(--theme-primary-color-default-contrast);
font-weight: bolder;
font-size: var(--theme-title-font-size);
}
- &-people-select-icon {
- margin: 0 !important;
+ .adf-datatable-selected {
+ height: 100%;
+ width: 100%;
+ margin-left: -2px;
+ margin-top: 2px;
+ }
+
+ .adf-people-select-icon {
+ margin: 0;
svg {
fill: var(--theme-accent-color);
@@ -33,11 +40,4 @@
height: 40px;
}
}
-
- &-datatable-selected {
- height: 100%;
- width: 100%;
- margin-left: -2px;
- margin-top: 2px;
- }
}
diff --git a/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.html b/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.html
index f4fc8c6c37..9e46b658da 100644
--- a/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.html
+++ b/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.html
@@ -12,6 +12,7 @@
[matTooltip]="getTooltipTranslation(col?.title)">
diff --git a/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.scss b/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.scss
index 37c91336f3..64b19121c7 100644
--- a/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.scss
+++ b/lib/content-services/src/lib/search/components/search-filter-container/search-filter-container.component.scss
@@ -1,20 +1,20 @@
.adf-filter {
- &-button {
- margin-left: -7px !important;
+ &-button:has(.adf-filter-icon) {
+ margin-left: -7px;
.adf-icon {
opacity: 1;
color: var(--adf-theme-foreground-icon-color);
- &-active {
+ &.adf-icon-active {
color: var(--theme-primary-color);
span {
- border: 2px solid var(--adf-theme-background-card-color) !important;
+ border: 2px solid var(--adf-theme-background-card-color);
width: 10px;
height: 10px;
- top: -3px !important;
- right: -6px !important;
+ top: -3px;
+ right: -6px;
}
}
}
@@ -24,7 +24,7 @@
display: flex;
flex-direction: column;
padding: 15px 15px 10px;
- color: var(--adf-theme-foreground-text-color-087) !important;
+ color: var(--adf-theme-foreground-text-color-087);
.adf-facet-buttons {
display: none;
@@ -35,7 +35,7 @@
}
input {
- background: 2px solid var(--adf-theme-background-card-color) !important;
+ background: 2px solid var(--adf-theme-background-card-color);
}
}
diff --git a/lib/content-services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss b/lib/content-services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss
index 11ab6f41ee..2c6f4ad789 100644
--- a/lib/content-services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss
+++ b/lib/content-services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.scss
@@ -5,6 +5,7 @@ adf-search-filter-tabbed {
// The important tag is used here as a workaround for a bug in angular material, when MatTabs are used in conjunction with MatMenu
// https://github.com/angular/components/issues/27426
+ /* stylelint-disable declaration-no-important */
.adf-search-tab-content-active {
& > div {
visibility: visible !important;
diff --git a/lib/content-services/src/lib/social/rating.component.scss b/lib/content-services/src/lib/social/rating.component.scss
index a0ae86c0d2..dba98d712d 100644
--- a/lib/content-services/src/lib/social/rating.component.scss
+++ b/lib/content-services/src/lib/social/rating.component.scss
@@ -32,9 +32,9 @@ $adf-average-star-color: #808080;
color: $adf-rated-star-color;
}
- .adf-grey-star,
- .adf-average-star {
- color: $adf-average-star-color !important;
+ .adf-colored-star.adf-grey-star,
+ .adf-colored-star.adf-average-star {
+ color: $adf-average-star-color;
}
}
diff --git a/lib/content-services/src/lib/tree/components/tree.component.scss b/lib/content-services/src/lib/tree/components/tree.component.scss
index d527d1fdbe..14c3dac323 100644
--- a/lib/content-services/src/lib/tree/components/tree.component.scss
+++ b/lib/content-services/src/lib/tree/components/tree.component.scss
@@ -72,7 +72,7 @@ $tree-header-font-size: 12px !default;
min-width: 100%;
box-sizing: border-box;
- .adf-tree-cell-header {
+ .adf-tree-cell-header:has(.adf-tree-cell-value) {
cursor: pointer;
position: relative;
vertical-align: bottom;
@@ -80,11 +80,11 @@ $tree-header-font-size: 12px !default;
font-weight: bold;
line-height: 24px;
letter-spacing: 0;
- min-height: $tree-row-height !important;
+ min-height: $tree-row-height;
font-size: $tree-header-font-size;
color: var(--adf-theme-foreground-text-color);
box-sizing: border-box;
- padding-top: 12px !important;
+ padding-top: 12px;
&:focus {
outline-offset: -1px;
diff --git a/lib/content-services/src/lib/upload/components/file-uploading-dialog.component.html b/lib/content-services/src/lib/upload/components/file-uploading-dialog.component.html
index 54dc152b49..e7548428be 100644
--- a/lib/content-services/src/lib/upload/components/file-uploading-dialog.component.html
+++ b/lib/content-services/src/lib/upload/components/file-uploading-dialog.component.html
@@ -8,6 +8,7 @@