From edc0945f39a93a0b6a46fddd5572d00decf18a7b Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Thu, 29 Aug 2019 16:35:30 +0100 Subject: [PATCH] fix "ng lint" command (#5012) * update to latest js-api * fix the "ng lint" command * fix linting issues * fix lint issues * lint fixes * code fixes * fix html * fix html * update tests * test fixes * update tests * fix tests and api * fix code --- angular.json | 4 +- .../content-node-selector.component.ts | 4 +- .../extension-presets.component.ts | 2 +- .../app/components/files/files.component.ts | 4 +- .../app/components/form/fake-form.service.ts | 42 +++--- .../lazy-loading/lazy-loading.module.ts | 7 +- .../app/components/login/login.component.html | 2 +- .../app/components/login/login.component.ts | 2 +- .../demo-permissions.component.html | 2 +- .../permissions/demo-permissions.component.ts | 2 +- .../process-service.component.html | 14 +- .../process-service.component.ts | 23 ++- demo-shell/tsconfig.json | 1 + e2e/actions/drop.actions.ts | 4 +- .../comments/comment-component.e2e.ts | 8 +- e2e/pages/adf/commentsPage.ts | 2 +- .../adf/process-services/startProcessPage.ts | 2 +- .../comment-component-processes.e2e.ts | 4 +- .../comment-component-tasks.e2e.ts | 10 +- .../start-process-component.e2e.ts | 2 +- lib/cli/tsconfig.json | 4 +- .../config/content-metadata-config.factory.ts | 3 +- .../config/indifferent-config.service.ts | 12 +- .../content-node-dialog.service.spec.ts | 2 +- .../content-node-dialog.service.ts | 4 +- .../dialogs/library/library.dialog.spec.ts | 20 +-- .../content-action.component.spec.ts | 4 +- .../document-list.component.spec.ts | 6 +- .../data/share-data-row.model.ts | 2 +- .../data/share-datatable-adapter.spec.ts | 8 +- .../services/document-actions.service.spec.ts | 6 +- .../services/document-actions.service.ts | 16 +- .../services/folder-actions.service.ts | 6 +- .../services/node-actions.service.spec.ts | 2 +- .../mock/search.component.mock.ts | 2 +- .../mock/search.service.mock.ts | 2 +- .../inherited-button.directive.spec.ts | 4 +- .../node-permission-dialog.service.spec.ts | 2 +- .../services/node-permission.service.spec.ts | 4 +- .../search-control.component.spec.ts | 4 +- .../components/search-trigger.directive.ts | 4 +- .../components/tree-view.component.spec.ts | 2 +- .../components/tree-view.component.ts | 2 +- .../version-manager.component.ts | 5 +- .../webscript/webscript.component.spec.ts | 10 +- .../webscript/webscript.component.ts | 2 +- .../card-view-dateitem.component.spec.ts | 8 +- .../comments/comment-list.component.spec.ts | 2 +- .../context-menu-holder.component.ts | 4 +- .../datatable/datatable.component.html | 2 +- .../datatable/datatable.component.spec.ts | 36 ++--- .../datatable/datatable.component.ts | 2 +- .../datatable/data/object-datarow.model.ts | 2 +- .../directives/node-delete.directive.spec.ts | 4 +- lib/core/directives/upload.directive.spec.ts | 8 +- lib/core/directives/upload.directive.ts | 4 +- .../components/form-list.component.spec.ts | 2 +- .../form/components/form-list.component.ts | 4 +- .../widgets/content/content.widget.spec.ts | 2 +- .../widgets/core/form.model.spec.ts | 11 +- .../dynamic-table/editors/row.editor.spec.ts | 10 +- .../radio-buttons.widget.spec.ts | 2 +- .../widgets/tabs/tabs.widget.spec.ts | 4 +- lib/core/form/services/form.service.spec.ts | 8 +- lib/core/form/services/node.service.spec.ts | 2 +- .../widget-visibility-cloud.service.spec.ts | 8 +- .../widget-visibility.service.spec.ts | 8 +- .../services/widget-visibility.service.ts | 4 +- lib/core/mock/AlfrescoApi.mock.ts | 2 +- lib/core/mock/identity-group.service.mock.ts | 4 +- lib/core/mock/search.service.mock.ts | 2 +- lib/core/mock/translation.service.mock.ts | 4 +- lib/core/pagination/pagination.component.ts | 2 +- lib/core/pipes/user-initial.pipe.spec.ts | 8 +- lib/core/services/auth-guard-bpm.service.ts | 2 +- lib/core/services/auth-guard-ecm.service.ts | 2 +- .../auth-guard-sso-role.service.spec.ts | 22 +-- .../services/auth-guard-sso-role.service.ts | 4 +- lib/core/services/auth-guard.service.ts | 2 +- .../services/authentication.service.spec.ts | 24 ++- lib/core/services/log.service.spec.ts | 2 +- lib/core/services/renditions.service.spec.ts | 6 +- lib/core/services/shared-links-api.service.ts | 2 +- lib/core/services/translate-loader.service.ts | 2 +- lib/core/services/upload.service.ts | 3 +- .../error-content.component.spec.ts | 4 +- .../components/user-info.component.spec.ts | 8 +- .../services/identity-group.service.spec.ts | 6 +- .../services/identity-user.service.spec.ts | 14 +- .../components/pdfViewer-thumb.component.ts | 5 +- .../pdfViewer-thumbnails.component.spec.ts | 2 +- .../pdfViewer-thumbnails.component.ts | 6 +- .../components/pdfViewer.component.spec.ts | 2 +- .../viewer/components/pdfViewer.component.ts | 2 +- .../components/viewer.component.spec.ts | 60 ++++---- .../viewer/components/viewer.component.ts | 6 +- .../dynamic.component.spec.ts | 3 +- .../analytics-report-list.component.ts | 6 +- ...lytics-report-parameters.component.spec.ts | 2 +- .../analytics-report-parameters.component.ts | 4 +- .../components/analytics.component.ts | 4 +- .../diagram/components/diagram.component.ts | 4 +- .../diagram/components/raphael/polyline.ts | 4 +- .../components/app-list-cloud.component.ts | 2 +- .../apps-process-cloud.service.spec.ts | 2 +- .../components/form-cloud.component.spec.ts | 4 +- .../form/components/form-cloud.component.ts | 12 +- .../content-cloud-node-selector.service.ts | 2 +- .../edit-process-filter-cloud.component.html | 2 +- ...dit-process-filter-cloud.component.spec.ts | 2 +- .../edit-process-filter-cloud.component.ts | 4 +- .../process-filters-cloud.component.spec.ts | 2 +- .../process-list-cloud.service.spec.ts | 4 +- .../local-preference-cloud.service.ts | 8 +- .../user-preference-cloud.service.spec.ts | 10 +- .../directives/claim-task.directive.spec.ts | 10 +- .../task/directives/claim-task.directive.ts | 1 + .../complete-task.directive.spec.ts | 10 +- .../directives/complete-task.directive.ts | 1 + .../task/directives/unclaim-task.directive.ts | 1 + .../directives/unclaim-tast.directive.spec.ts | 10 +- .../task/services/task-cloud.service.spec.ts | 2 +- .../edit-task-filter-cloud.component.html | 2 +- .../edit-task-filter-cloud.component.spec.ts | 2 +- .../edit-task-filter-cloud.component.ts | 15 +- .../task-filters-cloud.component.spec.ts | 2 +- .../task-form-cloud.component.spec.ts | 2 +- .../components/task-header-cloud.component.ts | 3 +- .../services/task-list-cloud.service.spec.ts | 4 +- lib/process-services-cloud/tsconfig.json | 5 +- .../process-attachment-list.component.ts | 2 +- .../task-attachment-list.component.ts | 2 +- .../attach-file-widget-dialog.component.html | 2 +- .../attach-file-widget-dialog.component.ts | 2 +- .../attach-file-widget.component.ts | 2 +- .../form/form.component.spec.ts | 6 +- .../mock/task/tasklist-service.mock.ts | 2 +- .../components/people/people.component.ts | 25 ++-- .../process-audit.directive.spec.ts | 6 +- .../components/process-audit.directive.ts | 4 +- .../process-filters.component.spec.ts | 2 +- .../process-instance-details.component.html | 10 +- .../process-instance-details.component.ts | 2 +- .../process-instance-header.component.spec.ts | 30 ++-- .../process-instance-header.component.ts | 4 +- .../process-instance-tasks.component.html | 4 +- .../process-instance-tasks.component.ts | 2 +- .../components/process-list.component.spec.ts | 2 +- .../components/checklist.component.ts | 4 +- .../components/task-audit.directive.spec.ts | 6 +- .../components/task-audit.directive.ts | 4 +- .../components/task-details.component.spec.ts | 2 +- .../components/task-filters.component.spec.ts | 6 +- .../components/task-header.component.ts | 4 +- .../components/task-list.component.ts | 4 +- .../services/task-filter.service.spec.ts | 2 +- .../src/lib/core/pages/settings.page.ts | 1 + .../actions/testing-app-config.service.ts | 2 +- lib/tsconfig.json | 5 +- package-lock.json | 140 +++++++++--------- package.json | 2 +- tsconfig.json | 1 + 162 files changed, 537 insertions(+), 530 deletions(-) diff --git a/angular.json b/angular.json index 29961bc3a4..b7a15b3fc3 100644 --- a/angular.json +++ b/angular.json @@ -561,7 +561,9 @@ "lint": { "builder": "@angular-devkit/build-angular:tslint", "options": { - "tsConfig": [], + "tsConfig": [ + "./e2e/tsconfig.e2e.json" + ], "exclude": [ "**/node_modules/**/*" ] diff --git a/demo-shell/src/app/components/content-node-selector/content-node-selector.component.ts b/demo-shell/src/app/components/content-node-selector/content-node-selector.component.ts index c24e2321f4..5ce3bbca2d 100644 --- a/demo-shell/src/app/components/content-node-selector/content-node-selector.component.ts +++ b/demo-shell/src/app/components/content-node-selector/content-node-selector.component.ts @@ -18,7 +18,7 @@ import { Component, ViewEncapsulation } from '@angular/core'; import { SitePaging, SiteEntry, MinimalNodeEntryEntity } from '@alfresco/js-api'; import { ContentNodeDialogService, ShareDataRow, RowFilter } from '@alfresco/adf-content-services'; -import { DataRow, DataColumn, ThumbnailService } from '@alfresco/adf-core'; +import { ThumbnailService } from '@alfresco/adf-core'; @Component({ templateUrl: './content-node-selector.component.html', @@ -95,7 +95,7 @@ export class ContentNodeSelectorComponent { return showNode; } - customImageResolverExample(row: DataRow, col: DataColumn) { + customImageResolverExample() { return this.thumbnailService.getMimeTypeIcon('video/quicktime'); } diff --git a/demo-shell/src/app/components/document-list/extension-presets/extension-presets.component.ts b/demo-shell/src/app/components/document-list/extension-presets/extension-presets.component.ts index 027bc0cab9..52b8f8609b 100644 --- a/demo-shell/src/app/components/document-list/extension-presets/extension-presets.component.ts +++ b/demo-shell/src/app/components/document-list/extension-presets/extension-presets.component.ts @@ -55,7 +55,7 @@ export class ExtensionPresetsComponent implements OnInit, OnDestroy { this.onDestroy$.complete(); } - trackById(index: number, obj: { id: string }) { + trackById(_: number, obj: { id: string }) { return obj.id; } } diff --git a/demo-shell/src/app/components/files/files.component.ts b/demo-shell/src/app/components/files/files.component.ts index 731ea24524..63fcc570f3 100644 --- a/demo-shell/src/app/components/files/files.component.ts +++ b/demo-shell/src/app/components/files/files.component.ts @@ -27,7 +27,7 @@ import { MinimalNodeEntity, NodePaging, Pagination, MinimalNodeEntryEntity, Site import { AlfrescoApiService, AuthenticationService, AppConfigService, AppConfigValues, ContentService, TranslationService, FileUploadEvent, FolderCreatedEvent, LogService, NotificationService, - UploadService, DataColumn, DataRow, UserPreferencesService, + UploadService, DataRow, UserPreferencesService, PaginationComponent, FormValues, DisplayMode, InfinitePaginationComponent, HighlightDirective, SharedLinksApiService } from '@alfresco/adf-core'; @@ -474,7 +474,7 @@ export class FilesComponent implements OnInit, OnChanges, OnDestroy { return this.contentService.hasAllowableOperations(selection[0].entry, 'update'); } - getNodeNameTooltip(row: DataRow, col: DataColumn): string { + getNodeNameTooltip(row: DataRow): string { if (row) { return row.getValue('name'); } diff --git a/demo-shell/src/app/components/form/fake-form.service.ts b/demo-shell/src/app/components/form/fake-form.service.ts index eaf1537662..8d10f34b44 100644 --- a/demo-shell/src/app/components/form/fake-form.service.ts +++ b/demo-shell/src/app/components/form/fake-form.service.ts @@ -18,35 +18,43 @@ import { Observable, of } from 'rxjs'; import { Injectable } from '@angular/core'; import { - AppConfigService, AlfrescoApiService, EcmModelService, LogService, FormService, FormOutcomeEvent + AlfrescoApiService, + EcmModelService, + LogService, + FormService, + FormOutcomeEvent } from '@alfresco/adf-core'; import { Subject } from 'rxjs'; @Injectable() export class FakeFormService extends FormService { - executeOutcome = new Subject(); - constructor(appConfig: AppConfigService, - ecmModelService: EcmModelService, - apiService: AlfrescoApiService, - protected logService: LogService) { + constructor( + ecmModelService: EcmModelService, + apiService: AlfrescoApiService, + protected logService: LogService + ) { super(ecmModelService, apiService, logService); } - public getRestFieldValues(taskId: string, fieldId: string): Observable { + public getRestFieldValues( + taskId: string, + fieldId: string + ): Observable { if (fieldId === 'typeaheadField') { return of([ - { 'id': '1', 'name': 'Leanne Graham' }, - { 'id': '2', 'name': 'Ervin Howell' }, - { 'id': '3', 'name': 'Clementine Bauch' }, - { 'id': '4', 'name': 'Patricia Lebsack' }, - { 'id': '5', 'name': 'Chelsey Dietrich' }, - { 'id': '6', 'name': 'Mrs. Dennis Schulist' }, - { 'id': '7', 'name': 'Kurtis Weissnat' }, - { 'id': '8', 'name': 'Nicholas Runolfsdottir V' }, - { 'id': '9', 'name': 'Glenna Reichert' }, - { 'id': '10', 'name': 'Clementina DuBuque' }]); + { id: '1', name: 'Leanne Graham' }, + { id: '2', name: 'Ervin Howell' }, + { id: '3', name: 'Clementine Bauch' }, + { id: '4', name: 'Patricia Lebsack' }, + { id: '5', name: 'Chelsey Dietrich' }, + { id: '6', name: 'Mrs. Dennis Schulist' }, + { id: '7', name: 'Kurtis Weissnat' }, + { id: '8', name: 'Nicholas Runolfsdottir V' }, + { id: '9', name: 'Glenna Reichert' }, + { id: '10', name: 'Clementina DuBuque' } + ]); } else { return super.getRestFieldValues(taskId, fieldId); } diff --git a/demo-shell/src/app/components/lazy-loading/lazy-loading.module.ts b/demo-shell/src/app/components/lazy-loading/lazy-loading.module.ts index 777342f5b7..a6c5174d4e 100644 --- a/demo-shell/src/app/components/lazy-loading/lazy-loading.module.ts +++ b/demo-shell/src/app/components/lazy-loading/lazy-loading.module.ts @@ -16,7 +16,7 @@ */ import { NgModule } from '@angular/core'; -import { CoreModule, TranslationService } from '@alfresco/adf-core'; +import { CoreModule } from '@alfresco/adf-core'; import { LazyLoadingRoutes } from './lazy-loading.routes'; import { LazyLoadingComponent } from './lazy-loading.component'; @@ -30,7 +30,4 @@ import { LazyLoadingComponent } from './lazy-loading.component'; LazyLoadingComponent ] }) -export class LazyLoadingModule { - constructor(translation: TranslationService) { - } -} +export class LazyLoadingModule {} diff --git a/demo-shell/src/app/components/login/login.component.html b/demo-shell/src/app/components/login/login.component.html index dd3b072cdb..9da704e862 100644 --- a/demo-shell/src/app/components/login/login.component.html +++ b/demo-shell/src/app/components/login/login.component.html @@ -85,7 +85,7 @@ [showRememberMe]="showFooter && showRememberMe" (executeSubmit)="checkForm($event)" copyrightText="{{ 'application.copyright' | adfAppConfig }}" - (success)="onLogin($event)" + (success)="onLogin()" (error)="onError($event)">

diff --git a/demo-shell/src/app/components/login/login.component.ts b/demo-shell/src/app/components/login/login.component.ts index 72761e9132..64ed91e770 100644 --- a/demo-shell/src/app/components/login/login.component.ts +++ b/demo-shell/src/app/components/login/login.component.ts @@ -55,7 +55,7 @@ export class LoginComponent implements OnInit { this.alfrescoLogin.addCustomValidationError('password', 'required', 'LOGIN.MESSAGES.PASSWORD-REQUIRED'); } - onLogin($event) { + onLogin() { this.router.navigate(['/home']); } diff --git a/demo-shell/src/app/components/permissions/demo-permissions.component.html b/demo-shell/src/app/components/permissions/demo-permissions.component.html index 3cbb39560f..d008b38f56 100644 --- a/demo-shell/src/app/components/permissions/demo-permissions.component.html +++ b/demo-shell/src/app/components/permissions/demo-permissions.component.html @@ -5,7 +5,7 @@ (error)="showErrorMessage($event)" (updated)="onUpdatedPermissions($event)"> {{ (toggleStatus?'DEMO_PERMISSION.INHERITED_PERMISSIONS_BUTTON':'DEMO_PERMISSION.INHERIT_PERMISSION_BUTTON') | translate}} - +

diff --git a/demo-shell/src/app/components/permissions/demo-permissions.component.ts b/demo-shell/src/app/components/permissions/demo-permissions.component.ts index 321357dc3d..624c09757a 100644 --- a/demo-shell/src/app/components/permissions/demo-permissions.component.ts +++ b/demo-shell/src/app/components/permissions/demo-permissions.component.ts @@ -64,7 +64,7 @@ export class DemoPermissionComponent implements OnInit { this.displayPermissionComponent.reload(); } - openAddPermissionDialog(event: Event) { + openAddPermissionDialog() { this.nodePermissionDialogService .updateNodePermissionByDialog(this.nodeId) .subscribe( diff --git a/demo-shell/src/app/components/process-service/process-service.component.html b/demo-shell/src/app/components/process-service/process-service.component.html index 874e79d026..ee7484db8b 100644 --- a/demo-shell/src/app/components/process-service/process-service.component.html +++ b/demo-shell/src/app/components/process-service/process-service.component.html @@ -28,7 +28,7 @@ [appId]="appId" [showIcon]="showTaskFilterIcon" (filterClick)="onTaskFilterClick($event)" - (success)="onSuccessTaskFilterList($event)" #activitiFilter> + (success)="onSuccessTaskFilterList()" #activitiFilter> @@ -48,7 +48,7 @@ [sort]="taskFilter?.filter?.sort" [landingTaskId]="currentTaskId" (rowClick)="onTaskRowClick($event)" - (success)="onSuccessTaskList($event)" + (success)="onSuccessTaskList()" (row-click)="onRowClick($event)" (row-dblclick)="onTaskRowDblClick($event)" [multiselect]="multiSelectTask" @@ -76,11 +76,11 @@ [taskId]="currentTaskId" [fieldValidators]="fieldValidators" [showHeaderContent]="showHeaderContent" - (formCompleted)="onFormCompleted($event)" + (formCompleted)="onFormCompleted()" (formContentClicked)="onContentClick($event)" (taskCreated)="onTaskCreated($event)" (assignTask)="onAssignTask()" - (taskDeleted)="onTaskDeleted($event)"> + (taskDeleted)="onTaskDeleted()">
@@ -144,7 +144,7 @@ [showIcon]="showProcessFilterIcon" (filterClick)="onProcessFilterChange($event)" (filterSelected)="onProcessFilterChange($event)" - (success)="onSuccessProcessFilterList($event)"> + (success)="onSuccessProcessFilterList()"> @@ -164,7 +164,7 @@ (rowClick)="onProcessRowClick($event)" (row-dblclick)="onProcessRowDblClick($event)" [multiselect]="multiSelectProcess" - (success)="onSuccessProcessList($event)"> + (success)="onSuccessProcessList()">