diff --git a/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.spec.ts index 27e547dc75..cc59fcebcc 100644 --- a/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.spec.ts +++ b/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.spec.ts @@ -424,10 +424,9 @@ describe('ProcessListCloudComponent', () => { done(); }); - - component.ngAfterContentInit(); component.appName = appName.currentValue; - component.reload(); + component.ngOnChanges({ appName }); + fixture.detectChanges(); }); it('should shown columns selector', () => { @@ -759,9 +758,9 @@ describe('ProcessListCloudComponent', () => { done(); }); - component.ngAfterContentInit(); component.appName = appName.currentValue; - component.reload(); + component.ngOnChanges({ appName }); + fixture.detectChanges(); }); it('should shown columns selector', () => { @@ -955,30 +954,6 @@ describe('ProcessListCloudComponent', () => { component.resetPagination(); }); }); - - it('should call loadPreferencesAndInitialize when appName changes', () => { - spyOn(preferencesService, 'getPreferences').and.returnValue(of({})); - - spyOn(processListCloudService, 'fetchProcessList').and.returnValue(of(fakeProcessCloudList)); - spyOn(component as any, 'createDatatableSchema'); - spyOn(component as any, 'createColumns'); - - const appName = new SimpleChange('old-app-name', 'new-app-name', false); - component.ngOnChanges({ appName }); - - expect(preferencesService.getPreferences).toHaveBeenCalledWith('new-app-name'); - expect((component as any).createDatatableSchema).toHaveBeenCalled(); - expect((component as any).createColumns).toHaveBeenCalled(); - }); - - it('should not call loadPreferencesAndInitialize when appName does not change', () => { - spyOn(preferencesService, 'getPreferences'); - - const status = new SimpleChange('old-status', 'new-status', false); - component.ngOnChanges({ status }); - - expect(preferencesService.getPreferences).not.toHaveBeenCalled(); - }); }); }); diff --git a/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.ts b/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.ts index e74f0894f8..67595a64ae 100644 --- a/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.ts +++ b/lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.ts @@ -397,12 +397,8 @@ export class ProcessListCloudComponent } ngAfterContentInit() { - this.loadPreferencesAndInitialize(this.appName); - } - - private loadPreferencesAndInitialize(appName: string): void { this.cloudPreferenceService - .getPreferences(appName) + .getPreferences(this.appName) .pipe( take(1), map((preferences) => { @@ -445,19 +441,13 @@ export class ProcessListCloudComponent } this.createDatatableSchema(); - this.createColumns(); }); } - ngOnChanges(changes: SimpleChanges) { if (this.isPropertyChanged(changes, 'sorting')) { this.formatSorting(changes['sorting'].currentValue); } - if (changes['appName']) { - this.loadPreferencesAndInitialize(changes['appName'].currentValue); - } - if (this.isAnyPropertyChanged(changes)) { this.reload(); }