inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-4973] CLONE - Header - sidenav menu button expanded/collapsed state not exposed via ARIA (#5179)

Browse Source 
* Set aria expanded for the sidenav toggle bar

* Define initialSidenavExpanded which can be set in the demo shell than as taken the same true or false value as the sideNav.expandedSidenav value.

* Added some unit tests for the sidenav toggle aria-expanded behaviour

* Update lib/core/layout/components/header/header.component.ts

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update lib/core/layout/components/header/header.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update demo-shell/src/app/components/app-layout/app-layout.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update lib/core/layout/components/header/header.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav
This commit is contained in:
Martin Muller
2019-10-24 23:54:32 +02:00
committed by Eugenio Romano
parent 6331979baa
commit ef229dd300
4 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/layout/components/header/header.component.html
View File

@@ -10,6 +10,7 @@
class="mat-icon-button adf-menu-icon"
mat-icon-button
(click)="toggleMenu()"
[attr.aria-expanded]="expandedSidenav"
[attr.aria-label]="'CORE.HEADER.ACCESSIBILITY.SIDEBAR_TOGGLE_BUTTON_ARIA_LABEL' | translate">
<mat-icon
class="mat-icon material-icon"
@@ -43,6 +44,7 @@
class="mat-icon-button adf-menu-icon"
mat-icon-button
(click)="toggleMenu()"
[attr.aria-expanded]="expandedSidenav"
[attr.aria-label]="'CORE.HEADER.ACCESSIBILITY.SIDEBAR_TOGGLE_BUTTON_ARIA_LABEL' | translate">
>
<mat-icon

36
lib/core/layout/components/header/header.component.spec.ts
View File

@@ -122,6 +122,42 @@ describe('HeaderLayoutComponent', () => {
expect(button === null).toBeTruthy();
});
it('if expandedSidenav is false aria expanded should be false too', () => {
component.expandedSidenav = false;
fixture.detectChanges();
const nodeAttributes = fixture.debugElement.nativeElement.querySelector('#adf-sidebar-toggle-start').attributes as NamedNodeMap;
expect(nodeAttributes.getNamedItem('aria-expanded').value).toEqual('false');
});
it('if expandedSidenav is true aria expanded should be true too', () => {
component.expandedSidenav = true;
fixture.detectChanges();
const nodeAttributes = fixture.debugElement.nativeElement.querySelector('#adf-sidebar-toggle-start').attributes as NamedNodeMap;
expect(nodeAttributes.getNamedItem('aria-expanded').value).toEqual('true');
});
it('if expandedSidenav is false than we click on the sidenav button aria expanded should be true and if click again it should be false', () => {
component.expandedSidenav = false;
fixture.detectChanges();
const button = fixture.nativeElement.querySelector('#adf-sidebar-toggle-start');
button.click();
fixture.detectChanges();
const nodeAttributes = button.attributes as NamedNodeMap;
expect(nodeAttributes.getNamedItem('aria-expanded').value).toEqual('true');
button.click();
fixture.detectChanges();
const nodeAttributes2 = button.attributes as NamedNodeMap;
expect(nodeAttributes2.getNamedItem('aria-expanded').value).toEqual('false');
});
it('if position is end the button menu should be at the end', () => {
component.position = 'end';
fixture.detectChanges();

5
lib/core/layout/components/header/header.component.ts
View File

@@ -49,13 +49,16 @@ export class HeaderLayoutComponent implements OnInit {
@Input() showSidenavToggle: boolean = true;
/** Emitted when the sidenav button is clicked. */
@Output() clicked = new EventEmitter<any>();
@Output() clicked = new EventEmitter<boolean>();
@Input() expandedSidenav: boolean = true;
/** The side of the page that the drawer is attached to (can be 'start' or 'end') */
@Input() position = 'start';
toggleMenu() {
this.clicked.emit(true);
this.expandedSidenav = !this.expandedSidenav;
}
ngOnInit() {