From f07636e297671d16ea9a072780a9090b7f8c2b2c Mon Sep 17 00:00:00 2001 From: MichalKinas <113341662+MichalKinas@users.noreply.github.com> Date: Mon, 4 Nov 2024 10:58:24 +0100 Subject: [PATCH] [ACS-8956] Introduce new ESLint rule for self-closing tags (#10354) --- .eslintrc.js | 5 +- lib/cli/.eslintrc.json | 2 +- lib/content-services/.eslintrc.json | 4 +- .../aspect-list-dialog.component.html | 3 +- .../aspect-list/aspect-list.component.html | 2 +- .../categories-management.component.html | 3 +- .../common/services/saved-searches.service.ts | 28 +- .../content-metadata-card.component.html | 3 +- .../content-metadata.component.html | 19 +- ...content-node-selector-panel.component.html | 20 +- .../content-node-selector.component.html | 14 +- .../content-node-share.dialog.html | 12 +- .../category-selector.dialog.html | 3 +- .../download-zip/download-zip.dialog.html | 2 +- .../dialogs/node-lock/node-lock.dialog.html | 4 +- .../components/document-list.component.html | 9 +- .../filter-header.component.html | 3 +- .../new-version-uploader.dialog.html | 7 +- .../node-comments.component.html | 3 +- .../add-permission-dialog.component.html | 12 +- .../add-permission-panel.component.html | 4 +- .../add-permission.component.html | 2 +- .../permission-container.component.html | 15 +- .../permission-list.component.html | 11 +- .../user-icon-column.component.ts | 2 +- .../search-chip-list.component.spec.ts | 2 +- .../components/search-control.component.html | 2 +- .../search-date-range-tabbed.component.html | 3 +- .../search-date-range.component.html | 4 +- .../search-datetime-range.component.html | 8 +- ...h-filter-autocomplete-chips.component.html | 3 +- .../search-facet-chip-tabbed.component.html | 3 +- ...search-facet-tabbed-content.component.html | 3 +- .../search-facet-chip.component.html | 2 +- .../search-filter-chips.component.html | 7 +- .../search-filter-menu-card.component.html | 4 +- .../search-widget-chip.component.html | 3 +- .../search-filter-container.component.html | 6 +- .../search-filter-tabbed.component.html | 2 +- .../search-filter-card.component.html | 3 +- .../search-filter.component.html | 7 +- .../search-panel/search-panel.component.html | 3 +- .../search-properties.component.html | 3 +- .../search-sorting-picker.component.html | 3 +- .../tag-node-list.component.html | 3 +- .../tags-creator/tags-creator.component.html | 3 +- .../lib/tree/components/tree.component.html | 19 +- .../file-uploading-dialog.component.html | 3 +- .../file-uploading-list-row.component.html | 2 +- .../version-list.component.html | 2 +- .../version-manager.component.html | 8 +- .../version-upload.component.html | 3 +- lib/core/.eslintrc.json | 4 +- .../breadcrumb/breadcrumb.component.html | 2 +- .../lib/components/feature-flags-wrapper.ts | 2 +- .../lib/components/flags/flags.component.html | 15 +- .../lib/components/shell/shell.component.html | 13 +- .../about-extension-list.component.html | 4 +- .../about-license-list.component.html | 6 +- .../module-list.component.html | 4 +- .../about-package/package-list.component.html | 4 +- .../about-repository-info.component.html | 6 +- .../about-status-list.component.html | 4 +- lib/core/src/lib/about/about.component.html | 2 +- lib/core/src/lib/button/button.component.html | 14 +- .../card-view-dateitem.component.html | 12 +- ...card-view-keyvaluepairsitem.component.html | 4 +- .../card-view-selectitem.component.html | 2 +- .../card-view/card-view.component.html | 3 +- .../src/lib/comments/comments.component.html | 3 +- .../columns-selector.component.html | 4 +- .../datatable/datatable.component.html | 39 +- .../lib/dialogs/dialog/dialog.component.html | 6 +- .../components/form-renderer.component.html | 10 +- .../widgets/amount/amount.widget.html | 4 +- .../base-viewer/base-viewer.widget.html | 4 +- .../widgets/checkbox/checkbox.widget.html | 4 +- .../widgets/date-time/date-time.widget.html | 8 +- .../components/widgets/date/date.widget.html | 7 +- .../widgets/decimal/decimal.component.html | 5 +- .../multiline-text/multiline-text.widget.html | 5 +- .../widgets/number/number.widget.html | 4 +- .../components/widgets/text/text.widget.html | 4 +- lib/core/src/lib/header/header.component.html | 12 +- .../lib/header/navbar/navbar.component.html | 3 +- lib/core/src/lib/icon/icon.component.html | 2 +- .../info-drawer/info-drawer.component.html | 4 +- .../info-drawer/info-drawer.component.spec.ts | 8 +- .../language-picker.component.ts | 2 +- .../sidenav-layout.component.html | 8 +- .../login-dialog/login-dialog.component.html | 3 +- .../lib/login/components/login.component.html | 3 +- .../components/login/login.component.html | 3 +- .../notification-history.component.html | 4 +- .../infinite-pagination.component.html | 2 +- .../src/lib/progress/progress.component.html | 6 +- .../empty-content.component.html | 2 +- .../pdf-viewer-thumbnails.component.html | 3 +- .../pdf-viewer/pdf-viewer.component.html | 9 +- .../pdf-viewer/pdf-viewer.component.spec.ts | 6 +- .../viewer-render.component.html | 21 +- .../viewer-render.component.spec.ts | 4 +- .../viewer/components/viewer.component.html | 15 +- .../dynamic-column.component.ts | 2 +- .../analytics-generator.component.html | 2 +- .../analytics-report-heat-map.component.html | 4 +- ...analytics-report-parameters.component.html | 22 +- .../components/analytics.component.html | 6 +- .../buttons-menu.component.spec.ts | 2 +- .../widgets/date-range/date-range.widget.html | 8 +- .../widgets/duration/duration.widget.html | 2 +- ...agram-alfresco-publish-task.component.html | 4 +- .../diagram-box-publish-task.component.html | 4 +- .../diagram-business-rule-task.component.html | 4 +- .../diagram-camel-task.component.html | 4 +- ...gram-container-service-task.component.html | 16 +- ...m-google-drive-publish-task.component.html | 4 +- .../diagram-manual-task.component.html | 4 +- .../diagram-mule-task.component.html | 4 +- .../diagram-receive-task.component.html | 4 +- .../diagram-rest-call-task.component.html | 4 +- .../diagram-script-task.component.html | 4 +- .../diagram-send-task.component.html | 4 +- .../diagram-service-task.component.html | 4 +- .../activities/diagram-task.component.html | 6 +- .../diagram-user-task.component.html | 4 +- .../diagram-boundary-event.component.html | 8 +- .../diagram-throw-event.component.html | 8 +- .../diagram-sequence-flow.component.html | 4 +- .../diagram/components/diagram.component.html | 38 +- .../events/diagram-end-event.component.html | 2 +- .../events/diagram-event.component.html | 6 +- .../events/diagram-start-event.component.html | 2 +- .../diagram-event-gateway.component.html | 8 +- .../diagram-exclusive-gateway.component.html | 4 +- .../gateways/diagram-gateway.component.html | 4 +- .../diagram-inclusive-gateway.component.html | 4 +- .../diagram-parallel-gateway.component.html | 4 +- ...iagram-container-icon-event.component.html | 8 +- ...-icon-alfresco-publish-task.component.html | 2 +- ...agram-icon-box-publish-task.component.html | 2 +- ...ram-icon-business-rule-task.component.html | 2 +- .../diagram-icon-camel-task.component.html | 2 +- .../icons/diagram-icon-error.component.html | 2 +- ...n-google-drive-publish-task.component.html | 2 +- .../diagram-icon-manual-task.component.html | 2 +- .../icons/diagram-icon-message.component.html | 2 +- .../diagram-icon-mule-task.component.html | 2 +- .../diagram-icon-receive-task.component.html | 2 +- ...diagram-icon-rest-call-task.component.html | 2 +- .../diagram-icon-script-task.component.html | 2 +- .../diagram-icon-send-task.component.html | 4 +- .../diagram-icon-service-task.component.html | 2 +- .../icons/diagram-icon-signal.component.html | 2 +- .../icons/diagram-icon-timer.component.html | 6 +- .../diagram-icon-user-task.component.html | 2 +- ...intermediate-catching-event.component.html | 8 +- .../diagram-event-subprocess.component.html | 4 +- .../diagram-subprocess.component.html | 4 +- .../swimlanes/diagram-lane.component.html | 4 +- .../swimlanes/diagram-lanes.component.html | 2 +- .../swimlanes/diagram-pool.component.html | 4 +- .../swimlanes/diagram-pools.component.html | 4 +- .../tooltip/diagram-tooltip.component.spec.ts | 2 +- lib/process-services-cloud/.eslintrc.json | 4 +- .../components/app-list-cloud.component.html | 11 +- .../date-range-filter.component.html | 4 +- .../form/components/form-cloud.component.html | 5 +- .../spinner/form-spinner.component.html | 2 +- .../attach-file-cloud-widget.component.html | 6 +- .../attach-file/upload-cloud.widget.html | 4 +- .../widgets/data-table/data-table.widget.html | 6 +- .../widgets/date/date-cloud.widget.html | 7 +- .../display-external-property.widget.html | 2 +- .../dropdown/dropdown-cloud.widget.html | 8 +- .../file-viewer/file-viewer.widget.html | 4 +- .../widgets/group/group-cloud.widget.html | 4 +- .../widgets/people/people-cloud.widget.html | 4 +- .../properties-viewer-wrapper.component.html | 5 +- .../properties-viewer.widget.html | 5 +- .../radio-buttons-cloud.widget.html | 2 +- .../components/group-cloud.component.html | 2 +- .../components/people-cloud.component.html | 3 +- .../edit-process-filter-cloud.component.html | 12 +- .../process-filters-cloud.component.html | 5 +- .../process-filters-cloud.component.ts | 1 + .../process-header-cloud.component.html | 2 +- .../process-list-cloud.component.html | 9 +- .../process-list-cloud.component.spec.ts | 4 +- .../start-process-cloud.component.html | 3 +- .../start-process-cloud.component.spec.ts | 1 + .../start-task-cloud.component.html | 13 +- .../base-task-filters-cloud.component.html | 4 +- ...base-edit-task-filter-cloud.component.html | 19 +- .../task-assignment-filter.component.html | 6 +- .../components/task-form-cloud.component.html | 5 +- .../task-header-cloud.component.html | 5 +- .../base-task-list-cloud.component.html | 9 +- .../service-task-list-cloud.component.spec.ts | 13 +- .../task-list-cloud.component.spec.ts | 14 +- lib/process-services/.eslintrc.json | 4 +- .../src/lib/app-list/apps-list.component.html | 5 +- .../process-attachment-list.component.html | 9 +- .../task-attachment-list.component.html | 9 +- .../form/form-list/form-list.component.html | 6 +- .../src/lib/form/form.component.html | 3 +- .../form/start-form/start-form.component.html | 3 +- .../attach-file-widget-dialog.component.html | 6 +- .../attach-file-widget.component.html | 8 +- .../attach-folder-widget.component.html | 4 +- .../widgets/document/document.widget.html | 2 +- .../widgets/dropdown/dropdown.widget.html | 2 +- .../dynamic-table/dynamic-table.widget.html | 8 +- .../editors/date/date.editor.html | 4 +- .../editors/datetime/datetime.editor.html | 6 +- .../editors/dropdown/dropdown.editor.html | 2 +- .../editors/row-editor/row.editor.html | 20 +- .../file-viewer/file-viewer.widget.html | 4 +- .../functional-group.widget.html | 4 +- .../form/widgets/people/people.widget.html | 4 +- .../radio-buttons/radio-buttons.widget.html | 2 +- .../widgets/typeahead/typeahead.widget.html | 4 +- .../form/widgets/upload/upload.widget.html | 4 +- .../people-list/people-list.component.html | 3 +- .../people-search.component.html | 2 +- .../people-selector.component.html | 3 +- .../components/people/people.component.html | 3 +- .../process-comments.component.html | 3 +- .../services/comment-process.service.ts | 21 +- .../process-filters.component.html | 2 +- .../process-instance-details.component.html | 9 +- .../process-instance-header.component.html | 2 +- .../process-instance-tasks.component.html | 3 +- .../process-list/process-list.component.html | 6 +- .../process-list.component.spec.ts | 8 +- .../start-process.component.html | 17 +- .../task-comments.component.html | 3 +- .../attach-form/attach-form.component.html | 3 +- .../start-task/start-task.component.html | 7 +- .../task-details/task-details.component.html | 21 +- .../task-filters/task-filters.component.html | 2 +- .../task-form/task-form.component.html | 11 +- .../task-header/task-header.component.html | 2 +- .../task-list/task-list.component.html | 6 +- .../task-list/task-list.component.spec.ts | 8 +- package-lock.json | 654 +++--------------- package.json | 6 +- 247 files changed, 710 insertions(+), 1359 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 43d58afa64..9c79fa58a3 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -185,7 +185,10 @@ module.exports = { { files: ['*.html'], extends: ['plugin:@angular-eslint/template/recommended', 'plugin:@angular-eslint/template/accessibility'], - rules: {} + parser: '@angular-eslint/template-parser', + rules: { + '@angular-eslint/template/prefer-self-closing-tags': 'error' + } }, { files: ['*.spec.ts'], diff --git a/lib/cli/.eslintrc.json b/lib/cli/.eslintrc.json index 501e944e75..ff4c376670 100644 --- a/lib/cli/.eslintrc.json +++ b/lib/cli/.eslintrc.json @@ -13,7 +13,7 @@ "prefer-arrow/prefer-arrow-functions": "off", "@typescript-eslint/no-var-requires": "off", "@typescript-eslint/naming-convention": "warn", - "quote-props": "warn", + "quote-props": "off", "no-shadow": "warn", "no-restricted-syntax": "off", "no-underscore-dangle": "off", diff --git a/lib/content-services/.eslintrc.json b/lib/content-services/.eslintrc.json index e75d22748d..a4408fe1e6 100644 --- a/lib/content-services/.eslintrc.json +++ b/lib/content-services/.eslintrc.json @@ -22,12 +22,12 @@ } ], "no-shadow": "warn", - "quote-props": "warn", + "quote-props": "off", "object-shorthand": "warn", "prefer-const": "warn", "arrow-body-style": "warn", "@angular-eslint/no-output-native": "off", - "space-before-function-paren": "warn", + "space-before-function-paren": "off", "@angular-eslint/component-selector": [ "error", { diff --git a/lib/content-services/src/lib/aspect-list/aspect-list-dialog.component.html b/lib/content-services/src/lib/aspect-list/aspect-list-dialog.component.html index 3cf8a035c5..fa908d4a90 100644 --- a/lib/content-services/src/lib/aspect-list/aspect-list-dialog.component.html +++ b/lib/content-services/src/lib/aspect-list/aspect-list-dialog.component.html @@ -9,8 +9,7 @@ {{'ADF-ASPECT-LIST.DIALOG.SELECTED' | translate}}