[ACS-5645] metadata fixes for encapsulation and host classes (#9018)

* remove useless typing

* fix missing host classes and encapsulation
This commit is contained in:
Denys Vuika
2023-10-24 17:11:28 +01:00
committed by GitHub
parent 879c5a6d2c
commit f366cf7c0a
4 changed files with 10 additions and 10 deletions

View File

@@ -18,7 +18,6 @@
import { Input, OnDestroy, Directive, inject } from '@angular/core';
import { CardViewUpdateService } from '../services/card-view-update.service';
import { CardViewItem } from '../interfaces/card-view.interfaces';
import { CardViewBaseItemModel } from '../models/card-view-baseitem.model';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
@@ -33,9 +32,7 @@ export abstract class BaseCardView<T extends CardViewItem> implements OnDestroy
protected destroy$ = new Subject<boolean>();
constructor() {
this.cardViewUpdateService.updateItem$
.pipe(takeUntil(this.destroy$))
.subscribe((itemModel: CardViewBaseItemModel) => {
this.cardViewUpdateService.updateItem$.pipe(takeUntil(this.destroy$)).subscribe((itemModel) => {
if (this.property.key === itemModel.key) {
this.property.value = itemModel.value;
}
@@ -46,5 +43,4 @@ export abstract class BaseCardView<T extends CardViewItem> implements OnDestroy
this.destroy$.next(true);
this.destroy$.complete();
}
}

View File

@@ -22,10 +22,11 @@ import { MatTableDataSource } from '@angular/material/table';
import { BaseCardView } from '../base-card-view';
@Component({
selector: 'adf-card-view-keyvaluepairsitem',
selector: 'adf-card-view-key-value-pairs-item',
templateUrl: './card-view-keyvaluepairsitem.component.html',
styleUrls: ['./card-view-keyvaluepairsitem.component.scss'],
encapsulation: ViewEncapsulation.None
encapsulation: ViewEncapsulation.None,
host: { class: 'adf-card-view-key-value-pairs-item' }
})
export class CardViewKeyValuePairsItemComponent extends BaseCardView<CardViewKeyValuePairsItemModel> implements OnChanges {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Component, Input, OnChanges, OnDestroy, OnInit, inject } from '@angular/core';
import { Component, Input, OnChanges, OnDestroy, OnInit, inject, ViewEncapsulation } from '@angular/core';
import { CardViewSelectItemModel } from '../../models/card-view-selectitem.model';
import { BehaviorSubject, combineLatest, Observable, Subject } from 'rxjs';
import { CardViewSelectItemOption } from '../../interfaces/card-view.interfaces';
@@ -27,7 +27,9 @@ import { takeUntil, map } from 'rxjs/operators';
@Component({
selector: 'adf-card-view-selectitem',
templateUrl: './card-view-selectitem.component.html',
styleUrls: ['./card-view-selectitem.component.scss']
styleUrls: ['./card-view-selectitem.component.scss'],
encapsulation: ViewEncapsulation.None,
host: { class: 'adf-card-view-selectitem' }
})
export class CardViewSelectItemComponent extends BaseCardView<CardViewSelectItemModel<string | number>> implements OnInit, OnChanges, OnDestroy {
private appConfig = inject(AppConfigService);

View File

@@ -39,7 +39,8 @@ const templateTypes = {
selector: 'adf-card-view-textitem',
templateUrl: './card-view-textitem.component.html',
styleUrls: ['./card-view-textitem.component.scss'],
encapsulation: ViewEncapsulation.None
encapsulation: ViewEncapsulation.None,
host: { class: 'adf-card-view-textitem' }
})
export class CardViewTextItemComponent extends BaseCardView<CardViewTextItemModel> implements OnChanges, OnDestroy {
@Input()