From f3e5dfecec38f9af343843f7579f6abcc213d1e1 Mon Sep 17 00:00:00 2001 From: dhrn <14145706+dhrn@users.noreply.github.com> Date: Mon, 30 Nov 2020 17:44:29 +0530 Subject: [PATCH] * fixed the version-compatibility.directive (#6391) --- lib/core/directives/version-compatibility.directive.spec.ts | 5 ++--- lib/core/directives/version-compatibility.directive.ts | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/core/directives/version-compatibility.directive.spec.ts b/lib/core/directives/version-compatibility.directive.spec.ts index 7697e72db9..120c973a1d 100644 --- a/lib/core/directives/version-compatibility.directive.spec.ts +++ b/lib/core/directives/version-compatibility.directive.spec.ts @@ -21,7 +21,7 @@ import { TranslateModule } from '@ngx-translate/core'; import { TestBed, ComponentFixture } from '@angular/core/testing'; import { setupTestBed } from '../testing/setup-test-bed'; import { CoreTestingModule } from '../testing/core.testing.module'; -import { VersionCompatibilityService } from '@alfresco/adf-core'; +import { VersionCompatibilityService } from '../services/version-compatibility.service'; @Component({ template: ` @@ -63,8 +63,7 @@ describe('VersionCompatibilityDirective', () => { TranslateModule.forRoot(), CoreTestingModule ], - declarations: [TestComponent - ] + declarations: [TestComponent] }); beforeEach(() => { diff --git a/lib/core/directives/version-compatibility.directive.ts b/lib/core/directives/version-compatibility.directive.ts index 3b6e3d4039..3d7cfd0a77 100644 --- a/lib/core/directives/version-compatibility.directive.ts +++ b/lib/core/directives/version-compatibility.directive.ts @@ -17,6 +17,7 @@ import { Directive, Input, ViewContainerRef, TemplateRef } from '@angular/core'; import { VersionCompatibilityService } from '../services/version-compatibility.service'; +import { take } from 'rxjs/operators'; @Directive({ selector: '[adf-acs-version]' @@ -37,11 +38,10 @@ export class VersionCompatibilityDirective { } private validateAcsVersion(requiredVersion: string) { - this.versionCompatibilityService.acsVersionInitialized$.subscribe(() => { + this.versionCompatibilityService.acsVersionInitialized$.pipe(take(1)).subscribe(() => { + this.viewContainer.clear(); if (requiredVersion && this.versionCompatibilityService.isVersionSupported(requiredVersion)) { this.viewContainer.createEmbeddedView(this.templateRef); - } else { - this.viewContainer.clear(); } }); }