ESLint: cleanup await expect from protractor tests (#9630)

This commit is contained in:
Denys Vuika
2024-04-30 08:07:10 -04:00
committed by GitHub
parent 4109f272ea
commit f401b8c13e
114 changed files with 2096 additions and 1908 deletions

View File

@@ -15,7 +15,19 @@
* limitations under the License.
*/
import { createApiService, AppListCloudPage, GroupIdentityService, IdentityService, LoginPage, ProcessDefinitionsService, ProcessHeaderCloudPage, ProcessInstancesService, QueryService, StringUtil, LocalStorageUtil } from '@alfresco/adf-testing';
import {
createApiService,
AppListCloudPage,
GroupIdentityService,
IdentityService,
LoginPage,
ProcessDefinitionsService,
ProcessHeaderCloudPage,
ProcessInstancesService,
QueryService,
StringUtil,
LocalStorageUtil
} from '@alfresco/adf-testing';
import { browser } from 'protractor';
import { ProcessCloudDemoPage } from './../pages/process-cloud-demo.page';
import { TasksCloudDemoPage } from './../pages/tasks-cloud-demo.page';
@@ -25,7 +37,6 @@ import { EditProcessFilterConfiguration } from './../config/edit-process-filter.
import { DateFnsUtils } from '../../../lib/core/src/lib/common/utils/date-fns-utils';
describe('Process Header cloud component', () => {
describe('Process Header cloud component', () => {
const simpleApp = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.name;
const subProcessApp = browser.params.resources.ACTIVITI_CLOUD_APPS.SUB_PROCESS_APP.name;
@@ -55,34 +66,45 @@ describe('Process Header cloud component', () => {
const processInstancesService = new ProcessInstancesService(apiService);
const queryService = new QueryService(apiService);
let testUser; let groupInfo;
let testUser;
let groupInfo;
let runningProcess; let runningCreatedDate; let parentCompleteProcess; let childCompleteProcess; let completedCreatedDate;
let runningProcess;
let runningCreatedDate;
let parentCompleteProcess;
let childCompleteProcess;
let completedCreatedDate;
const PROCESSES = CONSTANTS.PROCESS_FILTERS;
beforeAll(async () => {
await apiService.loginWithProfile('identityAdmin');
testUser = await identityService.createIdentityUserWithRole( [identityService.ROLES.ACTIVITI_USER]);
testUser = await identityService.createIdentityUserWithRole([identityService.ROLES.ACTIVITI_USER]);
groupInfo = await groupIdentityService.getGroupInfoByGroupName('hr');
await identityService.addUserToGroup(testUser.idIdentityService, groupInfo.id);
await apiService.login(testUser.username, testUser.password);
const simpleProcess = await processDefinitionService.getProcessDefinitionByName(browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.processes.simpleProcess, simpleApp);
const simpleProcess = await processDefinitionService.getProcessDefinitionByName(
browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.processes.simpleProcess,
simpleApp
);
const processparent = await processDefinitionService.getProcessDefinitionByName(browser.params.resources.ACTIVITI_CLOUD_APPS.SUB_PROCESS_APP.processes.processparent, subProcessApp);
const processparent = await processDefinitionService.getProcessDefinitionByName(
browser.params.resources.ACTIVITI_CLOUD_APPS.SUB_PROCESS_APP.processes.processparent,
subProcessApp
);
runningProcess = await processInstancesService.createProcessInstance(simpleProcess.entry.key,
simpleApp, { name: StringUtil.generateRandomString(), businessKey: 'test' });
runningProcess = await processInstancesService.createProcessInstance(simpleProcess.entry.key, simpleApp, {
name: StringUtil.generateRandomString(),
businessKey: 'test'
});
runningCreatedDate = DateFnsUtils.formatDate(new Date(runningProcess.entry.startDate), formatDate);
parentCompleteProcess = await processInstancesService.createProcessInstance(processparent.entry.key,
subProcessApp);
parentCompleteProcess = await processInstancesService.createProcessInstance(processparent.entry.key, subProcessApp);
const parentProcessInstance = await queryService.getProcessInstanceSubProcesses(parentCompleteProcess.entry.id,
subProcessApp);
const parentProcessInstance = await queryService.getProcessInstanceSubProcesses(parentCompleteProcess.entry.id, subProcessApp);
childCompleteProcess = parentProcessInstance.list.entries[0];
@@ -108,21 +130,21 @@ describe('Process Header cloud component', () => {
await processFilter.clickOnProcessFilters();
await processFilter.clickRunningProcessesFilter();
await expect(await processFilter.getActiveFilterName()).toBe(PROCESSES.RUNNING);
expect(await processFilter.getActiveFilterName()).toBe(PROCESSES.RUNNING);
await editProcessFilter.setFilter({ processName: runningProcess.entry.name });
await processList.getDataTable().waitTillContentLoaded();
await processList.checkContentIsDisplayedByName(runningProcess.entry.name);
await processList.selectRow(runningProcess.entry.name);
await expect(await processHeaderCloudPage.getId()).toEqual(runningProcess.entry.id);
await expect(await processHeaderCloudPage.getName()).toEqual(runningProcess.entry.name);
await expect(await processHeaderCloudPage.getStatus()).toEqual('RUNNING');
await expect(await processHeaderCloudPage.getInitiator()).toEqual(runningProcess.entry.initiator);
await expect(await processHeaderCloudPage.getStartDate()).toEqual(runningCreatedDate);
await expect(await processHeaderCloudPage.getParentId()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_PARENT);
await expect(await processHeaderCloudPage.getBusinessKey()).toEqual(runningProcess.entry.businessKey);
await expect(await processHeaderCloudPage.getLastModified()).toEqual(runningCreatedDate);
expect(await processHeaderCloudPage.getId()).toEqual(runningProcess.entry.id);
expect(await processHeaderCloudPage.getName()).toEqual(runningProcess.entry.name);
expect(await processHeaderCloudPage.getStatus()).toEqual('RUNNING');
expect(await processHeaderCloudPage.getInitiator()).toEqual(runningProcess.entry.initiator);
expect(await processHeaderCloudPage.getStartDate()).toEqual(runningCreatedDate);
expect(await processHeaderCloudPage.getParentId()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_PARENT);
expect(await processHeaderCloudPage.getBusinessKey()).toEqual(runningProcess.entry.businessKey);
expect(await processHeaderCloudPage.getLastModified()).toEqual(runningCreatedDate);
});
it('[C305008] Should display process details for completed process', async () => {
@@ -131,7 +153,7 @@ describe('Process Header cloud component', () => {
await processFilter.clickOnProcessFilters();
await processFilter.clickCompletedProcessesFilter();
await expect(await processFilter.getActiveFilterName()).toBe(PROCESSES.COMPLETED);
expect(await processFilter.getActiveFilterName()).toBe(PROCESSES.COMPLETED);
await editProcessFilter.setFilter({ initiator: `${testUser.firstName} ${testUser.lastName}` });
await processList.getDataTable().waitTillContentLoaded();
@@ -140,14 +162,14 @@ describe('Process Header cloud component', () => {
await processList.checkProcessListIsLoaded();
await processList.selectRowById(childCompleteProcess.entry.id);
await expect(await processHeaderCloudPage.getId()).toEqual(childCompleteProcess.entry.id);
await expect(await processHeaderCloudPage.getName()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_NAME);
await expect(await processHeaderCloudPage.getStatus()).toEqual('COMPLETED');
await expect(await processHeaderCloudPage.getInitiator()).toEqual(childCompleteProcess.entry.initiator);
await expect(await processHeaderCloudPage.getStartDate()).toEqual(completedCreatedDate);
await expect(await processHeaderCloudPage.getParentId()).toEqual(childCompleteProcess.entry.parentId);
await expect(await processHeaderCloudPage.getBusinessKey()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_BUSINESS_KEY);
await expect(await processHeaderCloudPage.getLastModified()).toEqual(completedCreatedDate);
expect(await processHeaderCloudPage.getId()).toEqual(childCompleteProcess.entry.id);
expect(await processHeaderCloudPage.getName()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_NAME);
expect(await processHeaderCloudPage.getStatus()).toEqual('COMPLETED');
expect(await processHeaderCloudPage.getInitiator()).toEqual(childCompleteProcess.entry.initiator);
expect(await processHeaderCloudPage.getStartDate()).toEqual(completedCreatedDate);
expect(await processHeaderCloudPage.getParentId()).toEqual(childCompleteProcess.entry.parentId);
expect(await processHeaderCloudPage.getBusinessKey()).toEqual(CONSTANTS.PROCESS_DETAILS.NO_BUSINESS_KEY);
expect(await processHeaderCloudPage.getLastModified()).toEqual(completedCreatedDate);
});
});
});
});