ESLint: cleanup await expect from protractor tests (#9630)

This commit is contained in:
Denys Vuika
2024-04-30 08:07:10 -04:00
committed by GitHub
parent 4109f272ea
commit f401b8c13e
114 changed files with 2096 additions and 1908 deletions

View File

@@ -15,14 +15,22 @@
* limitations under the License.
*/
import { createApiService, AppListCloudPage, BrowserActions, GroupIdentityService, IdentityService, LoginPage, StartProcessCloudPage, StringUtil } from '@alfresco/adf-testing';
import {
createApiService,
AppListCloudPage,
BrowserActions,
GroupIdentityService,
IdentityService,
LoginPage,
StartProcessCloudPage,
StringUtil
} from '@alfresco/adf-testing';
import { browser, protractor } from 'protractor';
import { ProcessCloudDemoPage } from './../pages/process-cloud-demo.page';
import { NavigationBarPage } from '../../core/pages/navigation-bar.page';
import CONSTANTS = require('../../util/constants');
describe('Start Process', () => {
const loginSSOPage = new LoginPage();
const navigationBarPage = new NavigationBarPage();
const appListCloudComponent = new AppListCloudPage();
@@ -44,12 +52,13 @@ describe('Start Process', () => {
const lengthValidationError = 'Length exceeded, 255 characters max.';
const requiredError = 'Process Name is required';
const simpleApp = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.name;
let testUser; let groupInfo;
let testUser;
let groupInfo;
beforeAll(async () => {
await apiService.loginWithProfile('identityAdmin');
testUser = await identityService.createIdentityUserWithRole( [identityService.ROLES.ACTIVITI_USER]);
testUser = await identityService.createIdentityUserWithRole([identityService.ROLES.ACTIVITI_USER]);
groupInfo = await groupIdentityService.getGroupInfoByGroupName('hr');
await identityService.addUserToGroup(testUser.idIdentityService, groupInfo.id);
@@ -57,12 +66,12 @@ describe('Start Process', () => {
await navigationBarPage.navigateToProcessServicesCloudPage();
await appListCloudComponent.checkApsContainer();
});
});
afterAll(async () => {
await apiService.loginWithProfile('identityAdmin');
await identityService.deleteIdentityUser(testUser.idIdentityService);
});
});
afterEach(async () => {
await navigationBarPage.navigateToProcessServicesCloudPage();
@@ -77,7 +86,7 @@ describe('Start Process', () => {
await browser.actions().sendKeys(protractor.Key.ENTER).perform();
await startProcessPage.checkValidationErrorIsDisplayed(requiredError);
await expect(await startProcessPage.isStartProcessButtonDisabled()).toEqual(true);
expect(await startProcessPage.isStartProcessButtonDisabled()).toEqual(true);
await BrowserActions.closeMenuAndDialogs();
await startProcessPage.clickCancelProcessButton();
@@ -90,11 +99,11 @@ describe('Start Process', () => {
await startProcessPage.selectFirstOptionFromProcessDropdown();
await startProcessPage.enterProcessName(processName255Characters);
await expect(await startProcessPage.isStartProcessButtonEnabled()).toEqual(true);
expect(await startProcessPage.isStartProcessButtonEnabled()).toEqual(true);
await startProcessPage.enterProcessName(processNameBiggerThen255Characters);
await startProcessPage.checkValidationErrorIsDisplayed(lengthValidationError);
await expect(await startProcessPage.isStartProcessButtonDisabled()).toEqual(true);
expect(await startProcessPage.isStartProcessButtonDisabled()).toEqual(true);
});
it('[C291860] Should be able to start a process', async () => {
@@ -105,14 +114,14 @@ describe('Start Process', () => {
await startProcessPage.clearField(startProcessPage.processNameInput);
await startProcessPage.enterProcessName(processName);
await expect(await startProcessPage.isStartProcessButtonEnabled()).toEqual(true);
expect(await startProcessPage.isStartProcessButtonEnabled()).toEqual(true);
await startProcessPage.clickStartProcessButton();
await processFilter.clickOnProcessFilters();
await processFilter.clickRunningProcessesFilter();
await editProcessFilter.openFilter();
await editProcessFilter.setProcessName(processName);
await expect(await processFilter.getActiveFilterName()).toBe(CONSTANTS.PROCESS_FILTERS.RUNNING);
expect(await processFilter.getActiveFilterName()).toBe(CONSTANTS.PROCESS_FILTERS.RUNNING);
await processList.checkContentIsDisplayedByName(processName);
});
});
});

View File

@@ -25,13 +25,13 @@ import {
TaskHeaderCloudPage,
StartTasksCloudPage,
PeopleCloudComponentPage,
TasksService, createApiService,
TasksService,
createApiService,
IdentityService,
GroupIdentityService
} from '@alfresco/adf-testing';
describe('Start Task', () => {
const simpleApp = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.name;
const loginSSOPage = new LoginPage();
@@ -59,7 +59,10 @@ describe('Start Task', () => {
const lengthValidationError = 'Length exceeded, 255 characters max.';
const requiredError = 'Field required';
const dateValidationError = 'Date format DD/MM/YYYY';
let apsUser; let testUser; let activitiUser; let groupInfo;
let apsUser;
let testUser;
let activitiUser;
let groupInfo;
beforeAll(async () => {
await apiService.loginWithProfile('identityAdmin');
@@ -117,8 +120,8 @@ describe('Start Task', () => {
const taskId = await taskList.getIdCellValue(unassignedTaskName);
await taskList.selectRow(unassignedTaskName);
await taskHeaderCloudPage.checkTaskPropertyListIsDisplayed();
await expect(await taskHeaderCloudPage.getId()).toBe(taskId);
await expect(await taskHeaderCloudPage.getAssignee()).toBe('No assignee');
expect(await taskHeaderCloudPage.getId()).toBe(taskId);
expect(await taskHeaderCloudPage.getAssignee()).toBe('No assignee');
});
it('[C291956] Should be able to create a new standalone task without assignee', async () => {
@@ -197,7 +200,7 @@ describe('Start Task', () => {
await taskFilter.clickTaskFilter('my-tasks');
await taskList.getDataTable().waitTillContentLoaded();
await expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
});
it('[C305050] Should be able to reassign the removed user when starting a new task', async () => {
@@ -221,6 +224,6 @@ describe('Start Task', () => {
await taskList.selectRow(reassignTaskName);
await expect(await taskHeaderCloudPage.getAssignee()).toBe(apsUser.username);
expect(await taskHeaderCloudPage.getAssignee()).toBe(apsUser.username);
});
});

View File

@@ -23,7 +23,8 @@ import {
AppListCloudPage,
BreadcrumbDropdownPage,
StringUtil,
StartTasksCloudPage, createApiService,
StartTasksCloudPage,
createApiService,
IdentityService,
GroupIdentityService,
TaskFormCloudComponent,
@@ -34,7 +35,8 @@ import {
ContentNodeSelectorDialogPage,
ProcessInstancesService,
ProcessDefinitionsService,
FileBrowserUtil, ProcessCloudWidgetPage,
FileBrowserUtil,
ProcessCloudWidgetPage,
QueryService
} from '@alfresco/adf-testing';
import { StartProcessCloudConfiguration } from './../config/start-process-cloud.config';
@@ -43,7 +45,6 @@ import { ProcessDetailsCloudDemoPage } from './../pages/process-details-cloud-de
import { FileModel } from '../../models/ACS/file.model';
describe('Start Task Form', () => {
const loginSSOPage = new LoginPage();
const taskFormCloudComponent = new TaskFormCloudComponent();
const navigationBarPage = new NavigationBarPage();
@@ -77,11 +78,17 @@ describe('Start Task Form', () => {
const startProcessCloudConfig = startProcessCloudConfiguration.getConfiguration();
const standaloneTaskName = StringUtil.generateRandomString(5);
let testUser; let groupInfo;
let testUser;
let groupInfo;
let processDefinitionService: ProcessDefinitionsService;
let processInstancesService: ProcessInstancesService;
let processDefinition; let uploadLocalFileProcess; let uploadContentFileProcess; let uploadDefaultFileProcess;
let cancelUploadFileProcess; let completeUploadFileProcess; let downloadContentFileProcess;
let processDefinition;
let uploadLocalFileProcess;
let uploadContentFileProcess;
let uploadDefaultFileProcess;
let cancelUploadFileProcess;
let completeUploadFileProcess;
let downloadContentFileProcess;
const candidateBaseApp = browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.name;
const pdfFile = new FileModel({ name: browser.params.resources.Files.ADF_DOCUMENTS.PDF.file_name });
const pdfFileModel = new FileModel({
@@ -99,15 +106,17 @@ describe('Start Task Form', () => {
beforeAll(async () => {
await apiService.loginWithProfile('identityAdmin');
testUser = await identityService.createIdentityUserWithRole( [identityService.ROLES.ACTIVITI_USER]);
testUser = await identityService.createIdentityUserWithRole([identityService.ROLES.ACTIVITI_USER]);
groupInfo = await groupIdentityService.getGroupInfoByGroupName('hr');
await identityService.addUserToGroup(testUser.idIdentityService, groupInfo.id);
await apiService.login(testUser.username, testUser.password);
processDefinitionService = new ProcessDefinitionsService(apiService);
processInstancesService = new ProcessInstancesService(apiService);
processDefinition = await processDefinitionService
.getProcessDefinitionByName(browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.processes.uploadFileProcess, candidateBaseApp);
processDefinition = await processDefinitionService.getProcessDefinitionByName(
browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.processes.uploadFileProcess,
candidateBaseApp
);
await processInstancesService.createProcessInstance(processDefinition.entry.key, candidateBaseApp);
@@ -186,8 +195,8 @@ describe('Start Task Form', () => {
await widget.numberWidget().setFieldValue('Number07vyx9', 26);
await taskFormCloudComponent.checkSaveButtonIsDisplayed();
await taskFormCloudComponent.clickSaveButton();
await expect(await widget.textWidget().getFieldValue('FirstName')).toBe('sample');
await expect(await widget.numberWidget().getFieldValue('Number07vyx9')).toBe('26');
expect(await widget.textWidget().getFieldValue('FirstName')).toBe('sample');
expect(await widget.numberWidget().getFieldValue('Number07vyx9')).toBe('26');
await navigationBarPage.navigateToProcessServicesCloudPage();
await appListCloudComponent.checkApsContainer();
@@ -195,12 +204,12 @@ describe('Start Task Form', () => {
await appListCloudComponent.goToApp(candidateBaseApp);
await taskList.getDataTable().waitForTableBody();
await expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
await taskList.checkContentIsDisplayedByName(standaloneTaskName);
await taskList.selectRow(standaloneTaskName);
await taskFormCloudComponent.formFields().checkFormIsDisplayed();
await expect(await widget.textWidget().getFieldValue('FirstName')).toBe('sample');
await expect(await widget.numberWidget().getFieldValue('Number07vyx9')).toBe('26');
expect(await widget.textWidget().getFieldValue('FirstName')).toBe('sample');
expect(await widget.numberWidget().getFieldValue('Number07vyx9')).toBe('26');
await taskFormCloudComponent.checkCompleteButtonIsDisplayed();
});
@@ -209,9 +218,11 @@ describe('Start Task Form', () => {
await startTask.checkFormIsDisplayed();
await startTask.checkFormDefinitionIsNotDisplayed(browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.forms.uploadfileform);
await startTask.checkFormDefinitionIsDisplayed(browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.forms.starteventform);
await startTask.checkFormDefinitionIsDisplayed(browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.forms.formtotestvalidations);
await startTask.checkFormDefinitionIsDisplayed(
browser.params.resources.ACTIVITI_CLOUD_APPS.CANDIDATE_BASE_APP.forms.formtotestvalidations
);
});
});
});
describe('Attach content to process-cloud task form using upload widget', async () => {
beforeEach(async () => {
@@ -268,16 +279,16 @@ describe('Start Task Form', () => {
const contentFileWidget = widget.attachFileWidgetCloud('Attachsinglecontentfile');
await contentFileWidget.clickAttachContentFile('Attachsinglecontentfile');
await contentNodeSelectorDialogPage.checkDialogIsDisplayed();
await expect(await breadCrumbDropdownPage.getTextOfCurrentFolder()).toBe(testUser.username);
expect(await breadCrumbDropdownPage.getTextOfCurrentFolder()).toBe(testUser.username);
await contentNodeSelectorDialogPage.contentListPage().dataTablePage().waitTillContentLoaded();
await contentNodeSelectorDialogPage.contentListPage().dataTablePage().checkRowContentIsDisplayed(folderName);
await expect(await contentNodeSelectorDialogPage.checkCancelButtonIsEnabled()).toBe(true);
await expect(await contentNodeSelectorDialogPage.checkCopyMoveButtonIsEnabled()).toBe(false);
expect(await contentNodeSelectorDialogPage.checkCancelButtonIsEnabled()).toBe(true);
expect(await contentNodeSelectorDialogPage.checkCopyMoveButtonIsEnabled()).toBe(false);
await contentNodeSelectorDialogPage.contentListPage().dataTablePage().clickRowByContent(folderName);
await contentNodeSelectorDialogPage.contentListPage().dataTablePage().checkRowByContentIsSelected(folderName);
await expect(await contentNodeSelectorDialogPage.checkCancelButtonIsEnabled()).toBe(true);
await expect(await contentNodeSelectorDialogPage.checkCopyMoveButtonIsEnabled()).toBe(false);
expect(await contentNodeSelectorDialogPage.checkCancelButtonIsEnabled()).toBe(true);
expect(await contentNodeSelectorDialogPage.checkCopyMoveButtonIsEnabled()).toBe(false);
await contentNodeSelectorDialogPage.clickCancelButton();
await contentNodeSelectorDialogPage.checkDialogIsNotDisplayed();
});
@@ -379,7 +390,7 @@ describe('Start Task Form', () => {
const taskId = await taskHeaderCloudPage.getId();
await taskFormCloudComponent.checkCompleteButtonIsDisplayed();
await taskFormCloudComponent.clickCompleteButton();
await expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
await taskList.checkContentIsNotDisplayedById(taskId);
await taskFilter.clickTaskFilter('completed-tasks');
@@ -416,7 +427,7 @@ describe('Start Task Form', () => {
const taskId = await taskHeaderCloudPage.getId();
await taskFormCloudComponent.clickCompleteButton();
await expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
expect(await taskFilter.getActiveFilterName()).toBe('My Tasks');
await taskList.checkContentIsNotDisplayedById(taskId);
await taskFilter.clickTaskFilter('completed-tasks');
@@ -428,5 +439,5 @@ describe('Start Task Form', () => {
await contentFileWidget.downloadFile(testFileModel.name);
await FileBrowserUtil.isFileDownloaded(testFileModel.name);
});
});
});
});