inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-3593] remove rxjs-compat layer (#3886)

Browse Source 
* remove rxjs-compat layer

* add rxjs linter

* observable new instead of create

* lint fixes

* disable rxjs-no-subject-value for certain scenarios

* fix auth rxjs
This commit is contained in:
Denys Vuika
2018-10-16 19:45:00 +01:00
committed by Eugenio Romano
parent ccc52d40dd
commit f5a7b07370
29 changed files with 3337 additions and 3177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/content-services/content-node-selector/content-node-dialog.service.spec.ts
View File

@@ -112,7 +112,7 @@ describe('ContentNodeDialogService', () => {
it('should be able to open the dialog using a folder id', fakeAsync(() => {
spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
service.openFileBrowseDialogByFolderId('fake-folder-id').subscribe();
service.openFileBrowseDialogByFolderId('fake-folder-id').subscribe(() => {});
tick();
expect(spyOnDialogOpen).toHaveBeenCalled();
}));
@@ -120,7 +120,7 @@ describe('ContentNodeDialogService', () => {
it('should be able to open the dialog for files using the first user site', fakeAsync(() => {
spyOn(sitesService, 'getSites').and.returnValue(of(fakeSiteList));
spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
service.openFileBrowseDialogBySite().subscribe();
service.openFileBrowseDialogBySite().subscribe(() => {});
tick();
expect(spyOnDialogOpen).toHaveBeenCalled();
}));
@@ -128,7 +128,7 @@ describe('ContentNodeDialogService', () => {
it('should be able to open the dialog for folder using the first user site', fakeAsync(() => {
spyOn(sitesService, 'getSites').and.returnValue(of(fakeSiteList));
spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNode));
service.openFolderBrowseDialogBySite().subscribe();
service.openFolderBrowseDialogBySite().subscribe(() => {});
tick();
expect(spyOnDialogOpen).toHaveBeenCalled();
}));

2
lib/content-services/content-node-selector/content-node-selector-panel.component.spec.ts
View File

@@ -85,7 +85,7 @@ describe('ContentNodeSelectorComponent', () => {
contentNodeSelectorService = TestBed.get(ContentNodeSelectorService);
cnSearchSpy = spyOn(contentNodeSelectorService, 'search').and.callThrough();
searchSpy = spyOn(searchService, 'searchByQueryBody').and.callFake(() => {
return Observable.create((observer: Observer<NodePaging>) => {
return new Observable((observer: Observer<NodePaging>) => {
_observer = observer;
});
});

2
lib/content-services/document-list/components/document-list.component.ts
View File

@@ -15,6 +15,8 @@
* limitations under the License.
*/
/* tslint:disable:rxjs-no-subject-value */
import {
AfterContentInit, Component, ContentChild, ElementRef, EventEmitter, HostListener, Input, NgZone,
OnChanges, OnDestroy, OnInit, Output, SimpleChanges, TemplateRef, ViewChild, ViewEncapsulation

4
lib/content-services/mock/document-list.service.mock.ts
View File

@@ -42,14 +42,14 @@ export class DocumentListServiceMock extends DocumentListService {
if (this.getFolderReject) {
return throwError(this.getFolderRejectError);
}
return Observable.create(observer => {
return new Observable(observer => {
observer.next(this.getFolderResult);
observer.complete();
});
}
deleteNode(nodeId: string) {
return Observable.create(observer => {
return new Observable(observer => {
observer.next();
observer.complete();
});

4
lib/content-services/search/components/search-control.component.ts
View File

@@ -148,12 +148,12 @@ export class SearchControlComponent implements OnInit, OnDestroy {
ngOnDestroy(): void {
if (this.focusSubject) {
this.focusSubject.unsubscribe();
this.focusSubject.complete();
this.focusSubject = null;
}
if (this.toggleSearch) {
this.toggleSearch.unsubscribe();
this.toggleSearch.complete();
this.toggleSearch = null;
}
}

8
lib/content-services/search/components/search-trigger.directive.ts
View File

@@ -81,7 +81,6 @@ export class SearchTriggerDirective implements ControlValueAccessor, OnDestroy {
this.onDestroy$.complete();
if (this.escapeEventStream) {
this.escapeEventStream.unsubscribe();
this.escapeEventStream = null;
}
if ( this.closingActionsSubscription ) {
@@ -127,7 +126,8 @@ export class SearchTriggerDirective implements ControlValueAccessor, OnDestroy {
filter((event: MouseEvent | TouchEvent) => {
const clickTarget = event.target as HTMLElement;
return this._panelOpen && clickTarget !== this.element.nativeElement;
})
}),
takeUntil(this.onDestroy$)
);
}
@@ -191,11 +191,11 @@ export class SearchTriggerDirective implements ControlValueAccessor, OnDestroy {
return merge(firstStable, optionChanges)
.pipe(
takeUntil(this.onDestroy$),
switchMap(() => {
this.searchPanel.setVisibility();
return this.panelClosingActions;
})
}),
takeUntil(this.onDestroy$)
)
.subscribe(event => this.setValueAndClose(event));
}