[ADF-3593] remove rxjs-compat layer (#3886)

* remove rxjs-compat layer

* add rxjs linter

* observable new instead of create

* lint fixes

* disable rxjs-no-subject-value for certain scenarios

* fix auth rxjs

lib/core/form/services/ecm-model.service.spec.ts

@@ -229,14 +229,14 @@ describe('EcmModelService', () => {
 
     it('Should create an ECM type with properties', (done) => {
         spyOn(service, 'createEcmType').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
         });
 
         spyOn(service, 'addPropertyToAType').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
@@ -251,14 +251,14 @@ describe('EcmModelService', () => {
 
     it('Should return the already existing type', (done) => {
         spyOn(service, 'searchEcmType').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next({test: 'I-EXIST'});
                 observer.complete();
             });
         });
 
         spyOn(service, 'createEcmTypeWithProperties').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
@@ -273,14 +273,14 @@ describe('EcmModelService', () => {
 
     it('Should create an ECM type with properties if the ecm Type is not defined already', (done) => {
         spyOn(service, 'searchEcmType').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
         });
 
         spyOn(service, 'createEcmTypeWithProperties').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
@@ -295,14 +295,14 @@ describe('EcmModelService', () => {
 
     it('Should create an ECM model for the activiti if not defined already', (done) => {
         spyOn(service, 'searchActivitiEcmModel').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
         });
 
         spyOn(service, 'createActivitiEcmModel').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });
@@ -317,14 +317,14 @@ describe('EcmModelService', () => {
 
     it('If a model for the activiti is already define has to save the new type', (done) => {
         spyOn(service, 'searchActivitiEcmModel').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next({test: 'I-EXIST'});
                 observer.complete();
             });
         });
 
         spyOn(service, 'saveFomType').and.callFake(() => {
-            return Observable.create(observer => {
+            return new Observable(observer => {
                 observer.next();
                 observer.complete();
             });

lib/core/form/services/ecm-model.service.ts

@@ -34,7 +34,7 @@ export class EcmModelService {
     }
 
     public createEcmTypeForActivitiForm(formName: string, form: FormModel): Observable<any> {
-        return Observable.create(observer => {
+        return new Observable(observer => {
             this.searchActivitiEcmModel().subscribe(
                 model => {
                     if (!model) {
@@ -62,7 +62,7 @@ export class EcmModelService {
     }
 
     createActivitiEcmModel(formName: string, form: FormModel): Observable<any> {
-        return Observable.create(observer => {
+        return new Observable(observer => {
             this.createEcmModel(EcmModelService.MODEL_NAME, EcmModelService.MODEL_NAMESPACE).subscribe(
                 model => {
                     this.logService.info('model created', model);
@@ -83,7 +83,7 @@ export class EcmModelService {
     }
 
     saveFomType(formName: string, form: FormModel): Observable<any> {
-        return Observable.create(observer => {
+        return new Observable(observer => {
             this.searchEcmType(formName, EcmModelService.MODEL_NAME).subscribe(
                 ecmType => {
                     this.logService.info('custom types', ecmType);
@@ -103,7 +103,7 @@ export class EcmModelService {
     }
 
     public createEcmTypeWithProperties(formName: string, form: FormModel): Observable<any> {
-        return Observable.create(observer => {
+        return new Observable(observer => {
             this.createEcmType(formName, EcmModelService.MODEL_NAME, EcmModelService.TYPE_MODEL).subscribe(
                 typeCreated => {
                     this.logService.info('type Created', typeCreated);

lib/core/form/services/form.service.ts

@@ -116,7 +116,7 @@ export class FormService {
      * @returns The new form
      */
     createFormFromANode(formName: string): Observable<any> {
-        return Observable.create(observer => {
+        return new Observable(observer => {
             this.createForm(formName).subscribe(
                 form => {
                     this.ecmModelService.searchEcmType(formName, EcmModelService.MODEL_NAME).subscribe(