[ADF-3593] remove rxjs-compat layer (#3886)

* remove rxjs-compat layer

* add rxjs linter

* observable new instead of create

* lint fixes

* disable rxjs-no-subject-value for certain scenarios

* fix auth rxjs

lib/core/services/authentication.service.ts

@@ -27,7 +27,7 @@ import { map, catchError, tap } from 'rxjs/operators';
 import { HttpHeaders } from '@angular/common/http';
 
 const REMEMBER_ME_COOKIE_KEY = 'ALFRESCO_REMEMBER_ME';
-const REMEMBER_ME_UNTIL = 1000 * 60 * 60 * 24 * 30 ;
+const REMEMBER_ME_UNTIL = 1000 * 60 * 60 * 24 * 30;
 
 @Injectable()
 export class AuthenticationService {
@@ -50,10 +50,10 @@ export class AuthenticationService {
      * @returns True if logged in, false otherwise
      */
     isLoggedIn(): boolean {
-            if (!this.isOauth() && this.cookie.isEnabled() && !this.isRememberMeSet()) {
-                return false;
-            }
-            return this.alfrescoApi.getInstance().isLoggedIn();
+        if (!this.isOauth() && this.cookie.isEnabled() && !this.isRememberMeSet()) {
+            return false;
+        }
+        return this.alfrescoApi.getInstance().isLoggedIn();
     }
 
     /**
@@ -284,7 +284,7 @@ export class AuthenticationService {
     }
 
     addTokenToHeader(headersArg?: HttpHeaders): Observable<HttpHeaders> {
-        return Observable.create(async (observer: Observer<any>) => {
+        return new Observable((observer: Observer<any>) => {
             let headers = headersArg;
             if (!headers) {
                 headers = new HttpHeaders();

lib/core/services/renditions.service.ts

@@ -34,7 +34,7 @@ export class RenditionsService {
 
     /** @deprecated */
     isRenditionAvailable(nodeId: string, encoding: string): Observable<boolean> {
-        return Observable.create((observer) => {
+        return new Observable((observer) => {
             this.getRendition(nodeId, encoding).subscribe(
                 (res) => {
                     let isAvailable = true;
@@ -54,7 +54,7 @@ export class RenditionsService {
 
     /** @deprecated */
     isConversionPossible(nodeId: string, encoding: string): Observable<boolean> {
-        return Observable.create((observer) => {
+        return new Observable((observer) => {
             this.getRendition(nodeId, encoding).subscribe(
                 () => {
                     observer.next(true);

lib/core/services/translate-loader.service.ts

@@ -121,7 +121,7 @@ export class TranslateLoaderService implements TranslateLoader {
             })
         ];
 
-        return Observable.create(observer => {
+        return new Observable(observer => {
 
             if (batch.length > 0) {
                 forkJoin(batch).subscribe(