From f62236b91624aded93f5c0171e183cff9dfd3924 Mon Sep 17 00:00:00 2001 From: Silviu Popa Date: Tue, 28 May 2019 19:37:36 +0300 Subject: [PATCH] [ADF-4598] StartTask - revert start task assignee and candidateGroups validations (#4785) * [NO_ISSUE] - revert start task assignee and candidateGroups validations * [ADF-4598] - fix unit tests --- .../components/start-task-cloud.component.spec.ts | 12 ------------ .../components/start-task-cloud.component.ts | 6 +----- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.spec.ts index f0b10755b3..5c17ed89e8 100644 --- a/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.spec.ts +++ b/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.spec.ts @@ -153,18 +153,6 @@ describe('StartTaskCloudComponent', () => { expect(createNewTaskSpy).toHaveBeenCalledWith(taskRequest); }); })); - - it('should cannot start a task if assigne or candidate group is invalid', async(() => { - component.taskForm.controls['name'].setValue('fakeName'); - fixture.detectChanges(); - fixture.whenStable().then( () => { - const createTaskButton = element.querySelector('#button-start'); - component.assignee.searchUserCtrl.setValue(''); - component.candidateGroups.searchGroupsControl.setValue(''); - fixture.detectChanges(); - expect(createTaskButton.hasAttribute('disabled')).toEqual(true); - }); - })); }); it('should select logged in user as assignee by default', () => { diff --git a/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.ts b/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.ts index b12537d577..053e80c6cd 100644 --- a/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.ts +++ b/lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.ts @@ -99,7 +99,7 @@ export class StartTaskCloudComponent implements OnInit, OnDestroy { formKey: string; - private assigneeForm: AbstractControl = new FormControl('', [Validators.required]); + private assigneeForm: AbstractControl = new FormControl(''); private groupForm: AbstractControl = new FormControl(''); private localeSub: Subscription; @@ -193,13 +193,9 @@ export class StartTaskCloudComponent implements OnInit, OnDestroy { onAssigneeSelect(assignee: IdentityUserModel) { this.assigneeName = assignee ? assignee.username : ''; - this.groupForm.clearValidators(); - this.groupForm.updateValueAndValidity(); } onAssigneeRemove() { - this.groupForm.setValidators(Validators.required); - this.groupForm.updateValueAndValidity(); this.assigneeName = ''; }