#987 fix unit test

This commit is contained in:
mauriziovitale84 2016-11-14 17:21:57 +00:00 committed by Mario Romano
parent a66d4d44e8
commit f844b0d65f

View File

@ -15,17 +15,17 @@
* limitations under the License. * limitations under the License.
*/ */
import { SimpleChange } from '@angular/core'; import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { AlfrescoTranslationService, CoreModule } from 'ng2-alfresco-core';
import { DataTableModule } from 'ng2-alfresco-datatable';
import { ActivitiTaskList } from './activiti-tasklist.component'; import { ActivitiTaskList } from './activiti-tasklist.component';
import { ActivitiTaskListService } from '../services/activiti-tasklist.service';
import { FilterRepresentationModel } from '../models/filter.model';
import { Observable } from 'rxjs/Rx'; import { Observable } from 'rxjs/Rx';
import { ObjectDataRow, DataRowEvent, ObjectDataTableAdapter } from 'ng2-alfresco-datatable'; import { ObjectDataRow, DataRowEvent, ObjectDataTableAdapter } from 'ng2-alfresco-datatable';
import { TranslationMock } from './../assets/translation.service.mock';
import { ActivitiTaskListService } from '../services/activiti-tasklist.service';
describe('ActivitiTaskList', () => { describe('ActivitiTaskList', () => {
let taskList: ActivitiTaskList;
let fakeGlobalTask = { let fakeGlobalTask = {
size: 2, total: 2, start: 0, size: 2, total: 2, start: 0,
data: [ data: [
@ -65,86 +65,114 @@ describe('ActivitiTaskList', () => {
reject(fakeErrorTaskList); reject(fakeErrorTaskList);
}); });
let componentHandler: any;
let component: ActivitiTaskList;
let fixture: ComponentFixture<ActivitiTaskList>;
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [
CoreModule,
DataTableModule
],
declarations: [
ActivitiTaskList
],
providers: [
{ provide: AlfrescoTranslationService, useClass: TranslationMock },
ActivitiTaskListService
]
}).compileComponents();
}));
beforeEach(() => { beforeEach(() => {
let activitiSerevice = new ActivitiTaskListService(null);
taskList = new ActivitiTaskList(null, activitiSerevice); fixture = TestBed.createComponent(ActivitiTaskList);
component = fixture.componentInstance;
componentHandler = jasmine.createSpyObj('componentHandler', [
'upgradeAllRegistered',
'upgradeElement'
]);
window['componentHandler'] = componentHandler;
}); });
it('should use the default schemaColumn as default', () => { it('should use the default schemaColumn as default', () => {
taskList.ngOnInit(); component.ngOnInit();
expect(taskList.data.getColumns()).toBeDefined(); expect(component.data.getColumns()).toBeDefined();
expect(taskList.data.getColumns().length).toEqual(4); expect(component.data.getColumns().length).toEqual(4);
}); });
it('should use the schemaColumn passed in input', () => { it('should use the schemaColumn passed in input', () => {
taskList.data = new ObjectDataTableAdapter( component.data = new ObjectDataTableAdapter(
[], [],
[ [
{type: 'text', key: 'fake-id', title: 'Name'} {type: 'text', key: 'fake-id', title: 'Name'}
] ]
); );
taskList.ngOnInit(); component.ngOnInit();
expect(taskList.data.getColumns()).toBeDefined(); expect(component.data.getColumns()).toBeDefined();
expect(taskList.data.getColumns().length).toEqual(1); expect(component.data.getColumns().length).toEqual(1);
}); });
it('should return an empty task list when the taskFilter is not passed', () => { it('should return an empty task list when no input parameters are passed', () => {
taskList.ngOnInit(); component.ngOnInit();
expect(taskList.data).toBeDefined(); expect(component.data).toBeDefined();
expect(taskList.isTaskListEmpty()).toBeTruthy(); expect(component.isTaskListEmpty()).toBeTruthy();
}); });
it('should return the filtered task list when the taskFilter is passed', (done) => { it('should return the filtered task list when the input parameters are passed', (done) => {
spyOn(taskList.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeGlobalTotalTasksPromise)); spyOn(component.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeGlobalTotalTasksPromise));
spyOn(taskList.activiti, 'getTasks').and.returnValue(Observable.fromPromise(fakeGlobalTaskPromise)); spyOn(component.activiti, 'getTasks').and.returnValue(Observable.fromPromise(fakeGlobalTaskPromise));
taskList.taskFilter = new FilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}}); component.state = 'open';
component.assignment = 'fake-assignee';
taskList.onSuccess.subscribe( (res) => { component.onSuccess.subscribe( (res) => {
expect(res).toBeDefined(); expect(res).toBeDefined();
expect(taskList.data).toBeDefined(); expect(component.data).toBeDefined();
expect(taskList.isTaskListEmpty()).not.toBeTruthy(); expect(component.isTaskListEmpty()).not.toBeTruthy();
expect(taskList.data.getRows().length).toEqual(2); expect(component.data.getRows().length).toEqual(2);
expect(taskList.data.getRows()[0].getValue('name')).toEqual('fake-long-name-fake-long-name-fake-long-name-fak50...'); expect(component.data.getRows()[0].getValue('name')).toEqual('fake-long-name-fake-long-name-fake-long-name-fak50...');
expect(taskList.data.getRows()[1].getValue('name')).toEqual('Nameless task'); expect(component.data.getRows()[1].getValue('name')).toEqual('Nameless task');
done(); done();
}); });
taskList.ngOnInit(); component.ngOnInit();
}); });
it('should return a currentId null when the taskList is empty', () => { it('should return a currentId null when the taskList is empty', () => {
taskList.selectFirstTask(); component.selectFirstTask();
expect(taskList.getCurrentTaskId()).toBeNull(); expect(component.getCurrentTaskId()).toBeNull();
}); });
it('should throw an exception when the response is wrong', (done) => { it('should throw an exception when the response is wrong', (done) => {
spyOn(taskList.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeErrorTaskPromise)); spyOn(component.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeErrorTaskPromise));
taskList.taskFilter = new FilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}}); component.state = 'open';
component.assignment = 'fake-assignee';
taskList.onError.subscribe( (err) => { component.onError.subscribe( (err) => {
expect(err).toBeDefined(); expect(err).toBeDefined();
done(); done();
}); });
taskList.ngOnInit(); component.ngOnInit();
}); });
it('should reload tasks when reload() is called', (done) => { it('should reload tasks when reload() is called', (done) => {
spyOn(taskList.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeGlobalTotalTasksPromise)); spyOn(component.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeGlobalTotalTasksPromise));
spyOn(taskList.activiti, 'getTasks').and.returnValue(Observable.fromPromise(fakeGlobalTaskPromise)); spyOn(component.activiti, 'getTasks').and.returnValue(Observable.fromPromise(fakeGlobalTaskPromise));
taskList.taskFilter = new FilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}}); component.state = 'open';
taskList.ngOnInit(); component.assignment = 'fake-assignee';
taskList.onSuccess.subscribe( (res) => { component.ngOnInit();
component.onSuccess.subscribe( (res) => {
expect(res).toBeDefined(); expect(res).toBeDefined();
expect(taskList.data).toBeDefined(); expect(component.data).toBeDefined();
expect(taskList.isTaskListEmpty()).not.toBeTruthy(); expect(component.isTaskListEmpty()).not.toBeTruthy();
expect(taskList.data.getRows().length).toEqual(2); expect(component.data.getRows().length).toEqual(2);
expect(taskList.data.getRows()[0].getValue('name')).toEqual('fake-long-name-fake-long-name-fake-long-name-fak50...'); expect(component.data.getRows()[0].getValue('name')).toEqual('fake-long-name-fake-long-name-fake-long-name-fak50...');
expect(taskList.data.getRows()[1].getValue('name')).toEqual('Nameless task'); expect(component.data.getRows()[1].getValue('name')).toEqual('Nameless task');
done(); done();
}); });
taskList.reload(); component.reload();
}); });
it('should emit row click event', (done) => { it('should emit row click event', (done) => {
@ -153,23 +181,38 @@ describe('ActivitiTaskList', () => {
}); });
let rowEvent = <DataRowEvent> {value: row}; let rowEvent = <DataRowEvent> {value: row};
taskList.rowClick.subscribe(taskId => { component.rowClick.subscribe(taskId => {
expect(taskId).toEqual(999); expect(taskId).toEqual(999);
expect(taskList.getCurrentTaskId()).toEqual(999); expect(component.getCurrentTaskId()).toEqual(999);
done(); done();
}); });
taskList.onRowClick(rowEvent); component.onRowClick(rowEvent);
}); });
it('should reload task list by filter on binding changes', () => { it('should reload the task list when the input parameters changes', (done) => {
spyOn(taskList, 'load').and.stub(); spyOn(component.activiti, 'getTotalTasks').and.returnValue(Observable.fromPromise(fakeGlobalTotalTasksPromise));
const taskFilter = new FilterRepresentationModel({filter: { state: 'open', assignment: 'fake-assignee'}}); spyOn(component.activiti, 'getTasks').and.returnValue(Observable.fromPromise(fakeGlobalTaskPromise));
let change = new SimpleChange(null, taskFilter); component.data = new ObjectDataTableAdapter(
taskList.ngOnChanges({ 'taskFilter': change }); [],
[
{type: 'text', key: 'fake-id', title: 'Name'}
]
);
component.state = 'open';
component.assignment = 'fake-assignee';
component.onSuccess.subscribe( (res) => {
expect(res).toBeDefined();
expect(component.data).toBeDefined();
expect(component.isTaskListEmpty()).not.toBeTruthy();
expect(component.data.getRows().length).toEqual(2);
expect(component.data.getRows()[0].getValue('name')).toEqual('fake-long-name-fake-long-name-fake-long-name-fak50...');
expect(component.data.getRows()[1].getValue('name')).toEqual('Nameless task');
done();
});
expect(taskList.load).toHaveBeenCalled(); component.ngOnChanges({});
}); });
}); });