From f8a75d4af74a2a63f1ddbbe0fc04dced1d214185 Mon Sep 17 00:00:00 2001 From: MichalKinas <113341662+MichalKinas@users.noreply.github.com> Date: Thu, 12 Jun 2025 11:47:22 +0200 Subject: [PATCH] Viewer renderer stop loading when subsequent renderer throws error (#10931) * Viewer renderer stop loading when subsequent renderer throws error * Update lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts * CR fix --------- Co-authored-by: Michaela <85624192+mkrbr@users.noreply.github.com> --- .../viewer-render/viewer-render.component.spec.ts | 11 +++++++++++ .../viewer-render/viewer-render.component.ts | 1 + 2 files changed, 12 insertions(+) diff --git a/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts b/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts index 61cbc21d94..61f5a88748 100644 --- a/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts +++ b/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts @@ -537,5 +537,16 @@ describe('ViewerComponent', () => { expect(component.viewerType).toBe('image'); expect(component.markAsLoaded).toHaveBeenCalled(); }); + + it('should not show spinner and set viewerType to unknown if subsequent renderer throws an error', () => { + component.urlFile = 'some-url.png'; + fixture.detectChanges(); + expect(getMainLoader()).not.toBeNull(); + + component.onUnsupportedFile(); + fixture.detectChanges(); + expect(getMainLoader()).toBeNull(); + expect(component.viewerType).toBe('unknown'); + }); }); }); diff --git a/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.ts b/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.ts index 6df1f1ae47..fda556f654 100644 --- a/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.ts +++ b/lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.ts @@ -235,6 +235,7 @@ export class ViewerRenderComponent implements OnChanges, OnInit { onUnsupportedFile() { this.viewerType = 'unknown'; + this.isLoading = false; } onClose() {