inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-4797] - fix null value for display text when the field it's not visible (#4987)

Browse Source 
* fix reset display text value when it's not visible

* change invalid unit test

* change unit test

* use alpha to test
This commit is contained in:
Silviu Popa
2019-08-09 16:45:26 +03:00
committed by Eugenio Romano
parent a8ef686cdd
commit f9a8d3a4bf
13 changed files with 28 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/core/form/services/widget-visibility-cloud.service.spec.ts
View File

@@ -530,7 +530,7 @@ describe('WidgetVisibilityCloudService', () => {
expect(fakeFormField.isVisible).toBeFalsy();
});
it('should reset value when the field is not visibile', () => {
it('should notreset value when the field is not visibile', () => {
visibilityObjTest.leftValue = 'test_1';
visibilityObjTest.operator = '==';
visibilityObjTest.rightType = WidgetTypeEnum.field;
@@ -539,7 +539,7 @@ describe('WidgetVisibilityCloudService', () => {
service.refreshEntityVisibility(fakeFormField);
expect(fakeFormField.isVisible).toBeFalsy();
expect(fakeFormField.value).toEqual(null);
expect(fakeFormField.value).toEqual('FAKE_FORM_FIELD_VALUE');
});
it('should return true when the visibility condition is not valid', () => {

4
lib/core/form/services/widget-visibility.service.spec.ts
View File

@@ -914,7 +914,7 @@ describe('WidgetVisibilityService', () => {
expect(contModel.isVisible).toBeFalsy();
});
it('should set null value when the field is not visibile', () => {
it('should not set null value when the field is not visibile', () => {
visibilityObjTest.leftFormFieldId = 'test_4';
visibilityObjTest.operator = '!=';
visibilityObjTest.rightFormFieldId = 'dropdown';
@@ -922,7 +922,7 @@ describe('WidgetVisibilityService', () => {
service.refreshEntityVisibility(fakeFormField);
expect(fakeFormField.isVisible).toBeFalsy();
expect(fakeFormField.value).toEqual(null);
expect(fakeFormField.value).toEqual('FAKE_FORM_FIELD_VALUE');
});
});

3
lib/core/form/services/widget-visibility.service.ts
View File

@@ -48,9 +48,6 @@ export class WidgetVisibilityService {
refreshEntityVisibility(element: FormFieldModel | TabModel) {
const visible = this.evaluateVisibility(element.form, element.visibilityCondition);
if (!visible && element instanceof FormFieldModel) {
element.value = null;
}
element.isVisible = visible;
}

2
lib/core/package.json
View File

@@ -1,7 +1,7 @@
{
"name": "@alfresco/adf-core",
"description": "Alfresco ADF core",
"version": "3.4.0",
"version": "3.4.0-a8ef686cddc5364975fbddba68e6683305f47d42",
"author": "Alfresco Software, Ltd.",
"main": "bundles/adf-core.js",
"repository": {