Single naming convention for core services (#1363)

* remove temporary file from repo

* fix: alfresco-api.service

* new: auth.service.ts

- new auth.service.ts implementation
- deprecation warning for AlfrescoAuthenticationService
- fix ‘clean-build’ typo
- extra vscode settings for ‘.d.ts’ files

* use AuthService internally

* new: content.service.ts

- deprecation warning for AlfrescoContentService
- use new ContentService internally

* new: settings.service.ts

- new SettingsService
- deprecation warning for AlfrescoSettingsService
- using new SettingsService internally

* new: translate.service and translate-loader.service

- custom TranslateLoader becomes AlfrescoTranslateLoader
- custom TranslateService becomes AlfrescoTranslateService
- deprecation notices for old service and loader implementations

* fix: document list

* fix: search

* fix: tag

also fixes #1364

* fix: activiti form

* fix: activiti tasklist, improve unit tests

* fix: activiti processlist, unit tests improvements

* fix: diagram component

* fix: analytics component

* fix: upload component

- fix numerous issues with unit tests (hidden by ‘any’ type)
- test improvements

* fix: webscript

* fix: userinfo unit tests

* code fixes

* fix 'beforeAll' issue

* tasklist unit testing improvements

* fix: form unit tests

* fix: unit tests

ng2-components/ng2-alfresco-webscript/src/webscript.component.spec.ts

@@ -15,22 +15,17 @@
  * limitations under the License.
  */
 
+import { DebugElement } from '@angular/core';
 import { ComponentFixture, TestBed, async } from '@angular/core/testing';
-import { WebscriptComponent } from '../src/webscript.component';
-import { DebugElement }    from '@angular/core';
-import {
-    AlfrescoAuthenticationService,
-    AlfrescoSettingsService,
-    AlfrescoApiService,
-    CoreModule
-} from 'ng2-alfresco-core';
+import { CoreModule } from 'ng2-alfresco-core';
 import { DataTableModule } from 'ng2-alfresco-datatable';
+import { WebscriptComponent } from '../src/webscript.component';
 
 declare let jasmine: any;
 
 describe('Test ng2-alfresco-webscript', () => {
 
-    let component: any;
+    let component: WebscriptComponent;
     let fixture: ComponentFixture<WebscriptComponent>;
     let debug: DebugElement;
     let element: HTMLElement;
@@ -38,14 +33,11 @@ describe('Test ng2-alfresco-webscript', () => {
     beforeEach(async(() => {
         TestBed.configureTestingModule({
             imports: [
-                CoreModule,
+                CoreModule.forRoot(),
                 DataTableModule
             ],
-            declarations: [WebscriptComponent],
-            providers: [
-                AlfrescoSettingsService,
-                AlfrescoAuthenticationService,
-                AlfrescoApiService
+            declarations: [
+                WebscriptComponent
             ]
         }).compileComponents();
     }));
@@ -93,7 +85,7 @@ describe('Test ng2-alfresco-webscript', () => {
         it('url should be the one configured by the input param', (done) => {
             component.scriptPath = 'sample/folder/Company%20Home';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(jasmine.Ajax.requests.mostRecent().url).toBe('http://localhost:8080/alfresco/service/sample/folder/Company%20Home');
                 done();
@@ -110,7 +102,7 @@ describe('Test ng2-alfresco-webscript', () => {
             component.scriptPath = 'sample/folder/Company%20Home';
             component.contentType = 'TEXT';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(element.querySelector('#webscript-data-TEXT').innerHTML)
                     .toBe('text test');
@@ -128,7 +120,7 @@ describe('Test ng2-alfresco-webscript', () => {
             component.scriptPath = 'sample/folder/Company%20Home';
             component.contentType = 'JSON';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(JSON.parse(element.querySelector('#webscript-data-JSON').innerHTML)[0].name).toBe('Name 1');
                 expect(JSON.parse(element.querySelector('#webscript-data-JSON').innerHTML)[1].name).toBe('Name 2');
@@ -147,7 +139,7 @@ describe('Test ng2-alfresco-webscript', () => {
             component.scriptPath = 'sample/folder/Company%20Home';
             component.contentType = 'HTML';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(element.querySelector('#webscript-data-HTML').innerHTML)
                     .toBe('&lt;test-element-id&gt;&lt;test-elemt-id&gt;');
@@ -168,7 +160,7 @@ describe('Test ng2-alfresco-webscript', () => {
             component.scriptPath = 'sample/folder/Company%20Home';
             component.contentType = 'DATATABLE';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(element.querySelector('#webscript-datatable-wrapper').innerHTML).toBeDefined();
                 done();
@@ -206,7 +198,7 @@ describe('Test ng2-alfresco-webscript', () => {
             component.scriptPath = 'sample/folder/Company%20Home';
             component.contentType = 'DATATABLE';
 
-            component.ngOnChanges().then(() => {
+            component.ngOnChanges(null).then(() => {
                 fixture.detectChanges();
                 expect(element.querySelector('#webscript-datatable-wrapper').innerHTML).toBeDefined();
                 done();

ng2-components/ng2-alfresco-webscript/src/webscript.component.ts

@@ -16,7 +16,7 @@
  */
 
 import { Component, Input, Output, EventEmitter } from '@angular/core';
-import { AlfrescoAuthenticationService, AlfrescoApiService } from 'ng2-alfresco-core';
+import { AlfrescoApiService } from 'ng2-alfresco-core';
 import { ObjectDataTableAdapter } from 'ng2-alfresco-datatable';
 
 /**
@@ -79,12 +79,7 @@ export class WebscriptComponent {
 
     showError: boolean = false;
 
-    /**
-     * Constructor
-     * @param authService
-     */
-    constructor(private authService: AlfrescoAuthenticationService, private apiService: AlfrescoApiService) {
-
+    constructor(private apiService: AlfrescoApiService) {
     }
 
     ngOnChanges(changes) {