[APPS-2136] search datetime range moment changes

This commit is contained in:
rbahirsheth
2023-10-09 13:54:09 +05:30
committed by kritagya09
parent e42e0869ba
commit fc147074ce
2 changed files with 32 additions and 32 deletions
@@ -19,8 +19,8 @@ import { SearchDatetimeRangeComponent } from './search-datetime-range.component'
import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ContentTestingModule } from '../../../testing/content.testing.module'; import { ContentTestingModule } from '../../../testing/content.testing.module';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { isValid } from 'date-fns';
declare let moment: any; import { DateFnsUtils } from '@alfresco/adf-core';
describe('SearchDatetimeRangeComponent', () => { describe('SearchDatetimeRangeComponent', () => {
let fixture: ComponentFixture<SearchDatetimeRangeComponent>; let fixture: ComponentFixture<SearchDatetimeRangeComponent>;
@@ -59,13 +59,14 @@ describe('SearchDatetimeRangeComponent', () => {
await fixture.whenStable(); await fixture.whenStable();
const inputString = '20-feb-18 20:00'; const inputString = '20-feb-18 20:00';
const momentFromInput = moment(inputString, datetimeFormatFixture);
expect(momentFromInput.isValid()).toBeTruthy(); const dateFromInput = DateFnsUtils.parseDate(inputString, datetimeFormatFixture);
expect(isValid(dateFromInput)).toBeTruthy();
component.onChangedHandler({ value: inputString }, component.from); component.onChangedHandler({ value: inputString }, component.from);
expect(component.from.value.toString()).toEqual(momentFromInput.toString()); expect(component.from.value.toString()).toEqual(dateFromInput.toString());
}); });
it('should NOT setup form control with invalid datetime on change', async () => { it('should NOT setup form control with invalid datetime on change', async () => {
@@ -75,13 +76,14 @@ describe('SearchDatetimeRangeComponent', () => {
await fixture.whenStable(); await fixture.whenStable();
const inputString = '2017-10-16 20:f:00'; const inputString = '2017-10-16 20:f:00';
const momentFromInput = moment(inputString, datetimeFormatFixture);
expect(momentFromInput.isValid()).toBeFalsy(); const dateFromInput = DateFnsUtils.parseDate(inputString, datetimeFormatFixture);
expect(isValid(dateFromInput)).toBeFalsy();
component.onChangedHandler({ value: inputString }, component.from); component.onChangedHandler({ value: inputString }, component.from);
expect(component.from.value.toString()).not.toEqual(momentFromInput.toString()); expect(component.from.value.toString()).not.toEqual(dateFromInput.toString());
}); });
it('should reset form', async () => { it('should reset form', async () => {
@@ -16,26 +16,25 @@
*/ */
import { Component, OnDestroy, OnInit, ViewEncapsulation } from '@angular/core'; import { Component, OnDestroy, OnInit, ViewEncapsulation } from '@angular/core';
import { UntypedFormControl, UntypedFormGroup, Validators } from '@angular/forms'; import { FormControl, FormGroup, Validators } from '@angular/forms';
import { UserPreferencesService, UserPreferenceValues } from '@alfresco/adf-core'; import { DateFnsUtils, UserPreferencesService, UserPreferenceValues } from '@alfresco/adf-core';
import { SearchWidget } from '../../models/search-widget.interface'; import { SearchWidget } from '../../models/search-widget.interface';
import { SearchWidgetSettings } from '../../models/search-widget-settings.interface'; import { SearchWidgetSettings } from '../../models/search-widget-settings.interface';
import { SearchQueryBuilderService } from '../../services/search-query-builder.service'; import { SearchQueryBuilderService } from '../../services/search-query-builder.service';
import { LiveErrorStateMatcher } from '../../forms/live-error-state-matcher'; import { LiveErrorStateMatcher } from '../../forms/live-error-state-matcher';
import { Moment } from 'moment';
import { Subject } from 'rxjs'; import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators'; import { takeUntil } from 'rxjs/operators';
import { DatetimeAdapter, MAT_DATETIME_FORMATS } from '@mat-datetimepicker/core'; import { DatetimeAdapter, MAT_DATETIME_FORMATS } from '@mat-datetimepicker/core';
import { MAT_MOMENT_DATETIME_FORMATS } from '@mat-datetimepicker/moment'; import { MAT_MOMENT_DATETIME_FORMATS } from '@mat-datetimepicker/moment';
import { DateFnsAdapter } from '@angular/material-date-fns-adapter';
import { startOfMinute, isBefore, isValid, endOfMinute } from 'date-fns';
export interface DatetimeRangeValue { export interface DatetimeRangeValue {
from: string; from: string;
to: string; to: string;
} }
declare let moment: any;
const DEFAULT_DATETIME_FORMAT: string = 'DD/MM/YYYY HH:mm'; const DEFAULT_DATETIME_FORMAT: string = 'DD/MM/YYYY HH:mm';
@Component({ @Component({
@@ -47,10 +46,10 @@ const DEFAULT_DATETIME_FORMAT: string = 'DD/MM/YYYY HH:mm';
host: { class: 'adf-search-date-range' } host: { class: 'adf-search-date-range' }
}) })
export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDestroy { export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDestroy {
from: UntypedFormControl; from: FormControl;
to: UntypedFormControl; to: FormControl;
form: UntypedFormGroup; form: FormGroup;
matcher = new LiveErrorStateMatcher(); matcher = new LiveErrorStateMatcher();
id: string; id: string;
@@ -66,7 +65,7 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
private onDestroy$ = new Subject<boolean>(); private onDestroy$ = new Subject<boolean>();
constructor(private dateAdapter: DatetimeAdapter<Moment>, private userPreferencesService: UserPreferencesService) {} constructor(private dateAdapter: DatetimeAdapter<DateFnsAdapter>, private userPreferencesService: UserPreferencesService) {}
getFromValidationMessage(): string { getFromValidationMessage(): string {
return this.from.hasError('invalidOnChange') || this.hasParseError(this.from) return this.from.hasError('invalidOnChange') || this.hasParseError(this.from)
@@ -101,21 +100,21 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
const validators = Validators.compose([Validators.required]); const validators = Validators.compose([Validators.required]);
if (this.settings?.maxDatetime) { if (this.settings?.maxDatetime) {
this.maxDatetime = moment(this.settings.maxDatetime); this.maxDatetime = new Date(this.settings.maxDatetime);
} }
if (this.startValue) { if (this.startValue) {
const splitValue = this.startValue.split('||'); const splitValue = this.startValue.split('||');
const fromValue = this.dateAdapter.parse(splitValue[0], this.datetimePickerFormat); const fromValue = this.dateAdapter.parse(splitValue[0], this.datetimePickerFormat);
const toValue = this.dateAdapter.parse(splitValue[1], this.datetimePickerFormat); const toValue = this.dateAdapter.parse(splitValue[1], this.datetimePickerFormat);
this.from = new UntypedFormControl(fromValue, validators); this.from = new FormControl(fromValue, validators);
this.to = new UntypedFormControl(toValue, validators); this.to = new FormControl(toValue, validators);
} else { } else {
this.from = new UntypedFormControl('', validators); this.from = new FormControl('', validators);
this.to = new UntypedFormControl('', validators); this.to = new FormControl('', validators);
} }
this.form = new UntypedFormGroup({ this.form = new FormGroup({
from: this.from, from: this.from,
to: this.to to: this.to
}); });
@@ -133,8 +132,8 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
if (isValid && this.id && this.context && this.settings && this.settings.field) { if (isValid && this.id && this.context && this.settings && this.settings.field) {
this.isActive = true; this.isActive = true;
const start = moment.utc(model.from).startOf('minute').format(); const start = DateFnsUtils.formatDate(startOfMinute(new Date(model.from)), `yyyy-MM-dd'T'HH:mm:ss'Z'`);
const end = moment.utc(model.to).endOf('minute').format(); const end = DateFnsUtils.formatDate(endOfMinute(new Date(model.to)), `yyyy-MM-dd'T'HH:mm:ss'Z'`);
this.context.queryFragments[this.id] = `${this.settings.field}:['${start}' TO '${end}']`; this.context.queryFragments[this.id] = `${this.settings.field}:['${start}' TO '${end}']`;
this.updateDisplayValue(); this.updateDisplayValue();
@@ -211,10 +210,10 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
} }
} }
onChangedHandler(event: any, formControl: UntypedFormControl) { onChangedHandler(event: any, formControl: FormControl) {
const inputValue = event.value; const inputValue = event.value;
const formatDate = this.dateAdapter.parse(inputValue, this.datetimePickerFormat); const formatDate = this.dateAdapter.parse(inputValue, this.datetimePickerFormat);
if (formatDate?.isValid()) { if (formatDate && isValid(formatDate)) {
formControl.setValue(formatDate); formControl.setValue(formatDate);
} else if (formatDate) { } else if (formatDate) {
formControl.setErrors({ formControl.setErrors({
@@ -225,12 +224,11 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
this.setFromMaxDatetime(); this.setFromMaxDatetime();
} }
setLocale(locale) { setLocale(locale: string) {
this.dateAdapter.setLocale(locale); this.dateAdapter.setLocale(DateFnsUtils.getLocaleFromString(locale));
moment.locale(locale);
} }
hasParseError(formControl): boolean { hasParseError(formControl: FormControl): boolean {
return formControl.hasError('matDatepickerParse') && formControl.getError('matDatepickerParse').text; return formControl.hasError('matDatepickerParse') && formControl.getError('matDatepickerParse').text;
} }
@@ -240,6 +238,6 @@ export class SearchDatetimeRangeComponent implements SearchWidget, OnInit, OnDes
setFromMaxDatetime() { setFromMaxDatetime() {
this.fromMaxDatetime = this.fromMaxDatetime =
!this.to.value || (this.maxDatetime && moment(this.maxDatetime).isBefore(this.to.value)) ? this.maxDatetime : moment(this.to.value); (!this.to.value || (this.maxDatetime && isBefore(this.maxDatetime, this.to.value))) ? this.maxDatetime : this.to.value;
} }
} }