[MIGRATION] - added reference to @types also to general node_modules

.github/workflows/pull-request.yml

@@ -205,7 +205,6 @@ jobs:
       - name: install
         run: |
           npm ci
-          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - run: npx nx print-affected $NX_CALCULATION_FLAGS

.github/workflows/release-branch.yml

@@ -97,7 +97,6 @@ jobs:
       - name: install
         run: |
           npm ci
-          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - uses: ./.github/actions/upload-node-modules-and-artifacts

.github/workflows/release.yml

@@ -102,7 +102,6 @@ jobs:
       - name: install
         run: |
           npm ci
-          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - uses: ./.github/actions/upload-node-modules-and-artifacts

lib/cli/package-lock.json

@@ -24,7 +24,7 @@
       },
       "devDependencies": {
         "@types/ejs": "^3.1.2",
-        "@types/node": "^20.1.7",
+        "@types/node": "^20.14.14",
         "@types/shelljs": "^0.8.12",
         "typescript": "^4.9.5"
       }
@@ -62,10 +62,13 @@
       "dev": true
     },
     "node_modules/@types/node": {
-      "version": "20.1.7",
+      "version": "20.14.14",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.1.7.tgz",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.14.tgz",
-      "integrity": "sha512-WCuw/o4GSwDGMoonES8rcvwsig77dGCMbZDrZr2x4ZZiNW4P/gcoZXe/0twgtobcTkmg9TuKflxYL/DuwDyJzg==",
+      "integrity": "sha512-d64f00982fS9YoOgJkAMolK7MN8Iq3TDdVjchbYHdEmjth/DHowx82GnoA+tVUAN+7vxfYUgAzi+JXbKNd2SDQ==",
-      "dev": true
+      "dev": true,
+      "dependencies": {
+        "undici-types": "~5.26.4"
+      }
     },
     "node_modules/@types/shelljs": {
       "version": "0.8.12",
@@ -1229,6 +1232,12 @@
         "node": ">=4.2.0"
       }
     },
+    "node_modules/undici-types": {
+      "version": "5.26.5",
+      "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz",
+      "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==",
+      "dev": true
+    },
     "node_modules/util-extend": {
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/util-extend/-/util-extend-1.0.3.tgz",

lib/cli/package.json

@@ -35,7 +35,7 @@
   "license": "Apache-2.0",
   "devDependencies": {
     "@types/ejs": "^3.1.2",
-    "@types/node": "^20.1.7",
+    "@types/node": "^20.14.14",
     "@types/shelljs": "^0.8.12",
     "typescript": "^4.9.5"
   }

lib/cli/tsconfig.json

@@ -19,7 +19,7 @@
     "target": "es2018",
     "lib": ["es2018", "dom"],
     "baseUrl": ".",
-    "typeRoots": ["node_modules/@types"],
+    "typeRoots": ["node_modules/@types", "../../node_modules/@types"],
     "types": ["node"],
     "paths": {
       "@alfresco/js-api": ["../../dist/libs/js-api"],

lib/testing/tsconfig.lib.json

@@ -6,8 +6,8 @@
     "declarationMap": true,
     "resolveJsonModule": true,
     "paths": {
-      "@alfresco/js-api": ["../../../dist/libs/js-api"],
+      "@alfresco/js-api": ["../../dist/libs/js-api"],
-      "@alfresco/js-api/*": ["../../../dist/libs/js-api/*"]
+      "@alfresco/js-api/*": ["../../dist/libs/js-api/*"]
     }
   }
 }

package-lock.json

@@ -88,7 +88,7 @@
         "@types/jsdom": "^21.1.5",
         "@types/minimatch": "^3.0.3",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.10.0",
+        "@types/node": "^20.14.14",
         "@types/pdfjs-dist": "^2.10.378",
         "@types/selenium-webdriver": "^4.1.17",
         "@types/shelljs": "^0.8.15",
@@ -12313,9 +12313,9 @@
       "dev": true
     },
     "node_modules/@types/node": {
-      "version": "20.14.12",
+      "version": "20.14.14",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.12.tgz",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.14.tgz",
-      "integrity": "sha512-r7wNXakLeSsGT0H1AU863vS2wa5wBOK4bWMjZz2wj+8nBx+m5PeIn0k8AloSLpRuiwdRQZwarZqHE4FNArPuJQ==",
+      "integrity": "sha512-d64f00982fS9YoOgJkAMolK7MN8Iq3TDdVjchbYHdEmjth/DHowx82GnoA+tVUAN+7vxfYUgAzi+JXbKNd2SDQ==",
       "dependencies": {
         "undici-types": "~5.26.4"
       }

package.json

@@ -108,7 +108,10 @@
     "@editorjs/list": "1.9.0",
     "@editorjs/marker": "1.4.0",
     "@editorjs/underline": "1.1.0",
+    "@nx/angular": "16.10.0",
+    "@nx/eslint-plugin": "16.10.0",
     "@nx/js": "16.10.0",
+    "@nx/node": "16.10.0",
     "@nx/storybook": "^19.5.6",
     "@nx/workspace": "16.10.0",
     "@paperist/types-remark": "0.1.3",
@@ -126,7 +129,7 @@
     "@types/jsdom": "^21.1.5",
     "@types/minimatch": "^3.0.3",
     "@types/mocha": "^10.0.6",
-    "@types/node": "^20.10.0",
+    "@types/node": "^20.14.14",
     "@types/pdfjs-dist": "^2.10.378",
     "@types/selenium-webdriver": "^4.1.17",
     "@types/shelljs": "^0.8.15",
@@ -199,11 +202,8 @@
     "typescript": "5.1.6",
     "webdriver-manager": "12.1.9",
     "webpack": "^5.90.3",
-    "webpack-cli": "^5.1.4",
+    "webpack-cli": "^5.1.4"
-    "@nx/eslint-plugin": "16.10.0",
+  },
-    "@nx/node": "16.10.0",
-    "@nx/angular": "16.10.0"
- },
   "license": "Apache-2.0",
   "bundlesize": [
     {