tree shaking support for services (#3906)

[ADF-3697] tree shaking support for services

lib/core/services/alfresco-api.service.ts

@@ -39,7 +39,9 @@ import { OauthConfigModel } from '../models/oauth-config.model';
 
 /* tslint:disable:adf-file-name */
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AlfrescoApiService {
     /**
      * Publish/subscribe to events related to node updates.

lib/core/services/apps-process.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { LogService } from './log.service';
 import { map, catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AppsProcessService {
 
     constructor(private apiService: AlfrescoApiService,

lib/core/services/auth-guard-bpm.service.ts

@@ -21,7 +21,9 @@ import { AppConfigService, AppConfigValues } from '../app-config/app-config.serv
 import { AuthenticationService } from './authentication.service';
 import { OauthConfigModel } from '../models/oauth-config.model';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AuthGuardBpm implements CanActivate, CanActivateChild {
     constructor(private authService: AuthenticationService, private router: Router, private appConfig: AppConfigService) {}
 

lib/core/services/auth-guard-ecm.service.ts

@@ -23,7 +23,9 @@ import { AuthenticationService } from './authentication.service';
 import { AppConfigService, AppConfigValues } from '../app-config/app-config.service';
 import { OauthConfigModel } from '../models/oauth-config.model';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AuthGuardEcm implements CanActivate {
     constructor(private authService: AuthenticationService,
                 private router: Router,

lib/core/services/auth-guard.service.ts

@@ -25,7 +25,9 @@ import { Observable } from 'rxjs';
 import { AppConfigService, AppConfigValues } from '../app-config/app-config.service';
 import { OauthConfigModel } from '../models/oauth-config.model';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AuthGuard implements CanActivate, CanActivateChild {
     constructor(private authService: AuthenticationService,
                 private router: Router,

lib/core/services/authentication.service.ts

@@ -29,7 +29,9 @@ import { HttpHeaders } from '@angular/common/http';
 const REMEMBER_ME_COOKIE_KEY = 'ALFRESCO_REMEMBER_ME';
 const REMEMBER_ME_UNTIL = 1000 * 60 * 60 * 24 * 30;
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class AuthenticationService {
     private redirectUrl: RedirectionModel = null;
 

lib/core/services/comment-content.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from '../services/alfresco-api.service';
 import { LogService } from '../services/log.service';
 import { map, catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class CommentContentService {
 
     constructor(private apiService: AlfrescoApiService,

lib/core/services/comment-process.service.ts

@@ -23,7 +23,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { LogService } from './log.service';
 import { map, catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class CommentProcessService {
 
     constructor(private apiService: AlfrescoApiService,

lib/core/services/content.service.ts

@@ -26,7 +26,9 @@ import { AuthenticationService } from './authentication.service';
 import { LogService } from './log.service';
 import { catchError, tap } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class ContentService {
 
     private saveData: Function;

lib/core/services/cookie.service.ts

@@ -17,7 +17,9 @@
 
 import { Injectable } from '@angular/core';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class CookieService {
 
     /**

lib/core/services/deleted-nodes-api.service.ts

@@ -23,7 +23,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { UserPreferencesService } from './user-preferences.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class DeletedNodesApiService {
     constructor(
         private apiService: AlfrescoApiService,

lib/core/services/discovery-api.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { map, catchError } from 'rxjs/operators';
 import { Observable } from 'rxjs';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class DiscoveryApiService {
 
     constructor(private apiService: AlfrescoApiService) { }

lib/core/services/external-alfresco-api.service.ts

@@ -24,7 +24,9 @@ import {
 import * as alfrescoApi from 'alfresco-js-api';
 /* tslint:disable:adf-file-name */
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class ExternalAlfrescoApiService {
 
     protected alfrescoApi: AlfrescoApi;

lib/core/services/favorites-api.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { UserPreferencesService } from './user-preferences.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class FavoritesApiService {
 
     static remapEntry({ entry }: any): any {

lib/core/services/highlight-transform.service.ts

@@ -15,11 +15,16 @@
  * limitations under the License.
  */
 
+import { Injectable } from '@angular/core';
+
 export interface HightlightTransformResult {
     text: string;
     changed: boolean;
 }
 
+@Injectable({
+    providedIn: 'root'
+})
 export class HighlightTransformService {
 
     /**

lib/core/services/log.service.ts

@@ -22,7 +22,9 @@ import { AppConfigService, AppConfigValues } from '../app-config/app-config.serv
 import { logLevels, LogLevelsEnum } from '../models/log-levels.model';
 import { Subject } from 'rxjs';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class LogService {
 
     get currentLogLevel() {

lib/core/services/login-dialog.service.ts

@@ -21,7 +21,9 @@ import { Subject, Observable } from 'rxjs';
 import { LoginDialogComponent } from '../login/components/login-dialog.component';
 import { LoginDialogComponentData } from '../login/components/login-dialog-component-data.interface';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class LoginDialogService {
 
     constructor(private dialog: MatDialog) {

lib/core/services/nodes-api.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { UserPreferencesService } from './user-preferences.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class NodesApiService {
 
     constructor(

lib/core/services/notification.service.ts

@@ -19,7 +19,9 @@ import { Injectable } from '@angular/core';
 import { MatSnackBar, MatSnackBarRef, MatSnackBarConfig } from '@angular/material';
 import { TranslationService } from './translation.service';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class NotificationService {
 
     static DEFAULT_DURATION_MESSAGE: number = 5000;

lib/core/services/page-title.service.ts

@@ -20,7 +20,9 @@ import { Title } from '@angular/platform-browser';
 import { AppConfigService } from '../app-config/app-config.service';
 import { TranslationService } from './translation.service';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class PageTitleService {
 
     private originalTitle: string = '';

lib/core/services/people-content.service.ts

@@ -20,7 +20,9 @@ import { Observable, from, of } from 'rxjs';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class PeopleContentService {
 
     constructor(private apiService: AlfrescoApiService) {}

lib/core/services/people-process.service.ts

@@ -23,7 +23,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { LogService } from './log.service';
 import { catchError, map } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class PeopleProcessService {
 
     constructor(private alfrescoJsApi: AlfrescoApiService,

lib/core/services/renditions.service.ts

@@ -26,7 +26,9 @@ import { concatMap, switchMap, takeWhile } from 'rxjs/operators';
  * RenditionsService
  * (this service is deprecated in 2.2.0 and will be removed in future revisions)
  */
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class RenditionsService {
 
     constructor(private apiService: AlfrescoApiService) {

lib/core/services/search-configuration.service.ts

@@ -19,7 +19,9 @@ import { Injectable } from '@angular/core';
 import { QueryBody } from 'alfresco-js-api';
 import { SearchConfigurationInterface } from '../interface/search-configuration.interface';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class SearchConfigurationService implements SearchConfigurationInterface {
 
     constructor() {

lib/core/services/search.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { SearchConfigurationService } from './search-configuration.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class SearchService {
 
     dataLoaded: Subject<NodePaging> = new Subject();

lib/core/services/settings.service.ts

@@ -20,7 +20,9 @@ import { AppConfigService, AppConfigValues } from '../app-config/app-config.serv
 import { LogService } from './log.service';
 import { StorageService } from './storage.service';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class SettingsService {
 
     constructor(private appConfig: AppConfigService,

lib/core/services/shared-links-api.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { UserPreferencesService } from './user-preferences.service';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class SharedLinksApiService {
 
     constructor(private apiService: AlfrescoApiService,

lib/core/services/sites.service.ts

@@ -22,7 +22,9 @@ import { AlfrescoApiService } from './alfresco-api.service';
 import { SitePaging, SiteEntry } from 'alfresco-js-api';
 import { catchError } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class SitesService {
 
     constructor(

lib/core/services/storage.service.ts

@@ -17,7 +17,9 @@
 
 import { Injectable } from '@angular/core';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class StorageService {
 
     private memoryStore: { [key: string]: any } = {};

lib/core/services/thumbnail.service.ts

@@ -20,7 +20,9 @@ import { MatIconRegistry } from '@angular/material';
 import { DomSanitizer } from '@angular/platform-browser';
 import { ContentService } from './content.service';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class ThumbnailService {
 
     DEFAULT_ICON: string = './assets/images/ft_ic_miscellaneous.svg';

lib/core/services/translate-loader.service.ts

@@ -24,7 +24,9 @@ import { ComponentTranslationModel } from '../models/component.model';
 import { ObjectUtils } from '../utils/object-utils';
 import { map, catchError, retry } from 'rxjs/operators';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class TranslateLoaderService implements TranslateLoader {
 
     private prefix: string = 'i18n';

lib/core/services/translation.service.spec.ts

@@ -22,11 +22,8 @@ import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 
 import { TranslateLoaderService } from './translate-loader.service';
 import { TRANSLATION_PROVIDER, TranslationService } from './translation.service';
-import { LogService } from './log.service';
 import { AppConfigService } from '../app-config/app-config.service';
 import { AppConfigServiceMock } from '../mock/app-config.service.mock';
-import { UserPreferencesService } from './user-preferences.service';
-import { StorageService } from './storage.service';
 import { AlfrescoApiService } from './alfresco-api.service';
 import { AlfrescoApiServiceMock } from '../mock/alfresco-api.service.mock';
 
@@ -49,11 +46,7 @@ describe('TranslationService', () => {
             ],
             providers: [
                 { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
-                LogService,
                 { provide: AppConfigService, useClass: AppConfigServiceMock },
-                UserPreferencesService,
-                StorageService,
-                TranslationService,
                 {
                     provide: TRANSLATION_PROVIDER,
                     multi: true,

lib/core/services/translation.service.ts

@@ -28,7 +28,9 @@ export interface TranslationProvider {
     source: string;
 }
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class TranslationService {
     defaultLang: string;
     userLang: string;

lib/core/services/upload.service.ts

@@ -28,7 +28,9 @@ import {
 import { FileModel, FileUploadProgress, FileUploadStatus } from '../models/file.model';
 import { AlfrescoApiService } from './alfresco-api.service';
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class UploadService {
 
     private cache: { [key: string]: any } = {};

lib/core/services/user-preferences.service.ts

@@ -28,7 +28,9 @@ export enum UserPreferenceValues {
     SupportedPageSizes = 'supportedPageSizes'
 }
 
-@Injectable()
+@Injectable({
+    providedIn: 'root'
+})
 export class UserPreferencesService {
 
     defaults = {