update code as per code review

- upgrade demo project
- extend readme
- remove commented out unit tests
This commit is contained in:
Denys Vuika
2017-01-04 14:20:15 +00:00
parent 7ecf9f2fc3
commit fefe4b6963
5 changed files with 18 additions and 72 deletions

View File

@@ -189,35 +189,6 @@ describe('DocumentList', () => {
expect(documentList.loadFolder).not.toHaveBeenCalled();
});
/*
it('should emit folder changed event', (done) => {
spyOn(documentList, 'loadFolderByPath').and.returnValue(Promise.resolve());
documentList.folderChange.subscribe(e => {
done();
});
let newPath = '/some/new/path';
documentList.currentFolderPath = newPath;
documentList.ngOnChanges({currentFolderPath: new SimpleChange(null, newPath)});
});
*/
/*
it('should emit folder changed event with folder details', (done) => {
spyOn(documentList, 'loadFolderByPath').and.returnValue(Promise.resolve());
let path = '/path';
documentList.folderChange.subscribe(e => {
expect(e.path).toBe(path);
done();
});
documentList.currentFolderPath = path;
documentList.ngOnChanges({currentFolderPath: new SimpleChange(null, path)});
});
*/
it('should execute context action on callback', () => {
let action = {
node: {},