Commit Graph
2305 Commits
Author SHA1 Message Date
Suzana Dirla 192f93fdce [ADF-4984] Focus indicator is not clearly visible- mat-expansion-panel (#5217)
* [ADF-4984] make focused item visible

- the focus-fix will be done to all expansion-panels with upgrade to @angular/material 8.2.3

* [ADF-4984] make focused mat-expansion-panels visible

- get fix from @angular/material 8.2.3

* [ADF-4984] renaming
2019-11-08 18:26:35 +00:00
Denys Vuika 3fa6410e57 allow indexed access for DataRow objects (#5229) 2019-11-08 18:10:33 +00:00
davidcanonieto 2a76b0846d [AAE-485] Fix card view int item validator when value is empty (#5205)
* [AAE-485] Fix card view int item validator when value is empty

* Avoid creating a function every time we validate number

* Add return type to method
2019-11-08 16:06:22 +02:00
Suzana Dirla f0ac4b19ad [ADF-4986] Move or copy - Empty cells should not receive focus (#5226) 2019-11-08 16:02:42 +02:00
Eugenio Romano 5578b7b851 Should not redirect if is SilentLogin on (#5216)
* fix redirect

* fix lint

* remove false behaviour alrady tested in the new unit test

* Update auth-guard-base.ts
2019-11-06 11:56:01 +00:00
Eugenio Romano 7d36400dbd Remove discovery (#5212)
* remove discovery

* remoce discovery test

* fix save remote

* use host acs to save screenshot

* fix e2e

* remove invalid test

* fix the package version
2019-11-05 14:15:54 +00:00
Cilibiu Bogdan 040fc52724 [ADF-2990] Datatable - access header row via keyboard (#5206)
* header row as adf-datatable-row

* remove tabindex if header is hidden

* adjust logic if no row data is passed

* skip row focus if disabled

* set active row index on header interaction

* take in account header row

* fix header row and cells focus

* tests

* fix reference

* fix tests
2019-11-04 08:08:15 +00:00
Eugenio Romano 2e046945c7 [AAE-726] Add new return await rule (#5203)
* add new return await rule

* update tslint

* add lint exception
2019-10-30 19:29:43 +00:00
Silviu Popa 7698fb8edb [AAE-534] Core - add search cloud component (#5193)
* [AAE-534] - add search cloud component

* change doc file

* more changes on doc file

* remove empty scss file

* add animation and more customizations

* add preselect value property

* fix unit tests
2019-10-30 07:44:37 +00:00
Cilibiu Bogdan af6bd0892c [ADF-2990] Datatable - row navigation (#5198)
* datatable row component

* add to module

* implement datatable row component

* use FocusKeyManager for arrows navigation

* tests

* prevent screen reader to announce undefined value

* prevent from bubbling up

* fix unit test

* fix row locator

* fix locator reference

* fix row reference locators

* fix locator xpath
2019-10-30 07:39:43 +00:00
Suzana Dirla a150e74366 [ADF-4936] Auth guard redirect fix (#5092)
* [ADF-4936] fix for auth guard with silent Login true

* [ADF-4936] check only for isOAuth...

* [ADF-4936] fix all auth guards when silent Login true

* [ADF-4936] unit tests

* [ADF-4936] fix doc info

* [ADF-4936] types and null checks

* [ADF-4936] fallback option in case silentLogin is missing from settings

* [ADF-4936] refactoring

* try to fix e2e test [C299158] Login component - SSO Grant type password (implicit flow false)

* Fix e2e test [C299158] Login component - SSO Grant type password (implicit flow false)

* [ADF-4936] show the error page when route path is unknown

* [ADF-4936] remove ssoImplicitLogin and do the redirectToUrl instead

-the implicit login concern is already in the JS-API

* [ADF-4936] refactor to simplify code

- the removed 'if' conditions cover all possible 'else' cases

* [ADF-4936] remove unneeded method
2019-10-29 15:16:08 +00:00
siva kumar 9c2bcdee1a [ADF- 4871][TaskHeaderCloudComponent] Add Candidate Users/Groups properties (#5189)
* [ADF-4871] [TaskHeaderCloudComponent] Add Candidate Users/Groups properties

* Added Candidate users/groups properties to the task heade cloud component.

* * Created CardViewArrayItemComponent
* Modified FullName pipe to return username or email incase fullname missing.
* Added candidate Users/Groups properties to the taskcloudheader component.
* Added two service into task-cloudservice
* Updated Demoshell card-view with new widget

* * Fixed failing unit test

* * Fixed comments.

* * Refactored CardViewArrayItem model
* Fixed comments.

* * Changed candidate group icon
2019-10-29 09:26:34 +00:00
Suzana Dirla 6119ce83de [ADF-4966] Keep table headers - visually hidden when showHeader false (#5170)
* [ADF-4966] Move or copy - Add table headers - visually hidden

- needed by screen readers

* [ADF-4966] use automatic column header translation

* [ADF-4966] move the fix to the datatable component

-improve accessibility - keep table headers-but visually hidden for showHeader false

* [ADF-4966] code review change

* [ADF-4966] fix array shallow copy on failing e2e-test

* [ADF-4966] improve accessibility only for list display

- fixes failing test
2019-10-25 15:46:45 +01:00
Martin MullerandDenys Vuika ef229dd300 [ADF-4973] CLONE - Header - sidenav menu button expanded/collapsed state not exposed via ARIA (#5179)
* Set aria expanded for the sidenav toggle bar

* Define initialSidenavExpanded which can be set in the demo shell than as taken the same true or false value as the sideNav.expandedSidenav value.

* Added some unit tests for the sidenav toggle aria-expanded behaviour

* Update lib/core/layout/components/header/header.component.ts

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update lib/core/layout/components/header/header.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update demo-shell/src/app/components/app-layout/app-layout.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* Update lib/core/layout/components/header/header.component.html

Co-Authored-By: Denys Vuika <denys.vuika@alfresco.com>

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav

* As suggested from Denys remove initialSidnavExpanded property as we already have expandedSidenav
2019-10-24 22:54:32 +01:00
Maurizio Vitale 6331979baa [ADF-4857] Be able to run ng build content-service (#5183)
* Be able to build conten with ng build content-service

* fix tslint

* The translate module is necessary

* Rollback the build commands

* Rollback

* Remove wrong imports

* Trigger the build
2019-10-24 19:23:30 +01:00
Denys Vuika 7d12557a08 fix types 2019-10-24 15:08:11 +01:00
Martin Muller da154bb58f [ADF-4972] CLONE - Header - sidenav menu button aria-label not translatable (#5178)
* Make aria label fron header sidenav toggle button translateable

* Make aria label fron header sidenav toggle button translateable

* Make aria label fron header sidenav toggle button translateable
2019-10-24 12:58:03 +01:00
Eugenio Romano e667ec4f2f [AAE-174] Show radio box in text box when read only (#5182)
* show radio box in text box when read only

* show radio box in text box when read only
2019-10-23 12:23:11 +01:00
arditdomi 1970b1da82 [ADF-4964] Add enter and escape events for updating card view properties (#5167)
* [ADF-4964] Add enter and escape events for updating card view properties

* [ADF-4964] Add unit tests
2019-10-21 14:22:16 +01:00
davidcanonieto 2a033507b3 [AAE-485] Fix card view int item validator (#5135)
* [AAE-485] Fix card view int item validator

* Improve code

* Fix unit tests

* Remove outdated test

* Fix login of int validator

* Fix e2e test

* fix linting
2019-10-21 11:18:55 +01:00
davidcanonieto f2c1778eda [ADF-4595] Change demo-shell style classes prefix (#5132)
* [ADF-4595] Change demo-shell style classes prefix

* Change more files

* Trigger e2e tests

* Fix e2e selectors

* Fix e2e tests

* Fix e2e tests
2019-10-18 17:35:01 +01:00
dhrn baa0d6da30 [ADF-4947] Array type supported in data table columns (#5165)
* [WIP] [ADF-4947] Array type supported in data table columns

* * removed resolver for aria label

* * process services feature added

* * fixed docs
2019-10-18 00:01:52 +01:00
Martin Muller 12bbb993bd Show border when focus as wished in ACA-2504 (#5158) 2019-10-17 23:05:53 +01:00
Eugenio Romano 2ef6dc46e0 [ADF-4954] Notification history persist (#5154)
* persist notification in storage

* add max stack check

* add max stack check

* fix folder
2019-10-17 22:54:50 +01:00
Cilibiu Bogdan a60fb744c4 [ADF-4965] Viewer - pass navigate before and next event (#5166)
* pass event

* update docs
2019-10-17 19:25:54 +01:00
Martin Muller 85cd6d9506 Add aria label and role LINK to app title (#5168) 2019-10-17 19:15:45 +01:00
Cilibiu Bogdan ee5c90871a [ADF-4958] [ADF-4959] Info Drawer - Buttons don't have role and accessible by keyboard alone (#5161)
* actions accessibility

* lint

* access setEditMode by keyboard

* fix test

* update action automation id reference

* update element finder reference

* update automation id reference
2019-10-17 11:18:15 +01:00
Denys Vuika d7ab0417b8 [AAE-622] No implicit returns (#5157)
* enable noImplicitReturns rule

* type fixes

* fix return types

* fix return value

* fix tests

* fix visibility service

* update tests

* add missing types

* fix test
2019-10-17 09:35:39 +01:00
Eugenio Romano 48aca2d30f [ADF-4897] delete test-cookie after check (#5164)
* remove cookie test after check

* remove cookie test after check

* remove cookie test after check

* remove cookie test after check

* make nullable variable optional in cookie

* make nullable variable optional in cookie
2019-10-17 00:16:11 +01:00
Cilibiu Bogdan 8bb8231a83 mark aria headings (#5155) 2019-10-15 15:23:55 +01:00
Eugenio Romano 210f1d8f59 [#4961] Angular v9 (ivy) compatibility fixes #5153 (#5156)
* Angular 9 compatibility: add explicit types to prevent automatic deep imports

If you do not provide an explicit return type to a function then TypeScript
will try to guess it and create a dynamic import type for the `.d.ts` files.

Often the imports incorrectly point to a path deep within a package,
rather than accessing the type via the correct public facing import.

From Angular v9, using ivy, such deep imports cause compilation
errors and will prevent this library from being used for ivy enabled
applications.

This commit fixes this problem for a component and a service that
the adf-core library exports.

* Angular 9 compatibility: import DOCUMENT from `@angular/common`

In Angular 7 importing `DOCUMENT` from `platform-browser` was
deprecated, and it was removed completely in Angular 8.

* fix type afterlast alpha

* fix type after last alpha

* fix types demo shell
2019-10-15 15:22:42 +01:00
Eugenio Romano 0736a29d5c fix style issues (#5151) 2019-10-14 18:32:35 +01:00
Denys Vuika b3ca2166f0 upgrade js api (#5152)
* upgrade to latest js api

* add missing types

* remove useless function

* fix types

* enable strict mode

* Revert "enable strict mode"

This reverts commit 8e3f9c4563.
2019-10-14 18:28:01 +01:00
davidcanonieto 47ec01555a [ADF-4893] Fix visibility condition in datatable action menu (#5088)
* [ADF-4893] Fix visibility condition in datatable action menu

* Add filtering for when menu cache is disabled

* Fix unit test and improve code

* Fix linting

* Fix linting

* Add missing return type
2019-10-14 15:28:24 +01:00
maurizio vitale 82ae1e00d6 Fix the insight style path 2019-10-10 12:32:50 +01:00
Denys Vuika b1d0c50e88 [ADF-4926] fix attachments downloading (#5134)
* fix attachments downloading

* update code and tests
2019-10-10 12:06:36 +01:00
davidcanonieto 2def8d0557 [ADF-4861] Fix memory leak in Date widgets and Form Cloud Model (#5041)
* [ADF-4836] Fix memory leak in Date widgets and Form Cloud Model

* Remove unit tests based on old logic
2019-10-10 11:01:06 +01:00
Denys Vuika f731988ca6 [ADF-4911] migrate identity role service (#5096)
* migrate IdentityRoleService implementation

* update unit tests

* move interfaces to the origin

* move models to proper places

* migrate model to interface

* fix test

* update docs
2019-10-10 10:25:57 +01:00
Cilibiu Bogdan 8da16ea1a7 [ADF-4937] Viewer - Drag and Drop is not operable with keyboard alone (#5126)
* add keyboard event logic

* tests

* fix outline visibility
2019-10-09 17:52:26 +01:00
Cilibiu Bogdan 922e6ae3ab add aria-label attribute (#5138) 2019-10-08 10:30:06 +01:00
Andras Popovics ca79190880 Second part 2019-10-07 10:59:45 +01:00
Andras Popovics 14800ce399 [ADF-4896] Merging AMA and ADF notifications for a better world 2019-10-07 10:57:26 +01:00
Cilibiu Bogdan 922a85935e add sidebar button aria-expanded attribute (#5120) 2019-10-07 10:18:39 +01:00
Cilibiu Bogdan 6857213db6 trap focus for overlay viewer (#5127) 2019-10-06 18:08:15 +01:00
Suzana Dirla 9dd78b10f9 e2e fixes (#5129)
* fix e2e test [C260140] Copy - No permission folder

* Fix e2e test [C299158] Login component - SSO Grant type password (implicit flow false)
2019-10-06 18:05:52 +01:00
Cilibiu Bogdan 4a531dafcd don't use image path for alt text (#5130) 2019-10-06 18:04:50 +01:00
Suzana Dirla 3d604140d8 generic text (#5105) (#5121) 2019-10-02 18:56:10 +01:00
Eugenio Romano 2d58d2f458 bump 3.5.0 2019-09-30 17:34:25 +01:00
Eugenio Romano 20fa331d6f sso settigs fix (#5114)
* fix test

* update-js-api

* update-js-api

* invert test order for some reason

* split before save publicUrls

* split before save publicUrls

* [ADF-4810] split if publicUrls is not Array

* [ADF-4810]better check for string
2019-09-30 15:36:27 +01:00
Cilibiu Bogdan 9f22cb5cc7 fix focus outline (#5115) 2019-09-30 14:19:22 +01:00