133 Commits

Author SHA1 Message Date
Eugenio Romano
210f1d8f59 [#4961] Angular v9 (ivy) compatibility fixes #5153 (#5156)
* Angular 9 compatibility: add explicit types to prevent automatic deep imports

If you do not provide an explicit return type to a function then TypeScript
will try to guess it and create a dynamic import type for the `.d.ts` files.

Often the imports incorrectly point to a path deep within a package,
rather than accessing the type via the correct public facing import.

From Angular v9, using ivy, such deep imports cause compilation
errors and will prevent this library from being used for ivy enabled
applications.

This commit fixes this problem for a component and a service that
the adf-core library exports.

* Angular 9 compatibility: import DOCUMENT from `@angular/common`

In Angular 7 importing `DOCUMENT` from `platform-browser` was
deprecated, and it was removed completely in Angular 8.

* fix type afterlast alpha

* fix type after last alpha

* fix types demo shell
2019-10-15 15:22:42 +01:00
Denys Vuika
edc0945f39 fix "ng lint" command (#5012)
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
2019-08-29 16:35:30 +01:00
Denys Vuika
1abb9bfc89 [ADF-4745] memory leak fixes (#4931)
* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test
2019-07-16 15:56:00 +01:00
Eugenio Romano
b28a53afe7
Ban xit and xdescribe use in the future (#4923)
* remove xit test and ban xit and xdescribe use in the future

* remove xit test and ban xit and xdescribe use in the future

* remove test excluded

* remove consecutive blank line
2019-07-12 15:04:53 +01:00
Eugenio Romano
b1e7a594b8 fix flaky test 2019-06-14 13:19:26 +01:00
Cilibiu Bogdan
0cfc5bc1b7 [ADF-4625] Search Input does not respect RTL mode (#4806)
* configurable animation

* bind state attribute to value

* configure animation state based on direction

* update tests

* lint

* direction style
2019-06-04 09:15:44 +01:00
Denys Vuika
f89bf507f5 [ADF-4193] search error notifications and empty results (#4567)
* search error notifications and empty results

* update docs
2019-04-08 14:25:47 +01:00
Suzana Dirla
e656cc6977 [ADF-4323] Add style fixes from ACA (#4546)
* [ADF-4323] add style fix for adf-search-sorting-picker

- moved from ACA

* [ADF-4323] use Flex Layout's media query mixin

* [ADF-4323] add style fix for adf-pagination

- moved from ACA

* [ADF-4323] add style fix for adf-version-manager

- which fixed issue [ACA-1750]

* [ADF-4323] remove not used property

* [ADF-4323] remove extra bottom-border

* [ADF-4323] upload-drag-area refactor to scss

* [ADF-4323] add style fix for adf file upload

- from ACA

* [ADF-4323] add style fix for adf-info-drawer

- from ACA

* [ADF-4323] add style fix for adf-toolbar

- from ACA

* [ADF-4323] add style fix for adf-sidenav-layout

- from ACA

* [ADF-4323] add style fix for adf-search-filter

- from ACA

* [ADF-4323] add style fix for adf-upload-drag-area

- from ACA

* [ADF-4323] add style fix for adf-info-drawer

- from ACA

* [ADF-4323] move style fix for adf-manage-versions from demo-shell

* [ADF-4323] use Flex Layout's media query mixin

* [ADF-4323] small fix to remove scrolling

* [ADF-4323] add adf-sidenav-layout host element class

* [ADF-4323] change 'inline' class name to 'adf-toolbar--inline'

- css lint was failing because of old naming

* [ADF-4323] set pagination empty state styling

* [ADF-4323] set pagination border to none
2019-04-05 14:05:21 +01:00
Eugenio Romano
b35fb4df93 Merge branch 'development' into next-release-3.2.0 2019-03-29 16:17:03 +00:00
Suzana Dirla
888113fdc2 [ADF-4280] fix initial display for search-sorting-picker (#4522)
* [ADF-4280] fix initial display for search-sorting-picker

* [ADF-4280] fix unrelated error TS6133: 'renderingQueueServices' is declared but its value is never read

* [ADF-4280] update e2e test
2019-03-29 11:54:47 +00:00
Denys Vuika
3b1c4923b2 fix AOT 2019-03-27 12:18:10 +00:00
Eugenio Romano
89f612bbb0 update codelyzer last version wit accessibility check 2019-03-27 09:55:35 +00:00
Denys Vuika
a7a48e8b2b enable prefer-const rule for tslint, fix issues (#4409)
* enable prefer-const rule for tslint, fix issues

* Update content-node-selector.component.spec.ts

* Update content-node-selector.component.spec.ts

* fix const

* fix lint issues

* update tests

* update tests

* update tests

* fix code

* fix page class
2019-03-27 09:55:30 +00:00
davidcanonieto
f7a07967af [ADF-4179] Fix styles of facet-buttons (#4491) 2019-03-25 18:00:38 +00:00
Andy Stark
7fe066b068 [ADF-4249] Updates for doc review (#4454)
* [ADF-4249] Updates for doc review

* [ADF-4249] Clarified text slightly
2019-03-19 15:35:59 +00:00
davidcanonieto
8dc9eba4c7 [ADF-3677] Add highlight configuration to SearchQueryBuilder (#4358)
* [ADF-3677] Add highlight configuration to SearchQueryBuilder

* highlight property in search

* Update files.component.ts

* remove comma

* highlight missspell

* fix schhema json highilight

* fix test

* fix lint

* fix lint

* fix lint

* fix search sorting tests

* fix search sorting

* fix lint

* remove useless test

* check for null nodes

* remove duplicated test

* lint

* fix sorting tests

* remove test not search component related
2019-03-17 17:23:07 +00:00
Suzana Dirla
fb11cc879d [ADF-3401] Search filters - fix facet update (#4249)
* [ADF-3401] refactoring - different way to call the facet parsers

* [ADF-3401] fix duplicate search call

* [ADF-3401] add new fields and buckets from the response

- If a facet is already displayed, just update the bucket count, else add the new facet to the responseFields
- this way any existing filters are preserved, the collapsed state is preserved, facet selection is preserved

* [ADF-3401] reset & clear all selections buttons

* [ADF-3401] delete facets that are not in the response

- for better UX, prevent deletion of items from the category where there is a selected item
- clean-up reset buttons

* [ADF-3401] apply filters to the newly created items

* [ADF-3401] update tests

* [ADF-3401] fix after rebase

* [ADF-3401] Code refactoring

* [ADF-3401] show count value inside tooltip

* [ADF-3401] translatable strings

* [ADF-3401] move 'Clear all selections' button to search-chip-list

* [ADF-3401] option to configure having a reset button for filters

* [ADF-3401] code cleanup and improvements after review

* Update lib/content-services/search/components/search-filter/search-filter.component.ts

Co-Authored-By: suzanadirla <dirla.silvia.suzana@gmail.com>

* [ADF-3401] Better namings

* fix failing e2e tests on search radio

* [ADF-3401] add documentation for search resetButton
2019-03-05 14:08:38 +00:00
Suzana Dirla
71dca95749 [ADF-4083] search facetIntervals - empty spaced labels support (#4327)
* [ADF-4083] fix space-label issue for intervals

* [ADF-4083] remove mention to [SEARCH-1487] issue

- for future reference, also check https://issues.alfresco.com/jira/browse/ADF-4144

* [ADF-4083] add missing types

* [ADF-4083] refactor method

* [ADF-4083] fix test

* [ADF-4083] small refactoring

* [ADF-4083] better param naming

* [ADF-4083] changes after rebase - keep better param naming

* [ADF-4083] fix space-label issue for the sets of intervals

* [ADF-4083] update test
2019-02-25 19:49:36 +00:00
Suzana Dirla
bfec78aec9 [ADF-4083] search facetFields - empty spaced labels support (#4322)
* [ADF-4083] ignore wrapping quotes for facet labels

- bucket selection needs fixing

* [ADF-4083] fix bucket selection

- generate missing filterQuery values

* [ADF-4083] fix label display

* [ADF-4083] renaming

* [ADF-4083] support also single quotes label wrappings

- update documentation
- tests

* [ADF-4083] automatically escape facet field labels having spaces - better fix

* [ADF-4083] remove unneeded mentions from documentation

* [ADF-4083] clean-up code

* [ADF-4083] better naming param

* [ADF-4083] small refactoring
2019-02-21 12:49:47 +00:00
Suzana Dirla
e34f80aff7 [ADF-3497] Facet intervals on search filter (#4255)
* [ADF-3497] allow facetIntervals on search

* [ADF-3497] update schema json

* [ADF-3497] update json

* [ADF-3497] documentation update

* [ADF-3497] specify that sets are not supported

* [ADF-3497] no spaces on labels - mention

* [ADF-3497] documentation update

* [ADF-3497] update examples & document label key

* [ADF-3497] tests added

* [ADF-3497] testRail id

* [ADF-3497] allow config of custom pageSize values

* [ADF-3497] support mincount filtering also for intervals

* [ADF-3497] support expanded property also for facetIntervals

* remove no longer needed info

- bcs. of PR #4322 fix
2019-02-18 18:51:15 +00:00
Denys Vuika
f8549d43aa make search config optional (#4303) 2019-02-18 14:54:57 +00:00
Eugenio Romano
c55cba5514
license header update 2019 (#4300) 2019-02-12 01:18:43 +00:00
Andy Stark
1079361c2c [ADF-3745] Updates for doc review (#4291)
* [ADF-3745] Updates for doc review

* [ADF-3745] Fixed bad links to Content node selector page

* [ADF-3745] Updated index files
2019-02-08 21:21:06 +00:00
Suzana Dirla
bf718d905f [ADF-3496] Grouped facet queries (#4209)
* [ADF-3496] search query format v2 response parser

- replacer for the parseFacetFields

* [ADF-3496] format v2 search facetQueries parser

* [ADF-3496] cleanup

* [ADF-3496] Grouped facet queries

- selection working
- needs code cleanup

* [ADF-3496] code cleanup

* [ADF-3496] code refactoring - renaming

* [ADF-3496] update tests

* [ADF-3496] update tests part2

* [ADF-3496] preserve order

* [ADF-3496] fix facet queries expand

* [ADF-3496] code cleanup & fixes

* [ADF-3496] reorder methods

* [ADF-3496] update test

* fix unrelated failing test

* [ADF-3496] fix config snippet

* [ADF-3496] facet queries mincount

* [ADF-3496] documentation updated

* [ADF-3496] small fix

* [ADF-3496] e2e testing

* [ADF-3496] added TestRail ids

* [ADF-3496] import from right api
2019-02-04 21:38:21 +00:00
Eugenio Romano
2036e026f3
[no-issue] remove annoying dot at the end of search animation (#4226)
* remove annoying dot at the end of animation

* bypass protractor for click search bar
2019-02-01 13:19:56 +00:00
davidcanonieto
1c25b50b1a [ADF-1344] New Custom Loading Content Directive for Datatable Component (#4156)
* [ADF-1344] New Custom Loading Content Directive for Datatable Component

* [ADF-1344] Add unit tests for directives on Document List

* [ADF-1344] Add directive prefix to context-menu directive

* [ADF-1344] Old directive selectors have been put back

* [ADF-1344] Add old selector for empty-content directive
2019-01-25 12:15:28 +00:00
Eugenio Romano
7d061b2c11
[ADF-1873] Remove all deprecated code from ADF (#4145)
* remove deprecated code part 1

* remove deprecation step 2

* fix spellcheck

* fix

* fix lint

* fix not used import

* remove deprecation

* fix test first part after remove deprecation

* fix test

* fix sidebar demo shell
2019-01-15 15:36:01 +00:00
Andy Stark
b32654b236 [ADF-3745] Updated properties and doc comments (#4134) 2019-01-14 19:19:08 +00:00
Eugenio Romano
3ef7d3b7ea [ADF-] update library to use new js-api 3.0.0 (#4097) 2019-01-08 16:29:30 +00:00
davidcanonieto
95260a7ca7 [ADF-3802] Default ascending order fix (#4070) 2018-12-12 10:58:30 +00:00
samuelengelen
9881e52873 [ADF-3716] Add filterWithContains configuration option for SearchFilt… (#4017)
* [ADF-3716] Add filterWithContains configuration option for SearchFilterComponent

* [ADF-3716] Add unit test and modify translationMock
2018-12-05 14:25:57 +00:00
Denys Vuika
058d23d57f [ADF-3442] create library dialog (#4018)
* library dialog

* integrate with demo shell

* update resources

* fix license

* auto focus for the first input

* update e2e tests

* try close the dialog between tests

* fix afterEach

* Revert "try close the dialog between tests"

This reverts commit 63464f2b03c226c606d09b18c7d2782e3bb52c0a.

* update code due to css lint issues

* csslint settings for vs code

* missing import
lint fix
remove not used import
convert errorPage js to ts
convert tasklistpage js to ts
fix redirection creation folder in root
fix lint issue
fix e2e

* e2e fix

* fix PS tests

* navigation import

* fix tests tooltip
convert paginapage to ts

* fix lint

* fix lock files e2e
filterspage to ts

* fix lint

* fix cs cre
git dept 3 and not 50 as default in travis

* quiet log git download

* add some delay and change the delete lock

* fix node entry

* convert searchDialog to typescript
parallel protractor

* disable browser execute

* restote test

* change search tests

* move search in a separate e2e folder

* experiment fix e2e

* change util presence
change protractor conf

* fix unshare test

* improve query viewerPage using css over xpath

* waitForAngularEnabled before browser redirect

* convert util to ts and more

* convert other files to ts

* convert to ts other files

* trigger build

* function fixes use arrow function

* process service fixes

* lint fix
review timeout default

* fix failing tests

* restore timeout

* share dialog fix

* remove

* use configuration admin

* fix APS 2 login sso
2018-12-05 13:05:39 +00:00
davidcanonieto
1a21f234b6 [ADF-3746] Add style lint rules (#3975)
* add stylelint

* fix style first part

*  fix style second part

*  fix style third part

*  fix style fourth part

* Fix e2e tests first part

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* fix insights

* fix style abotu component

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* [ADF-3746] Rebase branch

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* Fix e2e tests second part

* Rebase branch

* Fix list error

* fix new style added

* tslint fix

* [ADF-3746] Fix scss errors on Process Filters Cloud component
2018-11-28 14:43:18 +00:00
Marouan Bentaleb
5fc03cf26b [ADF-3714] E2E for Search Slider Filter (#4007) 2018-11-28 11:44:56 +00:00
Marouan Bentaleb
885b8fb8b5 [ADF-3728] Automation tests for Search Number Range (#3974)
* [ADF-3728] Automation tests for Search Number Range

* Deleting Slider page and removing expects from PO

* Improving readability
2018-11-27 00:14:38 +00:00
Eugenio Romano
34a30c0f14
tslint arrow-parens rule (#4003) 2018-11-23 01:06:56 +00:00
jdosti
6e8677a768 [ADF-3713] Implement Search radio component tests (#3948)
* [ADF-3713] Implement Search radio component tests

* Fixing the double quotes and whitespaces

* Changing names of methods

* More renamings

* Removing trailing whitespace

* Refactoring of search filters tests

* Small changes
2018-11-20 00:41:07 +00:00
Andy Stark
54cbd210a1 [ADF-3745] Updates for doc review (#3970)
* [ADF-3745] Updated tutorial text

* [ADF-3745] Updates for doc review
2018-11-14 19:43:23 +00:00
davidcanonieto
f4cb3ac6a9 [ADF-3734] Fix search filters not wrapping (#3955)
* [ADF-3734] Fix search filters not wrapping

* [ADF-3734] Improve search filter bucket selector
2018-11-09 12:34:59 +00:00
Marouan Bentaleb
4a4b1519bf [ADF-3710] E2E for search date range (#3945)
* [ADF-3710] E2E for search date range

* Improving PR for [ADF-3710]
2018-11-07 19:34:45 +00:00
cristinaj
a6cd910466 [ADF-3715]Refactor search filters page (#3933)
* Add tests for text widget

* Propose refactor search filters component

* Fix lint errors

* [ADF-3715]Refactor searchFiltersPage

* Change describe

* Replaced use of searchDialog with browser.get

* Added a test case

* Modifications to enterConfiguration method

* Create a new method enterBigConfigurationText

* Fix lint issues

* no message
2018-11-03 17:02:31 +00:00
Denys Vuika
e39a2b149b [ADF-3591] spellcheck support for code (#3827)
* setup spellcheck
2018-10-23 15:05:38 +01:00
Denys Vuika
fee35c98df tree shaking support for services (#3906)
[ADF-3697] tree shaking support for services
2018-10-22 11:09:43 +01:00
Suzana Dirla
63fb4fc857 [ADF-3668] Search filter buckets are set to 0 after any search filtering (#3891)
* [ADF-3668] Fix facet fields 0 buckets

* [ADF-3668] add test for case when labels are i18n keys

* [ADF-3668] add translations on demo-shell - for manual testing

* [ADF-3668] allow translations for the bucket labels

* [ADF-3668] Fix facet queries buckets for translated labels

* [ADF-3668] Fix e2e tests

* [ADF-3668] Fix facet queries filtering when having translated labels

* [ADF-3668] add translations on demo-shell - for manual testing

* [ADF-3668] case covered by translationMock custom instant

* [ADF-3668] move test translations to demo-shell resources

* [ADF-3668] code review changes
2018-10-18 10:42:01 +01:00
Denys Vuika
f5a7b07370 [ADF-3593] remove rxjs-compat layer (#3886)
* remove rxjs-compat layer

* add rxjs linter

* observable new instead of create

* lint fixes

* disable rxjs-no-subject-value for certain scenarios

* fix auth rxjs
2018-10-16 19:45:00 +01:00
Suzana Dirla
6237af79d3 [ADF-3536] Search categories get collapsed/expanded to initial state after applying filter (#3835)
* [ADF-3536] fix expanded/collapsed issue

* [ADF-3536] clean up code
2018-10-01 14:16:00 +01:00
Andy Stark
58d765a355 [ADF-3551] Doc review updates (#3793)
* [ADF-3551] Updated docs and JSDocs

* [ADF-3551] Updated docs and JSDocs

* [ADF-3551] Updated docs and JSDocs
2018-09-14 14:41:25 +01:00
Andy Stark
3ba72f00f8 [ADF-3551] Updates for doc review (#3784)
* [ADF-3551] Updated doc comments

* [ADF-3551] Updated doc comments

* [ADF-3551] Doc files updated with new doc comments
2018-09-13 12:59:57 +01:00
Cilibiu Bogdan
3857364b39 subscribe until destroyed (#3776) 2018-09-12 13:03:12 +01:00
Suzana Dirla
6ddf028d93 [ADF-3510] Search facets date-range goes invalid when empty - fix (#3741) 2018-09-07 10:05:55 +01:00