Demonstration revert PR to check whether PRs #11880 and #11899 caused
the recent ADF release failures. The PR pipeline result will indicate
whether reverting the `cli:build` dependsOn edge (#11880) and the
`--omit=prod` install command (#11899) is sufficient to restore green
CI.
Reverts the relevant pieces of:
- #11880 (e3430ae36e): removes `dependsOn: ["installDeps"]` from
`cli:build`, and reverts the @typescript-eslint bump from 8.59.3
back to 8.57.2 / 8.41.0 in package.json + package-lock.json.
The dependabot `@typescript-eslint/*` grouping config is kept.
- #11899 (4044fafc39): restores the `cli:installDeps` command back
to plain `cd lib/cli && npm i` (the `--omit=prod` value is not a
valid npm flag).
Not intended for merge.
Co-authored-by: Cursor <cursoragent@cursor.com>
* [ci:force] AAE-46219 Remove redundant installDeps dependency from cli build target
The build target's installDeps dependency is already covered transitively
via bundle -> copyToNodeModules -> installDeps, and the duplicate npm i
caused a race condition that broke the ADF release.
Co-authored-by: Cursor <cursoragent@cursor.com>
* AAE-46219 Skip prod deps in cli:installDeps to unblock release
The release workflow rewrites lib/cli/package.json so @alfresco/js-api
points at an unpublished build-tagged version, then nx triggers
cli:installDeps (cd lib/cli && npm i) which fails ETARGET. tsc only
needs the devDependencies (typescript, @types/ejs, @types/node);
@alfresco/js-api is resolved via the tsconfig "paths" mapping to
dist/libs/js-api, not from node_modules. Adding --omit=prod skips the
unresolvable runtime deps without affecting the published package.
Also restores the build -> installDeps edge so tsc and npm install
do not race in lib/cli/node_modules.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Remove eslint-plugin-prefer-arrow dependency as the only rule from this plugin (prefer-arrow/prefer-arrow-functions) was disabled in all ESLint configurations.
* [AAE-45695] Group @typescript-eslint/* packages in dependabot
@typescript-eslint/parser and @typescript-eslint/eslint-plugin must be
bumped together (matching versions) due to a peer-dependency between
them. Grouping all @typescript-eslint/* packages ensures Dependabot
updates them in lock-step instead of opening separate PRs that fail
npm ci with a peer-dep conflict.
Co-authored-by: Cursor <cursoragent@cursor.com>
* [ci:force] AAE-45695 Bump @typescript-eslint/parser and eslint-plugin to 8.59.3
Bump both packages together (peer-dep requires matching versions) to
unblock the Dependabot bump that was previously failing.
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* Replace shelljs with native node api
* Refactor command execution in audit and changelog scripts to use spawnSync for improved security and error handling
* Migrate to NG17
* [ci:force] - fixed deps
* [ci:force] - fixed build for testing 1
* Fixed build for all the packages
* [ci:force] - fixing lint
* [ci:force] - Fixed lint
* AAE-26163 Fix infinite loop when authentication error event occured (#10272)
* AAE-26163 Logout user after 3 login attempts failed, avoiding infinite loop when an authentication error occured, like when a user machine clock is significantly out of sync
* AAE-26163 Wait to discovery document to be loaded and user not authenticated to perform a ssoLogin, logout user if login fails after 3 attempts
* AAE-26163 Fix missed id_token_hint invoking logout when a login error occured due to a clock significantly out of sync
* AAE-26163 Add fake observable to unit test
* AAE-26163 Show oauth event logs if showDebugInformation is enabled, remove auth items if access token is not valid
* AAE-26163 Improve tryLogin error message
* AAE-26163 Check if token has expired to fix case when user access the application after the token is expired and with a clock significantly out of sync
* AAE-26163 Test logout when clock is out of sync
* AAE-26163 Create a service to check if local machine time is out of sync
* AAE-26163 Update oauthErrorEvent$ and combinedOAuthErrorsStream$ to return errors
* AAE-26163 Output error within combined oauth error event subscription
* AAE-26163 Fix lint problems
* AAE-26163 Logout user when token refresh error happens for the second time, if the token is not refreshed properly after first refresh error
* AAE-26163 Logout user once an oauth error event occur due to clock out of sync
* AAE-26163 Fix retry login error message if the OAuthErrorEvent doesn t return reason
* AAE-26163 Fix the issue where the logout API call is canceled by the authorize call when login fails due to clock synchronization problems, causing an infinite loop.
* remove console.log
* AAE-26163 Fix retry login error message if the OAuthErrorEvent reason is an empty object
* Cherry picked commit from oidc and run fix lint
* [MIGRATION] - fixed build and lint
* [MIGRATION] - Added injectionContext to avoid error NG0203 for unit tests
* [MIGRATION] - Moving mocha to jest
* [MIGRATION] - Fixing failing migrated tests
* [MIGRATION] - Migrating to Jest - working but some tests fails
* Trying to fix js-api unit tests
* Removing testing lib to sync with develop
* Fixed two excluded unit tests
* Removed unused project parts
* Removed unused project parts
* Reduced tserrors on building storybook
* Fixed sonarqube errors
* Removing temporarily eslint rule from publishing
* [MIGRATION] - Fixed lint
* [MIGRATION] - Fixed type
* [MIGRATION] - Rebased
* [MIGRATION] - Readded removed action
* [MIGRATION] - Checking deps
* [MIGRATION] - updated lock
* [ACS-9052] manage versions close button is too low (#10466)
* [ci:force] - Fixed lint
* [ACS-9052] Fixed close button in version manager position
* [ACS-9052] Reverted unwanted changes
---------
Co-authored-by: VitoAlbano <vito.albano.123@gmail.com>
* [MIGRATION] - fixed storybook builds
* [MIGRATION] - Checking if now eslint is releasable
* [MIGRATION] - Changing the building executor for eslint-rules
* Readded rule for peer deps
* Fixed wrong rule
* [ACS-9075] Fixed incorrect buttons labels color (#10489)
* Update package.json
* Fix ACA pipeline
* [ACS-9084] Fixed incorrect color for notification bell icon (#10513)
* Change dialog label padding
* [AAE-26767] - Fixed lint
* [AAE-26767] - Fixed lint
* updated dependencies
* AAE-30733 Fix incorrect alignment of icons in permission list header
* [MIGRATION] - sync package-lock
* [MIGRATION] - Fixed package on core lib
* [MIGRATION] - Removed unused lock
* Fixed licence
* [MIGRATION] - sync lock file
* [MIGRATION] - fixed lint issues
* [ACS-9271][ACA] Login page input labels are cut if the input is not empty (#10637)
* AAE-31453 Override card-view-textitem readonly color
---------
Co-authored-by: Amedeo Lepore <amedeo.lepore@hyland.com>
Co-authored-by: Ehsan Rezaei <ehsan.rezaei@hyland.com>
Co-authored-by: AleksanderSklorz <115619721+AleksanderSklorz@users.noreply.github.com>
Co-authored-by: DominikIwanek <dominik.iwanek@hyland.com>
Co-authored-by: swapnil-verma-gl <92505353+swapnil-verma-gl@users.noreply.github.com>
Co-authored-by: Wojciech Duda <69160975+wojd0@users.noreply.github.com>
Co-authored-by: dominikiwanekhyland <141320833+dominikiwanekhyland@users.noreply.github.com>
dependabot[bot]
Denys Vuika
MichaelaandCursor
Vito Albano
Adam Świderski
AleksanderSklorz
Michal Kinas
Mykyta Maliarchuk
Grzegorz Jaśkowski
dominikiwanekhyland
Ehsan Rezaei
Rafal Szmit
Giovanni Toraldo
Matthias Holzer