517 Commits

Author SHA1 Message Date
Denys Vuika
d7ab0417b8
[AAE-622] No implicit returns (#5157)
* enable noImplicitReturns rule

* type fixes

* fix return types

* fix return value

* fix tests

* fix visibility service

* update tests

* add missing types

* fix test
2019-10-17 09:35:39 +01:00
Eugenio Romano
210f1d8f59 [#4961] Angular v9 (ivy) compatibility fixes #5153 (#5156)
* Angular 9 compatibility: add explicit types to prevent automatic deep imports

If you do not provide an explicit return type to a function then TypeScript
will try to guess it and create a dynamic import type for the `.d.ts` files.

Often the imports incorrectly point to a path deep within a package,
rather than accessing the type via the correct public facing import.

From Angular v9, using ivy, such deep imports cause compilation
errors and will prevent this library from being used for ivy enabled
applications.

This commit fixes this problem for a component and a service that
the adf-core library exports.

* Angular 9 compatibility: import DOCUMENT from `@angular/common`

In Angular 7 importing `DOCUMENT` from `platform-browser` was
deprecated, and it was removed completely in Angular 8.

* fix type afterlast alpha

* fix type after last alpha

* fix types demo shell
2019-10-15 15:22:42 +01:00
davidcanonieto
47ec01555a [ADF-4893] Fix visibility condition in datatable action menu (#5088)
* [ADF-4893] Fix visibility condition in datatable action menu

* Add filtering for when menu cache is disabled

* Fix unit test and improve code

* Fix linting

* Fix linting

* Add missing return type
2019-10-14 15:28:24 +01:00
Denys Vuika
90b2cee70d
[ADF-4894] Json editor dialog (#5082)
* move download-zip to its own folder

* json dialog

* update docs

* update test

* disable e2e test

* json widget for the Form

* remove deprecated test

* fix tests, update display text name
2019-09-20 07:26:37 +01:00
siva kumar
53471eae84 [ADF-4829] [ADF] [TaskListCloudComponent] Add action and context menu. (#5018)
* * Demo on list com

* [ADF-4828] [ADF] [ProcessListCloudComponent] Add action and context menu.

* Exposed action and context menu.
* Provided a way to in the demo shell to test action menu.
* Added required transaltion on demo shell.

* * Added doc

* [ADF-4829] [ADF] [TaskListCloudComponent] Add action and context menu.

* Exposed action and contect menu on tasklist page.

* * Added documentation.

* * Fixed typo

* * After rebase

* * Fixed failing e2e test on cloud demo tasklist

* * Added providedIn in Task/process cloud service.
2019-09-16 12:26:27 +01:00
arditdomi
c2c883885e [ADF-4878] Refactor, Split ADF About component (#5064)
* Refactor, Split ADF About component

* [ADF-4878] Add documentation

* [ADF-4878] Rename Component

* [ADF-4878] Implement comments

* [ADF-4878] Update documentation for about components
2019-09-12 15:02:28 +01:00
Maurizio Vitale
4de00fd6ca [ADF-4867] adf-error-component refactor (#5056)
* Refactor the adf-error-component
Move the custom buttons on demoshell
Fix unit test
Remove usefull e2e

* Add basic example
2019-09-07 10:29:19 +01:00
Denys Vuika
2360ccc6d5 [ACTIVITI-3720] cloud form support for form variable mapping (#5044)
* universal form model

* parse variables correctly

* turn group model into interface

* remove console.log

* interface instead of class

* update form id type

* improved form variable parsing

* improved variable conversion

* fix cloud tests

* fix typings and code bugs
2019-09-04 20:14:21 +01:00
Vito
19a17ca6e6 [ADF-4823] added download and show preview for attach cloud widget (#4996)
* [ADF-4823] fixed download and start fixing show preview

* [ADF-4823] fixed preview files

* [ADF-4823] - added unit test

* [ADF-4823] - fixed lint problem

* [ADF-4823] - rebased and fixed lint problem

* added a new method in BrowserActions to check that the action menu is visible, and using that in the tests.

* linting fixes
2019-09-03 11:10:40 +01:00
Denys Vuika
ce50e9a3d3 [ACTIVITI-3720] form variables enhancements (#5028)
* support form variables on the model level

* take 'variables.name' convention into account

* move API to a proper place

* unit tests and code fixes

* unit tests for form field model

* process variable interface
2019-09-02 11:20:54 +01:00
Denys Vuika
edc0945f39 fix "ng lint" command (#5012)
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
2019-08-29 16:35:30 +01:00
siva kumar
8c00919db0 [ADF-4828] [ProcessListCloudComponent] Add action and context menu. (#5009)
* * Demo on list com

* [ADF-4828] [ADF] [ProcessListCloudComponent] Add action and context menu.

* Exposed action and context menu.
* Provided a way to in the demo shell to test action menu.
* Added required transaltion on demo shell.

* * Added doc

* * Fixed comments.
2019-08-23 14:51:39 +01:00
davidcanonieto
e7c0852051 [ADF-4816] Refactor About component (#5000)
* [ADF-4816] Refactor About component

* Update package.json
2019-08-19 15:29:16 +01:00
Eugenio Romano
83412bb9b6
Disable control flow e2e ADF (#4954)
* update project script possible different JS-API

* first commit no controll flow

* second commit no controll flow

* third commit no controll flow

* 4 commit no controll flow

* 5 commit no controll flow

* 6 commit no controll flow

* 7 commit no controll flow

* 8 commit no controll flow

* 9 commit no controll flow

* 10 commit no controll flow

* 11 commit no controll flow

* 12 commit no controll flow

* 13 commit no controll flow

* 14 commit no controll flow

* 15 commit no controll flow

* 16 commit no controll flow

* 17 commit no controll flow

* 18 commit no controll flow

* 19 commit no controll flow

* 20 commit no controll flow

* remove wdpromise, protractor promise and deferred promises

* - fixed some incorrect “expect” calls
- fixed some matchers
- removed “return this;” when not needed
- added a few more await-s

* forgot a file

* fix some failing tests

* replaced driver calls with browser calls and enabled back waitForAngular

* fix rightClick methods and hopefully some tests

* fix settings-component

* some more fixes for core and content tests

* try to fix some more issues

* linting

* revert some changes, allowing download on headless chrome won’t work with multiple browser instances

* fixes for Search tests

* try to remove some wait calls

* fix build

* increase allScriptsTimeout and try another protractor and web driver version

* improve navigation methods

* some fixes for notification history and login sso

* forgot a space

* fix packages and enable some screenshots

* navigation bar fixes

* fix some test

* some fixes for notification history and navigation bar
use correct visibility method in attachFileWidget test

* fix searching and another fix for navigation

* try solve sso login

* some more fixes

* refactor async forEach into for..of

* try fix for search tests

* resolve rebabse problems

* remove install

* fix lint

* fix core e2e

* fix core e2e

* fix core e2e

* fix ps tests

* fix some tests

* fix core e2e

* fix core e2e

* fix core

* fix some issues PS

* fix core

* fix core

* fix some ps test

* fix rebase issues

* remove save

* fix url regressed after rebase

* fix url regressed after rebase

* fix ps and core

* fix lint

* more parallel e2e ps

* fix some ps cloud test

* some cloud fix

* fix lint

* fix some test

* remove files to be ignored

* out-tsc

* improve one cs test

* fix candidate base app

* fix ps test

* remove click function

* clean methods alrady present in browser action

* try ugly wait

* move wait

* remove duplicate call

* remove underscore

* fix after review

* fix imports

* minor cosmetic fixes

* fix comments test
2019-08-17 14:32:02 +02:00
siva kumar
eb2811fdd0 [ADF-4738] [Process -Cloud] Move GroupCloudService to adf-core (#4928)
* [ADF-4738] [Process -Cloud] Move GroupCloudService to adf-core lib.

* * Changed GroupModel to IdentityGroupModel
* Updated unit tests the recent changes.

* * Added documentation to the identityGroupService
* Updated GroupInitial and GroupCoudcomponent doc.

* * Created groupCount model. * Updated unit test to the recent changes

* * After rebase updated doc

* * Fixed comments.
2019-08-12 16:27:30 +01:00
siva kumar
d51e22f9f4 * Fixed theaming issue on the filters* Fixed fixed clear action default value. (#4980) 2019-08-07 20:48:06 +02:00
siva kumar
0bca6607a9 [ADF-4793] The filters don't work on community-edition [ Use local storage for community version ] (#4973)
* * Use local storage for community version.

* * Created a communityModule.

* * Updated unit tests the recent changes

* * Updated documents.

* * Modified process/task filters doc.
2019-08-07 00:37:32 +02:00
siva kumar
05e73a8aa1 [ADF-4755][CardViewDate&SelectItemComponent] Provide a way to reset date and none option as default. (#4955)
* [ADF-4755] [CardViewDateItemComponent] Provide a way to reset date.

* Added clear icon to reset date to empty.
* Added Translation key to the new icon.

* * Added displayClearAction flag to toggle clear action.* Added None as default for the selectItem components.* Added displayNoneOption flag to toggle the default none option.

* * Fixed comments.

* * Added translation key for 'none'  option.

* * Updated dateItem css to the match recent changes.

* * Fixed failing unit tests* Updated TaskHeader components with the displayClearAction.

* * Updated demo shell card-view component to test the latest changes
2019-07-26 12:22:45 +01:00
davidcanonieto
a0d4160c11 [ADF-4713] Add new DecimalNumber Pipe to transform and localize numbers (#4926)
* [ADF-4713] Add new DecimalNumber Pipe to transform and localize numbers

* Unsubscribe from userPreference service

* Make Pipe impure

* Add documentation in localization page
2019-07-18 12:09:50 +02:00
Denys Vuika
1abb9bfc89 [ADF-4745] memory leak fixes (#4931)
* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test
2019-07-16 15:56:00 +01:00
cristinaj
48097c4d2a [ADF-4471]Reload task header after claim/unclaim (#4875)
* Reload task header
2019-07-13 16:29:51 +01:00
Eugenio Romano
5ce06d80cb remove wrong use of get in translation service 2019-07-11 19:50:03 +01:00
Cilibiu Bogdan
ccdcba8778 [ADF-4424] Pdf Viewer - password dialog does not close when pressing Escape (#4622)
* return to previous page on close

* update e2e

* [ADF-4424] Improve PreviousRouteService to use it in pdfViewer

* change previous Url logic

* remove navigation logic

* remove test

* Update pdfViewer.component.spec.ts

* back button logic for viewer outlet

* unit tests

* remove fdescribe

* remove unused service

* e2e

* return to location

* remove click filter step

* remove unnecessary test steps

* remove un existen export

* unify preview between PS and CS in demo shell

* fix dispalyname property
2019-07-11 17:33:15 +01:00
Eugenio Romano
79a95ecd5d use instant pipe translate in demo shell error message 2019-07-11 16:24:18 +01:00
Geeta Mandakini Ayyalasomayajula
fadcc19eba e2e tests for favourite directive (#4912)
* in progress - favourite directive e2e tests

* in progress - favourite directive e2e tests

* favourite directive e2e tests

* update testcase name

* updated test case names

* remove unnecessary line spaces

* refactored favourites to favorites
2019-07-10 09:56:28 +01:00
Geeta Mandakini Ayyalasomayajula
65dc1a5c31 Test cases for Edit Folder Directive (#4910)
* added tests for Edit Folder Directive

* added tests for Copy and Move actions on no permission folder.

* moved the checkDisabled function to BrowserActions to make it reusable.

* updated method name
2019-07-09 15:30:37 +01:00
Marouan Bentaleb
080eef891b Changes required to adf-testing (#4904) 2019-07-09 11:38:48 +01:00
mcchrys
abc376ff33 [ADF-4711] User Preferences in Task Filter (#4891)
* [ADF-4711] User Preferences in Task Filter
2019-07-08 16:29:47 +01:00
siva kumar
b88888b5e4 [ADF-4614] User preferences in process filters (#4889)
* * Created UserPreferenceCloudService.

* * Refactored processfiltercloud service.
* Refactored user-preferncecloud service.
* Added unit tests to the services.

* * Updated unit tests
* FIxed Synx problem.

* * Fixed edit-filter error.

* * Fixed failing edit-process-filter unit test.

* * Added comments in processfilter/prefernces services.

* * Fixed memory leak* Added a spinner in the edit-process-filter component

* * Fixed comments.

* * Removed unnecessary filter property
2019-07-05 11:52:36 +01:00
Denys Vuika
c9b7722bd0 fix css class name typo (#4895)
* fix css class name typo

* fix more typos
2019-07-03 12:08:12 +01:00
Silviu Popa
43f08441cd [ADF-4705] - Automate forms checkbox widget (#4881)
* [ADF-4705] - Automate forms checkox widget

* Move methods to a demo-shell page

* Adding 3 new tests
2019-07-01 11:33:34 +01:00
davidcanonieto
334ebd1256 [ADF-4338] Add locale to CardViewDateItemModel and improve logic of LocalizedDat… (#4845)
* Add locale to CardViewDateItemModel and improve logic of LocalizedDatePipe

* Fix e2e tests

* Fix e2e tests

* Fix C305010 test
2019-06-14 17:26:08 +01:00
Eugenio Romano
e578e5dc14 minor fix style demo shell process file list 2019-06-14 13:30:05 +01:00
Denys Vuika
f64cd9cffd
[ADF-4640] share dialog fixes (#4830)
* unshare fixes and error notifications

* fix disabled toggles issue

* code fixes and separate interface

* remove 'isFavorite' include

* safety checks for properties

* update e2e

* refactor test after functionality change

* fix issue with the missing properties

* safety checks
2019-06-12 17:21:23 +01:00
Maurizio Vitale
63f00e21cf [ADF-4468] FormCloud - Be able to display the value of a form variables (#4676)
* Fix the value passed as processDefinition
Be sure we fetch the form variables

* * Rename formId to formKey.

* * Reverted form Changes

* * Fixed failing unit test

* Fix the value passed as processDefinition
Be sure we fetch the form variables

* * Fixed failing unit test

* * Rename formId to formKey.

* * Reverted form Changes

* * Fixed failing unit test

* Fix form representation structure

* Refactor form models

* Change tslint config

* Fix lint

* Refactor form models

* Remove duplicated export

* improve variable names

* Update form mock
2019-06-12 12:50:09 +01:00
davidcanonieto
f42e1a4ada [ADF-4041] Fix preselected user selection on People Cloud Component (#4648)
* [ADF-4041] Fix preselected user selection on People Cloud Component

* [ADF-4041] Fix unit test and add new one

* [ADF-4041] Fix validation of users

* Improve code

* Fix C309677 test
2019-06-11 22:47:06 +01:00
Eugenio Romano
924c20d410 remove duplicated column and fix null in checkbox 2019-06-11 17:28:12 +01:00
Maurizio Vitale
7b191d37eb [ADF-4631] Start Process Cloud - Add the start form as part of a process (#4820)
* Add the start form as part of a process
Ability to pre-fill a form with values
Ability to send variables

* Fix unit test

* remove empty before each
2019-06-11 12:02:26 +01:00
davidcanonieto
7497822a46 [ADF-4342] Create localized pipe and centralize date format (#4813)
* [ADF-4342] Date Format defined in app config

* [ADF-4342] Create localized pipe and centralize date format

* Add unit test for new date pipe

* Add info internationalization docs

* Fix lining

* Fix linting

* Fix date pipe unit test

* [ADF-4342] Add supported language files

* Fix e2e tests
2019-06-11 09:35:35 +01:00
Eugenio Romano
5e54cd4d43
Increase timeout and modify login async (#4795)
* increase timeout and modify login async

* run e2e if testing is changed

* improve cdk fix

* fix travis update projects

* disable ghostMode lite server

* lint fix

* fix timeout

* multiple try

* Update content-services-e2e.sh

* Update search-e2e.sh

* Update process-services-e2e.sh

* Update core-e2e.sh

* Update protractor.conf.ts

* fix unit

* remove async

* increqase notification time

* 3 parallel

* dix path issue in save

* small refactor protractor ts

* fix save

* create license check first script adf cli

* modify regex check

* refactor notification history component

* decrease notification

* fix notification message problem

* fix test

* update packages wit high risk

* revert cahnge login sso e2e

* fix dep

* fix documentation duplication and issue

* fix after review

* fix after review

* try 6 parallel test

* back to 3 parallel test no real time improve with 6
2019-06-06 16:47:50 +01:00
Suzana Dirla
3d73e94b5d [ADF-4402] Move component related styles from demo-shell to ADF components (#4808)
* [ADF-4402] remove styling of non-existent items

* [ADF-4402] remove not needed style - bcs overwritten by style from core

* [ADF-4559] remove demo-shell only class from core styling

- use class name from core component for styling

* [ADF-4402] remove not used styling code

- .adf-app-layout-toolbar no longer exists, so no need keep its style

* [ADF-4402] move style from demo-shell to core

- same style was needed in ACA, so probably should be best in core ADF

* [ADF-4402] remove not used styling code

* [ADF-4402] move adf-toolbar-title style from demo-shell to core

* [ADF-4402] remove not used styling code

* [ADF-4402] use existing css class

* [ADF-4402] remove style already set from pagination component

* [ADF-4402] remove not used styling code

* [ADF-4402] viewer toolbar width
2019-06-05 16:01:38 +01:00
Deepak Paul
7eb9ffe688 [ADF-4546] Visibility conditions for Form variables don't work on Multiline Widget. (#4786)
* * Finding variable values by id & used date format

* * Tests to validate visibility by using id

* * [ADF-4529] Refactor conditions

* [ADF-4529] Fixed cloud form editor script error
2019-05-31 13:58:45 +01:00
Deepak Paul
f27846ec5b [ADF-4544] Cloud Task From - Refresh the buttons and form after an action is complete (#4726)
* [ADF-4544] Reloaded task on action

* [ADF-4544] Changed routing in demo component

* [ADF-4544] Added tests
2019-05-31 10:07:08 +01:00
Cilibiu Bogdan
9aafb80483 [ADF-4601] DemoShell - Side navigation RTL support (#4768)
* rtl support

* fix lint

* Run e2e in case demoshell has been changed

* Skip file

* Skip file

* remove demoshell directive

* refactor side navigation

* remove env.cloud file

* class name selectors

* side navigation selectors

* fix clickMenuButton selector

* nested menu element context

* fix notification navigation selector
2019-05-29 20:02:15 +01:00
Cilibiu Bogdan
9cf6f5519c [ADF-4579] Layout - RTL support (#4741)
* single contentAnimation state

* fine tune contentAnimation state based on direction and position

* tets

* fix mock component inputs

* use native direction attribute

* update docs

* pass direction to calculate sidenav layout

* update test

* fix unit test

* remove dialogs directionality workaround

* set document directionality service

* remove context menu direction workaround

* remove unneeded dependencies

* remove direction style workaround

* remove permission icon direction

* remove sidenav layout direction attribute

* update docs

* update sidenav layout direction

* test

* remove document type

* update test dependencies

* clear storage before test

* test

* fix dl gap

* try to fix Uncaught QuotaExceededError

* fix QuotaExceededError

* fix tests

* fix tests
2019-05-29 16:17:13 +01:00
davidcanonieto
f2f08a5bf8 [ADF-4529] Enable form configuration from e2e tests (#4738)
* [ADF-4529] Enable form configuration from e2e tests

* Improve linting

* Move form methods to new  file
2019-05-28 15:27:26 +01:00
arditdomi
6897f20954 [ADF-4466] Fix alignment issues - IE11 (#4772)
* [ADF-4466] Fix alignment issues - IE11

* [ADF-4466] Fix implementation from demo shell specific to generic

* [ADF-4466] Remove unused query for IE11
2019-05-24 16:41:19 +01:00
Cilibiu Bogdan
58cf10be5f [ADF-4582] User preference - set layout orientation based on locale (#4744)
* set textOrientation based on locale

* remove manually setting textOrientation

* tests

* revert to getBrowserCultureLang

* match languages keys

* update tests

* fix types
2019-05-22 14:02:51 +01:00
Silviu Popa
d1bc5a608a [ADF-4389] StartProcessCloud - add validation for processName (#4707)
* [ADF-4389] StartProcessCloud - add validation for processName

* [ADF-4389] - change function definition name

* [ADF-4389] - add return type
2019-05-14 15:19:43 +01:00
Denys Vuika
ac224a0b82
[ADF-4489] metadata errors demoshell (#4720)
* raise errors in demo shell for metadata

* remove commented out code
2019-05-14 11:45:07 +01:00